From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA647C43381 for ; Tue, 5 Mar 2019 11:19:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2F9D2082C for ; Tue, 5 Mar 2019 11:19:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="vMrUilgD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727666AbfCELTJ (ORCPT ); Tue, 5 Mar 2019 06:19:09 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40072 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726098AbfCELTJ (ORCPT ); Tue, 5 Mar 2019 06:19:09 -0500 Received: by mail-wr1-f65.google.com with SMTP id q1so9019875wrp.7 for ; Tue, 05 Mar 2019 03:19:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=gDlUV+t+5fkrmS2LOTk2JHuqeoAm6EBFbwegOGMT7N4=; b=vMrUilgDW3ASEeHmC5VRmGoRPxyoGaA/Gd7Lw+xWY9pKvlHrycfhB18ArCQOHvHrpH n6Q505a9XWH0v7ZBzUl5eZCarXiDqxeV80zf6Hz5hLodhCiwwhocoXbNyObFIFuaex/T E1mYh5Ln1+YWe4Ecptq5aQbyFtRWKVWOMIQ/zg5SyFNOCEcYJGx8ONzngttK3CDALCrZ b8BoX54AOjd3S/ZuydU+JV64zmCeA805wD5adiyhcQzsN06r6D1AdP/1/UMqE4jYdaIi IPesFDA1w6Yi4iSh3xEqcYtIySUyOH0zhF0/zdR2nhjwYl1rULPsdLhVIYgLYK2i0Pr2 gNIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gDlUV+t+5fkrmS2LOTk2JHuqeoAm6EBFbwegOGMT7N4=; b=h6JFLoEOhh48FxFAsA1T7SHmw+gfuCC6IkMqmv+oGfFopoPIIqntriuNOrXbPtOxcY s9jXZweR4cU4Gxhf6dQs8yx6eJniuy4l4GIPjb9g0FCQY2XVci2rmCisFrnXxddwJN7v AIp6SvpcugKSjSQk8AQX1RID9Eg66IW0iBUM/OXvr1XH7FU8i4eNWTn8f4CVkZkK05hy kCwcTY23Vl6bOGnjMlFJzNh36tv3KHYeZLlgTXZ8QZOov4nQDa/Ocv2qyncb13Ly+yve LD2zZpG6YBAi4/Y9a6P3e8p1y2mvZajJNF0xRqChlZexPWdvttMg3WHOFJs9NHFKlxhj TJpg== X-Gm-Message-State: APjAAAW2nKbKOuPR7a/0YGnaN856SHPjESQOcfvAeoVlMapIm/BRdL6C DgoYJ2NNdOQaJxqFmYCjaARMPw== X-Google-Smtp-Source: APXvYqyj0aWqRyXrjXc32d1OmsquEb8GrSJERAb8jFmhkW9BfB5bLlVQUj2g7lNLj+IMLXSPpK7evg== X-Received: by 2002:adf:9d85:: with SMTP id p5mr15740447wre.215.1551784747563; Tue, 05 Mar 2019 03:19:07 -0800 (PST) Received: from localhost (ip-89-177-134-16.net.upcbroadband.cz. [89.177.134.16]) by smtp.gmail.com with ESMTPSA id k203sm9263439wmf.44.2019.03.05.03.19.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Mar 2019 03:19:07 -0800 (PST) Date: Tue, 5 Mar 2019 12:09:20 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Message-ID: <20190305110920.GE2314@nanopsycho> References: <20190301180453.17778-1-jakub.kicinski@netronome.com> <20190301180453.17778-5-jakub.kicinski@netronome.com> <20190304110857.GW2314@nanopsycho> <20190304165159.6a6501a2@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190304165159.6a6501a2@cakuba.netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Mar 05, 2019 at 01:51:59AM CET, jakub.kicinski@netronome.com wrote: >On Mon, 4 Mar 2019 12:08:57 +0100, Jiri Pirko wrote: >> Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicinski@netronome.com wrote: >> >PCI endpoint corresponds to a PCI device, but such device >> >can have one more more logical device ports associated with it. >> >We need a way to distinguish those. Add a PCI subport in the >> >dumps and print the info in phys_port_name appropriately. >> > >> >This is not equivalent to port splitting, there is no split >> >group. It's just a way of representing multiple netdevs on >> >a single PCI function. >> > >> >Note that the quality of being multiport pertains only to >> >the PCI function itself. A PF having multiple netdevs does >> >not mean that its VFs will also have multiple, or that VFs >> >are associated with any particular port of a multiport VF. >> > >> >Example (bus 05 device has subports, bus 82 has only one port per >> >function): >> >> How do you plan to added/remove these subports? > >I can't say I got that figured out fully, but I was wondering if we can >have some form of: > >$ devlink partition pci/0000:82:00.0 new >pci/0000:82:00.0/1001002 Parav has something similar in his proposal. Lets figure out the port/non-port dillema first, then we can design this api. > >Which would create appropriate sub-port and port (-repr-) netdev. > >Plus optionally the ability to work with something like the already >existing mdev infrastructure for passing to a VM. But I haven't even >looked at that, yet.