Hi Paul, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.0] [cannot apply to next-20190304] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Paul-Cercueil/Ingenic-TCU-patchset/20190305-054726 config: x86_64-allmodconfig (attached as .config) compiler: gcc-8 (Debian 8.2.0-21) 8.2.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): In file included from include/linux/printk.h:7, from include/linux/kernel.h:14, from include/linux/clk.h:16, from drivers/clocksource/ingenic-timer.c:8: drivers/clocksource/ingenic-timer.c: In function 'ingenic_tcu_clk_init': >> include/linux/kern_levels.h:5:18: warning: format '%i' expects argument of type 'int', but argument 2 has type 'size_t' {aka 'long unsigned int'} [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^~~~~~ include/linux/kern_levels.h:10:19: note: in expansion of macro 'KERN_SOH' #define KERN_CRIT KERN_SOH "2" /* critical conditions */ ^~~~~~~~ include/linux/printk.h:301:9: note: in expansion of macro 'KERN_CRIT' printk(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~ drivers/clocksource/ingenic-timer.c:436:4: note: in expansion of macro 'pr_crit' pr_crit("ingenic-timer: cannot register clock %i\n", i); ^~~~~~~ drivers/clocksource/ingenic-timer.c:436:51: note: format string is defined here pr_crit("ingenic-timer: cannot register clock %i\n", i); ~^ %li -- In file included from include/linux/printk.h:7, from include/linux/kernel.h:14, from include/linux/clk.h:16, from drivers//clocksource/ingenic-timer.c:8: drivers//clocksource/ingenic-timer.c: In function 'ingenic_tcu_clk_init': >> include/linux/kern_levels.h:5:18: warning: format '%i' expects argument of type 'int', but argument 2 has type 'size_t' {aka 'long unsigned int'} [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^~~~~~ include/linux/kern_levels.h:10:19: note: in expansion of macro 'KERN_SOH' #define KERN_CRIT KERN_SOH "2" /* critical conditions */ ^~~~~~~~ include/linux/printk.h:301:9: note: in expansion of macro 'KERN_CRIT' printk(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~~ drivers//clocksource/ingenic-timer.c:436:4: note: in expansion of macro 'pr_crit' pr_crit("ingenic-timer: cannot register clock %i\n", i); ^~~~~~~ drivers//clocksource/ingenic-timer.c:436:51: note: format string is defined here pr_crit("ingenic-timer: cannot register clock %i\n", i); ~^ %li vim +5 include/linux/kern_levels.h 314ba352 Joe Perches 2012-07-30 4 04d2c8c8 Joe Perches 2012-07-30 @5 #define KERN_SOH "\001" /* ASCII Start Of Header */ 04d2c8c8 Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII '\001' 04d2c8c8 Joe Perches 2012-07-30 7 :::::: The code at line 5 was first introduced by commit :::::: 04d2c8c83d0e3ac5f78aeede51babb3236200112 printk: convert the format for KERN_ to a 2 byte pattern :::::: TO: Joe Perches :::::: CC: Linus Torvalds --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation