All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Slavomir Kaslev <kaslevs@vmware.com>
Cc: Yordan Karadzhov <ykaradzhov@vmware.com>,
	linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH 1/3] kernel-shark: Define free_contex function for the sched_events plugin
Date: Tue, 5 Mar 2019 12:11:11 -0500	[thread overview]
Message-ID: <20190305121111.1b2d8b2c@gandalf.local.home> (raw)
In-Reply-To: <20190305155425.GA19674@box>

On Tue, 5 Mar 2019 17:54:26 +0200
Slavomir Kaslev <kaslevs@vmware.com> wrote:


> Nit: there's a typo in the commit message
> 
> >    kernel-shark: Define free_contex function for the sched_events plugin  
>                                      ^
> :s/free_contex/plugin_free_context/g ?

I caught that too, and fixed it.


> 
> Other than that it looks good to me.
> 
> Reviewed-by: Slavomir Kaslev <kaslevs@vmware.com>

Thanks Slavomir,

I'll add your review tag.

-- Steve

  reply	other threads:[~2019-03-05 17:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05 14:39 [PATCH 0/3] Improvements and fixes for sched_switch plugin Yordan Karadzhov
2019-03-05 14:39 ` [PATCH 1/3] kernel-shark: Define free_contex function for the sched_events plugin Yordan Karadzhov
2019-03-05 15:54   ` Slavomir Kaslev
2019-03-05 17:11     ` Steven Rostedt [this message]
2019-03-05 14:39 ` [PATCH 2/3] kernel-shark: Fix a memory leak in " Yordan Karadzhov
2019-03-05 15:56   ` Slavomir Kaslev
2019-03-05 17:12     ` Steven Rostedt
2019-03-05 17:07   ` Steven Rostedt
2019-03-05 14:39 ` [PATCH 3/3] kernel-shark: sched_events plugin init with sched_switch events only Yordan Karadzhov
2019-03-05 15:57   ` Slavomir Kaslev
2019-03-05 17:13     ` Steven Rostedt
2019-03-05 17:09   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190305121111.1b2d8b2c@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=kaslevs@vmware.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=ykaradzhov@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.