Re: [Outreachy kernel] [PATCH v2 4/4] staging: ralink-gdma: Remove whitespace and add blank line

[Greg KH <greg@kroah.com>]

On Tue, Mar 05, 2019 at 02:57:18PM +0200, Daniela Mormocea wrote:
> Delete unnecessary whitespace after cast, and
> add blank line after declarations to avoid warnings.
> 
> Signed-off-by: Daniela Mormocea <daniela.mormocea@gmail.com>
> ---
> Changes in v2:
> -make these a patch series
> 
>  drivers/staging/ralink-gdma/ralink-gdma.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
> index 44a65e2..012213f 100644
> --- a/drivers/staging/ralink-gdma/ralink-gdma.c
> +++ b/drivers/staging/ralink-gdma/ralink-gdma.c
> @@ -127,6 +127,7 @@ struct gdma_dma_dev {
>  	struct gdma_data *data;
>  	void __iomem *base;
>  	struct tasklet_struct task;
> +
>  	volatile unsigned long chan_issued;
>  	atomic_t cnt;

Checkpatch is wrong here, there should not be an extra line :(

It's getting confused as the code should not have 'volatile', but that's
a change that is much more complex to make.

>  
> @@ -818,7 +819,7 @@ static int gdma_dma_probe(struct platform_device *pdev)
>  	match = of_match_device(gdma_of_match_table, &pdev->dev);
>  	if (!match)
>  		return -EINVAL;
> -	data = (struct gdma_data *) match->data;
> +	data = (struct gdma_data *)match->data;

this one is fine.

Why did you do two different types of thing in the same patch?  Even if
both of them were ok, I would have asked you to split this into two
different patches.

The other 3 patches were fine, just fix this one up and resend it.

thanks,

greg k-h