All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: vt6655: Avoid camelcase
Date: Tue, 5 Mar 2019 15:47:01 +0100	[thread overview]
Message-ID: <20190305144701.GA18638@kroah.com> (raw)
In-Reply-To: <20190305143241.14118-1-jbi.octave@gmail.com>

On Tue, Mar 05, 2019 at 02:32:41PM +0000, Jules Irenge wrote:
> Fix coding style issues detected by checkpatch.pl.
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/vt6655/baseband.c | 522 +++++++++++++++---------------
>  drivers/staging/vt6655/baseband.h |  36 +--
>  2 files changed, 279 insertions(+), 279 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
> index b4cdc0b7fee7..05b15dcd1ea0 100644
> --- a/drivers/staging/vt6655/baseband.c
> +++ b/drivers/staging/vt6655/baseband.c
> @@ -12,20 +12,20 @@
>   * Date: Aug.22, 2002
>   *
>   * Functions:
> - *      BBuGetFrameTime        - Calculate data frame transmitting time
> + *      BBUGETFRAMETIME        - Calculate data frame transmitting time

So to "avoid" camel case, you just made the functions and variable all
upper case?  That's not how we name variables in the kernel, please read
the coding style rules for what these should look like.

thanks,

greg k-h


  reply	other threads:[~2019-03-05 14:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-05 14:32 [PATCH] staging: vt6655: Avoid camelcase Jules Irenge
2019-03-05 14:47 ` Greg KH [this message]
2019-03-05 14:57 ` [Outreachy kernel] " Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190305144701.GA18638@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jbi.octave@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.