From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v2] meson: fix building subdirectories separately Date: Tue, 5 Mar 2019 17:21:12 +0000 Message-ID: <20190305172111.GA103192@bricha3-MOBL.ger.corp.intel.com> References: <1551803365-79357-1-git-send-email-andrius.sirvys@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Andrius Sirvys Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C41DE2BA3 for ; Tue, 5 Mar 2019 18:21:17 +0100 (CET) Content-Disposition: inline In-Reply-To: <1551803365-79357-1-git-send-email-andrius.sirvys@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 05, 2019 at 04:29:25PM +0000, Andrius Sirvys wrote: > If for debugging we disable the driver directory in the meson.build file, > we get an error because the variable "driver_classes" does not exist. > This is because driver_classes is only defined in the > drivers/meson.build file. Defining driver_classes in dpdk/meson.build file > will make it easier for compiling separate directories. > > In the process, we rename driver_classes to dpdk_driver_classes for > consistency with the other variables. > > Signed-off-by: Andrius Sirvys > --- > v2: Fixed mispellings in commit message > --- This can be useful, and a similar change I saw in the windows RFC since it is incrementally adding things to the windows build, and so would hit this error. Therefore, Acked-by: Bruce Richardson