From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH v2 1/4] net/failsafe: replace local device with shared data Date: Tue, 5 Mar 2019 18:40:02 +0100 Message-ID: <20190305174002.b52wokrajmnbbqsh@bidouze.vm.6wind.com> References: <1551779507-10857-1-git-send-email-rasland@mellanox.com> <20190305164326.pu4y4srtnnt7zc7k@bidouze.vm.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: "dev@dpdk.org" , Thomas Monjalon , "stephen@networkplumber.org" To: Raslan Darawsheh Return-path: Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id EE7732C18 for ; Tue, 5 Mar 2019 18:40:04 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id g12so10419261wrm.5 for ; Tue, 05 Mar 2019 09:40:04 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190305164326.pu4y4srtnnt7zc7k@bidouze.vm.6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 05, 2019 at 05:43:26PM +0100, Gaëtan Rivet wrote: > Hello Raslan, > > Sorry for the delay. > > I have had a little trouble reading the patches. I think the 3 first > should be squashed into a single one, it would be more coherent. > > I think I have seen a few points where doing so would have prevented > some unnecessary changes for example, simplifying the series. (thinking > about at least two PORT_ID() and a few ETH() removal that might have > been prevented, I will try to point them all to you.) > > On Tue, Mar 05, 2019 at 09:52:04AM +0000, Raslan Darawsheh wrote: > > In multiprocess context, the private structure is shared between > > processes. The back reference from private to generic data was using > > a pointer to a per process eth_dev. It's now changed to a reference of > > the shared data. > > > > Signed-off-by: Raslan Darawsheh > > Signed-off-by: Thomas Monjalon > > --- > > drivers/net/failsafe/failsafe.c | 2 +- > > drivers/net/failsafe/failsafe_intr.c | 10 +++++----- > > drivers/net/failsafe/failsafe_ops.c | 4 ++-- > > drivers/net/failsafe/failsafe_private.h | 6 +++++- > > drivers/net/failsafe/failsafe_rxtx.c | 4 ++-- > > 5 files changed, 15 insertions(+), 11 deletions(-) > > > > Beside the squashing, this patch seems ok. Okay after reading a little more closely, it does not seem interesting to squash finaly, and it will be simpler for you to continue with your current series, so forget about that. -- Gaëtan Rivet 6WIND