From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeniu Rosca <erosca@de.adit-jv.com>
Date: Tue, 5 Mar 2019 23:28:26 +0100
Subject: [U-Boot] [PATCH] ARM: rmobile: Convert to bootm_size
In-Reply-To: <e3d9214c-26e6-632f-7e22-fa7b1ae01b3c@gmail.com>
References: <97181119-9bd1-8f37-7b1e-0624d077e571@gmail.com>
 <55912eb8-c0a7-9b5f-0dc1-f71a497ae564@gmail.com>
 <93b1f711-86ec-3b12-195f-6e447c1425ad@gmail.com>
 <CAAh8qsw54aMo9KKA2hRMEajzO_MwhJfAq-MUFw6qg56BH2ceqA@mail.gmail.com>
 <20181128013121.GH11247@bill-the-cat>
 <CAAh8qsy374mn3mH0KByRikJq4fCUSJ6sjg9b9VZHcswS5SZnfA@mail.gmail.com>
 <20181128121927.GK11247@bill-the-cat>
 <CAAh8qsyz11KPQj6xJD_G3XC=B7fo4GF=8DYGFshaNFYjAbTf9Q@mail.gmail.com>
 <CAH3KO=13ZfQu4Q1WhW=hnhvs+EO+O1-aLedwJiS43bTQjM9eLg@mail.gmail.com>
 <e3d9214c-26e6-632f-7e22-fa7b1ae01b3c@gmail.com>
Message-ID: <20190305222826.GA28317@vmlxhi-102.adit-jv.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue, Mar 05, 2019 at 07:56:39PM +0100, Marek Vasut wrote:
> On 3/5/19 7:42 PM, Eugeniu Rosca wrote:
> > Hello Marek,
> 
> Hi,
> 
> > May I ask for your opinion on Renesas commits [1-2] especially in
> > light of the `bootm_size` changes done in your patch?
> > The topics look orthogonal to me, but I kindly ask for your confirmation.
> 
> What do you want to know ? With that commit, U-Boot is sitting in the
> middle of your RAM and you're likely to overwrite or corrupt it sooner
> or later, so that patch is not going upstream.

That's already very helpful. Thanks.

> 
> > Also, purely related to the `bootm_size` patch, compiling v2019.04-rc3
> > U-Boot for H3-Salvator-X with the diff [3] applied, I get:
> > 
> > common/image.c: In function 'env_get_bootm_mapsize':
> > common/image.c:520:2: error: #error "Take bootm_size from CONFIG"
> >  #error "Take bootm_size from CONFIG"
> >   ^~~~~
> > 
> > Does this mean the "CONFIG_SYS_BOOTMAPSZ" definition has to be removed
> > from include/configs/rcar-gen3-common.h, to allow the patch to have
> > the desired effect?
> 
> Possibly, if you could study it a bit and if that's the case, send a
> patch, that'd be nice.

Submitted https://patchwork.ozlabs.org/patch/1052012/

> 
> > [1] https://github.com/renesas-rcar/u-boot/commit/86ad30910df818
> > ("arm: rcar_gen3: Add skip of relocation")
> > [2] https://github.com/renesas-rcar/u-boot/commit/91e27e4cc463e ("arm:
> > rcar_gen3: Add skip of relocation")
> > [3] Brutal way to reveal the active bootm_size:
> > diff --git a/common/image.c b/common/image.c
> > index 4d4248f234fb..d65de506060b 100644
> > --- a/common/image.c
> > +++ b/common/image.c
> > @@ -517,8 +517,10 @@ phys_size_t env_get_bootm_mapsize(void)
> >         }
> > 
> >  #if defined(CONFIG_SYS_BOOTMAPSZ)
> > +#error "Take bootm_size from CONFIG"
> >         return CONFIG_SYS_BOOTMAPSZ;
> >  #else
> > +#error "Take bootm_size from env"
> >         return env_get_bootm_size();
> >  #endif
> >  }
> > 
> > Thanks,
> > Eugeniu.
> > 
> 
> 
> -- 
> Best regards,
> Marek Vasut

Best regards,
Eugeniu.