From: Tycho Andersen <tycho@tycho.ws>
To: Christian Brauner <christian.brauner@canonical.com>
Cc: Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 2/2] seccomp: disallow NEW_LISTENER and TSYNC flags
Date: Wed, 6 Mar 2019 13:46:11 -0700 [thread overview]
Message-ID: <20190306204611.GH7413@cisco> (raw)
In-Reply-To: <20190306203932.im7lkblvmd227td3@gmail.com>
On Wed, Mar 06, 2019 at 09:39:35PM +0100, Christian Brauner wrote:
> > +
> > /* Prepare the new filter before holding any locks. */
> > prepared = seccomp_prepare_user_filter(filter);
> > if (IS_ERR(prepared))
> > @@ -1302,7 +1315,7 @@ static long seccomp_set_mode_filter(unsigned int flags,
> > mutex_unlock(¤t->signal->cred_guard_mutex);
> > out_put_fd:
> > if (flags & SECCOMP_FILTER_FLAG_NEW_LISTENER) {
> > - if (ret < 0) {
> > + if (ret) {
>
> Why that change but keep checking if (ret < 0) further up?
Not sure what you mean here. The only other place I see that we check
something is < 0 in that function is the return value of
get_unused_fd_flags(), which looks right to me?
Tycho
next prev parent reply other threads:[~2019-03-06 20:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 20:14 [PATCH 1/2] seccomp: fix up grammar in comment Tycho Andersen
2019-03-06 20:14 ` [PATCH 2/2] seccomp: disallow NEW_LISTENER and TSYNC flags Tycho Andersen
2019-03-06 20:39 ` Christian Brauner
2019-03-06 20:46 ` Tycho Andersen [this message]
2019-03-06 21:02 ` Christian Brauner
2019-03-06 21:30 ` Tycho Andersen
2019-04-23 22:09 ` Kees Cook
2019-04-23 23:18 ` James Morris
2019-04-23 23:31 ` Kees Cook
2019-04-23 23:34 ` Tycho Andersen
2019-04-24 1:02 ` Kees Cook
2019-04-23 22:11 ` [PATCH 1/2] seccomp: fix up grammar in comment Kees Cook
2019-04-23 23:24 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190306204611.GH7413@cisco \
--to=tycho@tycho.ws \
--cc=christian.brauner@canonical.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.