From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 693E9C43381 for ; Wed, 6 Mar 2019 23:24:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34C2920663 for ; Wed, 6 Mar 2019 23:24:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="j1vuJzK/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726328AbfCFXYH (ORCPT ); Wed, 6 Mar 2019 18:24:07 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:46772 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726327AbfCFXYG (ORCPT ); Wed, 6 Mar 2019 18:24:06 -0500 Received: from pendragon.bb.dnainternet.fi (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E47C2BB9; Thu, 7 Mar 2019 00:23:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1551914640; bh=mEbRPEDnIV6tQDWufY3V4fwQVyUoLC8PIQnGeXl8kQ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j1vuJzK/tIUd7zPxsu83GHYZzGD8CpOiJXh/Pri1VpAXAmbxuIftX55Kb/o9+0T/F sWLj8zbvq5wIYISMdFpMOs2A7Q3+vCuqRUxt0+LzrHwuD1wK+YEE7nyIb6TeDbAnCK B8jUNBuxIFrgw2n1moKQNE9a4CGjzN2sB1AScJmM= From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org, Kieran Bingham , Andrzej Hajda , Jacopo Mondi Subject: [PATCH/RFC 06/15] drm: bridge: thc63: Report input bus mode through bridge timings Date: Thu, 7 Mar 2019 01:23:36 +0200 Message-Id: <20190306232345.23052-7-laurent.pinchart+renesas@ideasonboard.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20190306232345.23052-1-laurent.pinchart+renesas@ideasonboard.com> References: <20190306232345.23052-1-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Set a drm_bridge_timings in the drm_bridge, and use it to report the input bus mode (single-link or dual-link). The other fields of the timings structure are kept to 0 as they do not apply to LVDS buses. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/bridge/thc63lvd1024.c | 46 ++++++++++++++++++++------- 1 file changed, 35 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c b/drivers/gpu/drm/bridge/thc63lvd1024.c index b083a740565c..206b0af5e154 100644 --- a/drivers/gpu/drm/bridge/thc63lvd1024.c +++ b/drivers/gpu/drm/bridge/thc63lvd1024.c @@ -31,6 +31,8 @@ struct thc63_dev { struct drm_bridge bridge; struct drm_bridge *next; + + struct drm_bridge_timings timings; }; static inline struct thc63_dev *to_thc63(struct drm_bridge *bridge) @@ -48,15 +50,28 @@ static int thc63_attach(struct drm_bridge *bridge) static enum drm_mode_status thc63_mode_valid(struct drm_bridge *bridge, const struct drm_display_mode *mode) { + struct thc63_dev *thc63 = to_thc63(bridge); + unsigned int min_freq; + unsigned int max_freq; + /* - * The THC63LVD1024 clock frequency range is 8 to 135 MHz in single-in - * mode. Note that the limits are different in dual-in, single-out mode, - * and will need to be adjusted accordingly. + * The THC63LVD1024 pixel rate range is 8 to 135 MHz in all modes but + * dual-in, single-out where it is 40 to 150 MHz. As dual-in, dual-out + * isn't supported by the driver yet, simply derive the limits from the + * input mode. */ - if (mode->clock < 8000) + if (thc63->timings.dual_link) { + min_freq = 40000; + max_freq = 150000; + } else { + min_freq = 8000; + max_freq = 135000; + } + + if (mode->clock < min_freq) return MODE_CLOCK_LOW; - if (mode->clock > 135000) + if (mode->clock > max_freq) return MODE_CLOCK_HIGH; return MODE_OK; @@ -101,19 +116,19 @@ static const struct drm_bridge_funcs thc63_bridge_func = { static int thc63_parse_dt(struct thc63_dev *thc63) { - struct device_node *thc63_out; + struct device_node *endpoint; struct device_node *remote; - thc63_out = of_graph_get_endpoint_by_regs(thc63->dev->of_node, - THC63_RGB_OUT0, -1); - if (!thc63_out) { + endpoint = of_graph_get_endpoint_by_regs(thc63->dev->of_node, + THC63_RGB_OUT0, -1); + if (!endpoint) { dev_err(thc63->dev, "Missing endpoint in port@%u\n", THC63_RGB_OUT0); return -ENODEV; } - remote = of_graph_get_remote_port_parent(thc63_out); - of_node_put(thc63_out); + remote = of_graph_get_remote_port_parent(endpoint); + of_node_put(endpoint); if (!remote) { dev_err(thc63->dev, "Endpoint in port@%u unconnected\n", THC63_RGB_OUT0); @@ -132,6 +147,14 @@ static int thc63_parse_dt(struct thc63_dev *thc63) if (!thc63->next) return -EPROBE_DEFER; + endpoint = of_graph_get_endpoint_by_regs(thc63->dev->of_node, + THC63_LVDS_IN1, -1); + of_node_put(endpoint); + + thc63->timings.dual_link = endpoint != NULL; + dev_dbg(thc63->dev, "operating in %s-link mode\n", + thc63->timings.dual_link ? "dual" : "single"); + return 0; } @@ -188,6 +211,7 @@ static int thc63_probe(struct platform_device *pdev) thc63->bridge.driver_private = thc63; thc63->bridge.of_node = pdev->dev.of_node; thc63->bridge.funcs = &thc63_bridge_func; + thc63->bridge.timings = &thc63->timings; drm_bridge_add(&thc63->bridge); -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: [PATCH/RFC 06/15] drm: bridge: thc63: Report input bus mode through bridge timings Date: Thu, 7 Mar 2019 01:23:36 +0200 Message-ID: <20190306232345.23052-7-laurent.pinchart+renesas@ideasonboard.com> References: <20190306232345.23052-1-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 14B276E1FB for ; Wed, 6 Mar 2019 23:24:05 +0000 (UTC) In-Reply-To: <20190306232345.23052-1-laurent.pinchart+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org, Jacopo Mondi , Kieran Bingham List-Id: dri-devel@lists.freedesktop.org U2V0IGEgZHJtX2JyaWRnZV90aW1pbmdzIGluIHRoZSBkcm1fYnJpZGdlLCBhbmQgdXNlIGl0IHRv IHJlcG9ydCB0aGUKaW5wdXQgYnVzIG1vZGUgKHNpbmdsZS1saW5rIG9yIGR1YWwtbGluaykuIFRo ZSBvdGhlciBmaWVsZHMgb2YgdGhlCnRpbWluZ3Mgc3RydWN0dXJlIGFyZSBrZXB0IHRvIDAgYXMg dGhleSBkbyBub3QgYXBwbHkgdG8gTFZEUyBidXNlcy4KClNpZ25lZC1vZmYtYnk6IExhdXJlbnQg UGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnQrcmVuZXNhc0BpZGVhc29uYm9hcmQuY29tPgotLS0K IGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvdGhjNjNsdmQxMDI0LmMgfCA0NiArKysrKysrKysrKysr KysrKysrKy0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspLCAxMSBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3RoYzYzbHZkMTAy NC5jIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS90aGM2M2x2ZDEwMjQuYwppbmRleCBiMDgzYTc0 MDU2NWMuLjIwNmIwYWY1ZTE1NCAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS90 aGM2M2x2ZDEwMjQuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3RoYzYzbHZkMTAyNC5j CkBAIC0zMSw2ICszMSw4IEBAIHN0cnVjdCB0aGM2M19kZXYgewogCiAJc3RydWN0IGRybV9icmlk Z2UgYnJpZGdlOwogCXN0cnVjdCBkcm1fYnJpZGdlICpuZXh0OworCisJc3RydWN0IGRybV9icmlk Z2VfdGltaW5ncyB0aW1pbmdzOwogfTsKIAogc3RhdGljIGlubGluZSBzdHJ1Y3QgdGhjNjNfZGV2 ICp0b190aGM2MyhzdHJ1Y3QgZHJtX2JyaWRnZSAqYnJpZGdlKQpAQCAtNDgsMTUgKzUwLDI4IEBA IHN0YXRpYyBpbnQgdGhjNjNfYXR0YWNoKHN0cnVjdCBkcm1fYnJpZGdlICpicmlkZ2UpCiBzdGF0 aWMgZW51bSBkcm1fbW9kZV9zdGF0dXMgdGhjNjNfbW9kZV92YWxpZChzdHJ1Y3QgZHJtX2JyaWRn ZSAqYnJpZGdlLAogCQkJCQljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSkKIHsK KwlzdHJ1Y3QgdGhjNjNfZGV2ICp0aGM2MyA9IHRvX3RoYzYzKGJyaWRnZSk7CisJdW5zaWduZWQg aW50IG1pbl9mcmVxOworCXVuc2lnbmVkIGludCBtYXhfZnJlcTsKKwogCS8qCi0JICogVGhlIFRI QzYzTFZEMTAyNCBjbG9jayBmcmVxdWVuY3kgcmFuZ2UgaXMgOCB0byAxMzUgTUh6IGluIHNpbmds ZS1pbgotCSAqIG1vZGUuIE5vdGUgdGhhdCB0aGUgbGltaXRzIGFyZSBkaWZmZXJlbnQgaW4gZHVh bC1pbiwgc2luZ2xlLW91dCBtb2RlLAotCSAqIGFuZCB3aWxsIG5lZWQgdG8gYmUgYWRqdXN0ZWQg YWNjb3JkaW5nbHkuCisJICogVGhlIFRIQzYzTFZEMTAyNCBwaXhlbCByYXRlIHJhbmdlIGlzIDgg dG8gMTM1IE1IeiBpbiBhbGwgbW9kZXMgYnV0CisJICogZHVhbC1pbiwgc2luZ2xlLW91dCB3aGVy ZSBpdCBpcyA0MCB0byAxNTAgTUh6LiBBcyBkdWFsLWluLCBkdWFsLW91dAorCSAqIGlzbid0IHN1 cHBvcnRlZCBieSB0aGUgZHJpdmVyIHlldCwgc2ltcGx5IGRlcml2ZSB0aGUgbGltaXRzIGZyb20g dGhlCisJICogaW5wdXQgbW9kZS4KIAkgKi8KLQlpZiAobW9kZS0+Y2xvY2sgPCA4MDAwKQorCWlm ICh0aGM2My0+dGltaW5ncy5kdWFsX2xpbmspIHsKKwkJbWluX2ZyZXEgPSA0MDAwMDsKKwkJbWF4 X2ZyZXEgPSAxNTAwMDA7CisJfSBlbHNlIHsKKwkJbWluX2ZyZXEgPSA4MDAwOworCQltYXhfZnJl cSA9IDEzNTAwMDsKKwl9CisKKwlpZiAobW9kZS0+Y2xvY2sgPCBtaW5fZnJlcSkKIAkJcmV0dXJu IE1PREVfQ0xPQ0tfTE9XOwogCi0JaWYgKG1vZGUtPmNsb2NrID4gMTM1MDAwKQorCWlmIChtb2Rl LT5jbG9jayA+IG1heF9mcmVxKQogCQlyZXR1cm4gTU9ERV9DTE9DS19ISUdIOwogCiAJcmV0dXJu IE1PREVfT0s7CkBAIC0xMDEsMTkgKzExNiwxOSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9i cmlkZ2VfZnVuY3MgdGhjNjNfYnJpZGdlX2Z1bmMgPSB7CiAKIHN0YXRpYyBpbnQgdGhjNjNfcGFy c2VfZHQoc3RydWN0IHRoYzYzX2RldiAqdGhjNjMpCiB7Ci0Jc3RydWN0IGRldmljZV9ub2RlICp0 aGM2M19vdXQ7CisJc3RydWN0IGRldmljZV9ub2RlICplbmRwb2ludDsKIAlzdHJ1Y3QgZGV2aWNl X25vZGUgKnJlbW90ZTsKIAotCXRoYzYzX291dCA9IG9mX2dyYXBoX2dldF9lbmRwb2ludF9ieV9y ZWdzKHRoYzYzLT5kZXYtPm9mX25vZGUsCi0JCQkJCQkgIFRIQzYzX1JHQl9PVVQwLCAtMSk7Ci0J aWYgKCF0aGM2M19vdXQpIHsKKwllbmRwb2ludCA9IG9mX2dyYXBoX2dldF9lbmRwb2ludF9ieV9y ZWdzKHRoYzYzLT5kZXYtPm9mX25vZGUsCisJCQkJCQkgVEhDNjNfUkdCX09VVDAsIC0xKTsKKwlp ZiAoIWVuZHBvaW50KSB7CiAJCWRldl9lcnIodGhjNjMtPmRldiwgIk1pc3NpbmcgZW5kcG9pbnQg aW4gcG9ydEAldVxuIiwKIAkJCVRIQzYzX1JHQl9PVVQwKTsKIAkJcmV0dXJuIC1FTk9ERVY7CiAJ fQogCi0JcmVtb3RlID0gb2ZfZ3JhcGhfZ2V0X3JlbW90ZV9wb3J0X3BhcmVudCh0aGM2M19vdXQp OwotCW9mX25vZGVfcHV0KHRoYzYzX291dCk7CisJcmVtb3RlID0gb2ZfZ3JhcGhfZ2V0X3JlbW90 ZV9wb3J0X3BhcmVudChlbmRwb2ludCk7CisJb2Zfbm9kZV9wdXQoZW5kcG9pbnQpOwogCWlmICgh cmVtb3RlKSB7CiAJCWRldl9lcnIodGhjNjMtPmRldiwgIkVuZHBvaW50IGluIHBvcnRAJXUgdW5j b25uZWN0ZWRcbiIsCiAJCQlUSEM2M19SR0JfT1VUMCk7CkBAIC0xMzIsNiArMTQ3LDE0IEBAIHN0 YXRpYyBpbnQgdGhjNjNfcGFyc2VfZHQoc3RydWN0IHRoYzYzX2RldiAqdGhjNjMpCiAJaWYgKCF0 aGM2My0+bmV4dCkKIAkJcmV0dXJuIC1FUFJPQkVfREVGRVI7CiAKKwllbmRwb2ludCA9IG9mX2dy YXBoX2dldF9lbmRwb2ludF9ieV9yZWdzKHRoYzYzLT5kZXYtPm9mX25vZGUsCisJCQkJCQkgVEhD NjNfTFZEU19JTjEsIC0xKTsKKwlvZl9ub2RlX3B1dChlbmRwb2ludCk7CisKKwl0aGM2My0+dGlt aW5ncy5kdWFsX2xpbmsgPSBlbmRwb2ludCAhPSBOVUxMOworCWRldl9kYmcodGhjNjMtPmRldiwg Im9wZXJhdGluZyBpbiAlcy1saW5rIG1vZGVcbiIsCisJCXRoYzYzLT50aW1pbmdzLmR1YWxfbGlu ayA/ICJkdWFsIiA6ICJzaW5nbGUiKTsKKwogCXJldHVybiAwOwogfQogCkBAIC0xODgsNiArMjEx LDcgQEAgc3RhdGljIGludCB0aGM2M19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2 KQogCXRoYzYzLT5icmlkZ2UuZHJpdmVyX3ByaXZhdGUgPSB0aGM2MzsKIAl0aGM2My0+YnJpZGdl Lm9mX25vZGUgPSBwZGV2LT5kZXYub2Zfbm9kZTsKIAl0aGM2My0+YnJpZGdlLmZ1bmNzID0gJnRo YzYzX2JyaWRnZV9mdW5jOworCXRoYzYzLT5icmlkZ2UudGltaW5ncyA9ICZ0aGM2My0+dGltaW5n czsKIAogCWRybV9icmlkZ2VfYWRkKCZ0aGM2My0+YnJpZGdlKTsKIAotLSAKUmVnYXJkcywKCkxh dXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbA==