From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1CFEC10F03 for ; Thu, 7 Mar 2019 08:35:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7CFBB20652 for ; Thu, 7 Mar 2019 08:35:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726249AbfCGIfW (ORCPT ); Thu, 7 Mar 2019 03:35:22 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:55570 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726028AbfCGIfV (ORCPT ); Thu, 7 Mar 2019 03:35:21 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 76299804A1; Thu, 7 Mar 2019 09:35:12 +0100 (CET) Date: Thu, 7 Mar 2019 09:35:18 +0100 From: Pavel Machek To: Lee Jones Cc: Paul Gortmaker , linux-kernel@vger.kernel.org, Alessandro Rubini , Arnd Bergmann , Charles Keepax , Cory Maccarrone , Davide Ciminaghi , Dong Aisheng , Graeme Gregory , Guennadi Liakhovetski , Haojian Zhuang , Jin Park , Jorge Eduardo Candelaria , Laxman Dewangan , Linus Walleij , Mark Brown , Mattias Nilsson , Michael Hennerich , Tony Lindgren , Venu Byravarasu , linux-omap@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH v5 00/18] mfd: demodularization of non-modular drivers Message-ID: <20190307083518.GA8052@amd> References: <1547404609-14161-1-git-send-email-paul.gortmaker@windriver.com> <20190116132431.GE23399@dell> <20190306231003.GD7915@amd> <20190307041808.GK26690@windriver.com> <20190307082524.GB4634@dell> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="M9NhX3UHpAaciwkO" Content-Disposition: inline In-Reply-To: <20190307082524.GB4634@dell> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --M9NhX3UHpAaciwkO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > Pavel, I hope this more extended explanation makes sense to you, and > > that you simply have not seen me write these same details in the past. >=20 > Blimey. That's a really long winded way of saying: >=20 > "Modular-ness is actually broken in these drivers; [Paul]'s patches > make that point clear for all to see. If people (authors/distros) > wish them to be modular, they need to fix them properly." Has that been checked? I mean... when I saw the patch I thought "perhaps it should be doing bool->tristate instead"? Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --M9NhX3UHpAaciwkO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlyA18YACgkQMOfwapXb+vLAxgCgjWvBc8EJQsh4mCq7bC/TE0MP NMcAnj2AFRWY1cOOafm4t7W7JJ/IunmV =V5hv -----END PGP SIGNATURE----- --M9NhX3UHpAaciwkO-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH v5 00/18] mfd: demodularization of non-modular drivers Date: Thu, 7 Mar 2019 09:35:18 +0100 Message-ID: <20190307083518.GA8052@amd> References: <1547404609-14161-1-git-send-email-paul.gortmaker@windriver.com> <20190116132431.GE23399@dell> <20190306231003.GD7915@amd> <20190307041808.GK26690@windriver.com> <20190307082524.GB4634@dell> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="M9NhX3UHpAaciwkO" Return-path: Content-Disposition: inline In-Reply-To: <20190307082524.GB4634@dell> Sender: linux-kernel-owner@vger.kernel.org To: Lee Jones Cc: Paul Gortmaker , linux-kernel@vger.kernel.org, Alessandro Rubini , Arnd Bergmann , Charles Keepax , Cory Maccarrone , Davide Ciminaghi , Dong Aisheng , Graeme Gregory , Guennadi Liakhovetski , Haojian Zhuang , Jin Park , Jorge Eduardo Candelaria , Laxman Dewangan , Linus Walleij , Mark Brown , Mattias Nilsson , Michael Hennerich List-Id: linux-omap@vger.kernel.org --M9NhX3UHpAaciwkO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > Pavel, I hope this more extended explanation makes sense to you, and > > that you simply have not seen me write these same details in the past. >=20 > Blimey. That's a really long winded way of saying: >=20 > "Modular-ness is actually broken in these drivers; [Paul]'s patches > make that point clear for all to see. If people (authors/distros) > wish them to be modular, they need to fix them properly." Has that been checked? I mean... when I saw the patch I thought "perhaps it should be doing bool->tristate instead"? Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --M9NhX3UHpAaciwkO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlyA18YACgkQMOfwapXb+vLAxgCgjWvBc8EJQsh4mCq7bC/TE0MP NMcAnj2AFRWY1cOOafm4t7W7JJ/IunmV =V5hv -----END PGP SIGNATURE----- --M9NhX3UHpAaciwkO--