All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-oe][PATCH] asio: add PACKAGECONFIG boost
@ 2019-03-07  8:29 Sean Nyekjaer
  2019-03-07  8:53 ` Adrian Bunk
  0 siblings, 1 reply; 4+ messages in thread
From: Sean Nyekjaer @ 2019-03-07  8:29 UTC (permalink / raw)
  To: openembedded-devel, raj.khem

Signed-off-by: Sean Nyekjaer <sean@geanix.com>
---
 meta-oe/recipes-support/asio/asio_1.12.2.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta-oe/recipes-support/asio/asio_1.12.2.bb b/meta-oe/recipes-support/asio/asio_1.12.2.bb
index ee548fd3a..ec705c275 100644
--- a/meta-oe/recipes-support/asio/asio_1.12.2.bb
+++ b/meta-oe/recipes-support/asio/asio_1.12.2.bb
@@ -20,3 +20,7 @@ SRC_URI[md5sum] = "312e53385e2daad10f08d57f91ad3431"
 SRC_URI[sha256sum] = "4e27dcb37456ba707570334b91f4798721111ed67b69915685eac141895779aa"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/asio/${BP}.tar.bz2"
+
+PACKAGECONFIG ??= "boost"
+
+PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost,boost"
-- 
2.21.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [meta-oe][PATCH] asio: add PACKAGECONFIG boost
  2019-03-07  8:29 [meta-oe][PATCH] asio: add PACKAGECONFIG boost Sean Nyekjaer
@ 2019-03-07  8:53 ` Adrian Bunk
  2019-03-07  9:03   ` Sean Nyekjaer
  0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2019-03-07  8:53 UTC (permalink / raw)
  To: Sean Nyekjaer; +Cc: openembedded-devel

On Thu, Mar 07, 2019 at 09:29:17AM +0100, Sean Nyekjaer wrote:
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> ---
>  meta-oe/recipes-support/asio/asio_1.12.2.bb | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta-oe/recipes-support/asio/asio_1.12.2.bb b/meta-oe/recipes-support/asio/asio_1.12.2.bb
> index ee548fd3a..ec705c275 100644
> --- a/meta-oe/recipes-support/asio/asio_1.12.2.bb
> +++ b/meta-oe/recipes-support/asio/asio_1.12.2.bb
> @@ -20,3 +20,7 @@ SRC_URI[md5sum] = "312e53385e2daad10f08d57f91ad3431"
>  SRC_URI[sha256sum] = "4e27dcb37456ba707570334b91f4798721111ed67b69915685eac141895779aa"
>  
>  SRC_URI = "${SOURCEFORGE_MIRROR}/asio/${BP}.tar.bz2"
> +
> +PACKAGECONFIG ??= "boost"
> +
> +PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost,boost"

Adding an RDEPENDS in the PACKAGECONFIG looks wrong.
boost should also be removed from the DEPENDS above when it is disabled.

This would be on top of your patch:
-DEPENDS = "boost openssl"
+DEPENDS = "openssl"
-PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost,boost"
+PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost"

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [meta-oe][PATCH] asio: add PACKAGECONFIG boost
  2019-03-07  8:53 ` Adrian Bunk
@ 2019-03-07  9:03   ` Sean Nyekjaer
  2019-03-07 10:00     ` Adrian Bunk
  0 siblings, 1 reply; 4+ messages in thread
From: Sean Nyekjaer @ 2019-03-07  9:03 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: openembedded-devel



On 07/03/2019 09.53, Adrian Bunk wrote:
> On Thu, Mar 07, 2019 at 09:29:17AM +0100, Sean Nyekjaer wrote:
>> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
>> ---
>>   meta-oe/recipes-support/asio/asio_1.12.2.bb | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/meta-oe/recipes-support/asio/asio_1.12.2.bb b/meta-oe/recipes-support/asio/asio_1.12.2.bb
>> index ee548fd3a..ec705c275 100644
>> --- a/meta-oe/recipes-support/asio/asio_1.12.2.bb
>> +++ b/meta-oe/recipes-support/asio/asio_1.12.2.bb
>> @@ -20,3 +20,7 @@ SRC_URI[md5sum] = "312e53385e2daad10f08d57f91ad3431"
>>   SRC_URI[sha256sum] = "4e27dcb37456ba707570334b91f4798721111ed67b69915685eac141895779aa"
>>   
>>   SRC_URI = "${SOURCEFORGE_MIRROR}/asio/${BP}.tar.bz2"
>> +
>> +PACKAGECONFIG ??= "boost"
>> +
>> +PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost,boost"
> 
> Adding an RDEPENDS in the PACKAGECONFIG looks wrong.
> boost should also be removed from the DEPENDS above when it is disabled.
> 
> This would be on top of your patch:
> -DEPENDS = "boost openssl"
> +DEPENDS = "openssl"
> -PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost,boost"
> +PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost"
> 
> cu
> Adrian
> 
Hi Adrian,

I missed the DEPENDS, thanks :-)
But why does the extra RDEPENDS looks wrong?

I'll send a PATCHv2

/Sean


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [meta-oe][PATCH] asio: add PACKAGECONFIG boost
  2019-03-07  9:03   ` Sean Nyekjaer
@ 2019-03-07 10:00     ` Adrian Bunk
  0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2019-03-07 10:00 UTC (permalink / raw)
  To: Sean Nyekjaer; +Cc: openembedded-devel

On Thu, Mar 07, 2019 at 10:03:08AM +0100, Sean Nyekjaer wrote:
> 
> 
> On 07/03/2019 09.53, Adrian Bunk wrote:
> > On Thu, Mar 07, 2019 at 09:29:17AM +0100, Sean Nyekjaer wrote:
> > > Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> > > ---
> > >   meta-oe/recipes-support/asio/asio_1.12.2.bb | 4 ++++
> > >   1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/meta-oe/recipes-support/asio/asio_1.12.2.bb b/meta-oe/recipes-support/asio/asio_1.12.2.bb
> > > index ee548fd3a..ec705c275 100644
> > > --- a/meta-oe/recipes-support/asio/asio_1.12.2.bb
> > > +++ b/meta-oe/recipes-support/asio/asio_1.12.2.bb
> > > @@ -20,3 +20,7 @@ SRC_URI[md5sum] = "312e53385e2daad10f08d57f91ad3431"
> > >   SRC_URI[sha256sum] = "4e27dcb37456ba707570334b91f4798721111ed67b69915685eac141895779aa"
> > >   SRC_URI = "${SOURCEFORGE_MIRROR}/asio/${BP}.tar.bz2"
> > > +
> > > +PACKAGECONFIG ??= "boost"
> > > +
> > > +PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost,boost"
> > 
> > Adding an RDEPENDS in the PACKAGECONFIG looks wrong.
> > boost should also be removed from the DEPENDS above when it is disabled.
> > 
> > This would be on top of your patch:
> > -DEPENDS = "boost openssl"
> > +DEPENDS = "openssl"
> > -PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost,boost"
> > +PACKAGECONFIG[boost] = "--with-boost,--without-boost,boost"
> > 
> > 
> Hi Adrian,
> 
> I missed the DEPENDS, thanks :-)
> But why does the extra RDEPENDS looks wrong?

It forces all boost libraries to be installed on the target,
no matter whether or not they are used.

> I'll send a PATCHv2
> 
> /Sean

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-03-07 10:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-07  8:29 [meta-oe][PATCH] asio: add PACKAGECONFIG boost Sean Nyekjaer
2019-03-07  8:53 ` Adrian Bunk
2019-03-07  9:03   ` Sean Nyekjaer
2019-03-07 10:00     ` Adrian Bunk

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.