From: Laurent Vivier <laurent@vivier.eu>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>,
Riku Voipio <riku.voipio@iki.fi>,
Sandra Loosemore <sandra@codesourcery.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PULL 5/9] Fix breakpoint support in Nios II user-mode emulation.
Date: Thu, 7 Mar 2019 11:06:52 +0100 [thread overview]
Message-ID: <20190307100656.14044-6-laurent@vivier.eu> (raw)
In-Reply-To: <20190307100656.14044-1-laurent@vivier.eu>
From: Sandra Loosemore <sandra@codesourcery.com>
Nios II user-mode emulation was missing handling for EXCP_DEBUG,
making the gdb stub essentially useless. This patch adds the missing
piece. The new code was copied from the existing EXCP_TRAP handling
and is also similar to what other targets (e.g., arm) do with EXCP_DEBUG.
Signed-off-by: Sandra Loosemore <sandra@codesourcery.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <1550076626-7202-1-git-send-email-sandra@codesourcery.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
linux-user/nios2/cpu_loop.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c
index b96b1aa1195a..5aa1eca740de 100644
--- a/linux-user/nios2/cpu_loop.c
+++ b/linux-user/nios2/cpu_loop.c
@@ -73,6 +73,12 @@ void cpu_loop(CPUNios2State *env)
queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
break;
}
+ case EXCP_DEBUG:
+ info.si_signo = TARGET_SIGTRAP;
+ info.si_errno = 0;
+ info.si_code = TARGET_TRAP_BRKPT;
+ queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
+ break;
case 0xaa:
switch (env->regs[R_PC]) {
/*case 0x1000:*/ /* TODO:__kuser_helper_version */
--
2.20.1
next prev parent reply other threads:[~2019-03-07 10:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 10:06 [Qemu-devel] [PULL 0/9] Linux user for 4.0 patches Laurent Vivier
2019-03-07 10:06 ` [Qemu-devel] [PULL 1/9] linux-user: fix recvmsg emulation Laurent Vivier
2019-03-07 10:06 ` [Qemu-devel] [PULL 2/9] linux-user: Add ELF_PLATFORM for arm Laurent Vivier
2019-03-07 10:06 ` [Qemu-devel] [PULL 3/9] linux-user: Fix ELF_PLATFORM for aarch64_be-linux-user Laurent Vivier
2019-03-07 10:06 ` [Qemu-devel] [PULL 4/9] linux-user: fix emulation of accept4/getpeername/getsockname/recvfrom syscalls Laurent Vivier
2019-03-07 10:06 ` Laurent Vivier [this message]
2019-03-07 10:06 ` [Qemu-devel] [PULL 6/9] linux-user: don't short-circuit read with zero length Laurent Vivier
2019-03-07 10:06 ` [Qemu-devel] [PULL 7/9] linux-user: fix "may be used uninitialized" warnings Laurent Vivier
2019-03-07 10:06 ` [Qemu-devel] [PULL 8/9] linux-user: Nicer strace output of chroot() syscall Laurent Vivier
2019-03-07 10:06 ` [Qemu-devel] [PULL 9/9] linux-user: add new netlink types Laurent Vivier
2019-03-08 11:04 ` [Qemu-devel] [PULL 0/9] Linux user for 4.0 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307100656.14044-6-laurent@vivier.eu \
--to=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.