From: Nathan Chancellor <natechancellor@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-omap@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] davinci_emac: always build in CONFIG_OF code
Date: Thu, 7 Mar 2019 08:16:58 -0700 [thread overview]
Message-ID: <20190307151658.GB20201@archlinux-ryzen> (raw)
In-Reply-To: <20190307093135.3354493-1-arnd@arndb.de>
On Thu, Mar 07, 2019 at 10:31:20AM +0100, Arnd Bergmann wrote:
> clang warns about what seems to be an unintended use of an obscure C
> language feature where a forward declaration of an array remains usable
> when the final definition is never seen:
>
> drivers/net/ethernet/ti/davinci_emac.c:1694:34: error: tentative array definition assumed to have one element [-Werror]
> static const struct of_device_id davinci_emac_of_match[];
>
> There is no harm in always enabling the device tree matching code here,
> and it makes the code behave in a more conventional way aside from
> avoiding the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/net/ethernet/ti/davinci_emac.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
> index 840820402cd0..57450b174fc4 100644
> --- a/drivers/net/ethernet/ti/davinci_emac.c
> +++ b/drivers/net/ethernet/ti/davinci_emac.c
> @@ -2029,7 +2029,6 @@ static const struct dev_pm_ops davinci_emac_pm_ops = {
> .resume = davinci_emac_resume,
> };
>
> -#if IS_ENABLED(CONFIG_OF)
> static const struct emac_platform_data am3517_emac_data = {
> .version = EMAC_VERSION_2,
> .hw_ram_addr = 0x01e20000,
> @@ -2046,14 +2045,13 @@ static const struct of_device_id davinci_emac_of_match[] = {
> {},
> };
> MODULE_DEVICE_TABLE(of, davinci_emac_of_match);
> -#endif
>
> /* davinci_emac_driver: EMAC platform driver structure */
> static struct platform_driver davinci_emac_driver = {
> .driver = {
> .name = "davinci_emac",
> .pm = &davinci_emac_pm_ops,
> - .of_match_table = of_match_ptr(davinci_emac_of_match),
> + .of_match_table = davinci_emac_of_match,
> },
> .probe = davinci_emac_probe,
> .remove = davinci_emac_remove,
> --
> 2.20.0
>
next prev parent reply other threads:[~2019-03-07 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 9:31 [PATCH] davinci_emac: always build in CONFIG_OF code Arnd Bergmann
2019-03-07 15:16 ` Nathan Chancellor [this message]
2019-03-07 17:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307151658.GB20201@archlinux-ryzen \
--to=natechancellor@gmail.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.