From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: kernel-team@fb.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: remove WARN_ON() in log_dir_items
Date: Thu, 7 Mar 2019 17:04:53 +0100 [thread overview]
Message-ID: <20190307160452.GI31119@twin.jikos.cz> (raw)
In-Reply-To: <20190306221304.29503-1-josef@toxicpanda.com>
On Wed, Mar 06, 2019 at 05:13:04PM -0500, Josef Bacik wrote:
> When Filipe added the recursive directory logging stuff he specifically
> didn't take the directory i_mutex for the children directories that we
> need to log because of lockdep. This is generally fine, but can lead to
> this WARN_ON() tripping if we happen to run delayed deletion's in
> between our first search and our second search of dir_item/dir_indexes
> for this directory. We expect this to happen, so the WARN_ON() isn't
> necessary. Drop the WARN_ON() and add a comment so we know why this
> case can happen.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Added to misc-next, thanks.
prev parent reply other threads:[~2019-03-07 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 22:13 [PATCH] btrfs: remove WARN_ON() in log_dir_items Josef Bacik
2019-03-07 10:21 ` Filipe Manana
2019-03-07 16:04 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307160452.GI31119@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.