From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A3EFC43381 for ; Thu, 7 Mar 2019 16:51:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 613D620840 for ; Thu, 7 Mar 2019 16:51:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbfCGQvZ (ORCPT ); Thu, 7 Mar 2019 11:51:25 -0500 Received: from mga14.intel.com ([192.55.52.115]:45735 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbfCGQvY (ORCPT ); Thu, 7 Mar 2019 11:51:24 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2019 08:51:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,451,1544515200"; d="scan'208";a="325140064" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.137]) by fmsmga006.fm.intel.com with ESMTP; 07 Mar 2019 08:51:24 -0800 Received: by tassilo.localdomain (Postfix, from userid 1000) id C924E3013CC; Thu, 7 Mar 2019 08:51:23 -0800 (PST) Date: Thu, 7 Mar 2019 08:51:23 -0800 From: Andi Kleen To: Jiri Olsa Cc: Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Ingo Molnar , Namhyung Kim , Alexander Shishkin , Peter Zijlstra , Jonas Rabenstein , Nageswara R Sastry , Ravi Bangoria Subject: Re: [PATCHv2 5/8] perf tools: Get precise_ip from the pmu config Message-ID: <20190307165123.GE7535@tassilo.jf.intel.com> References: <20190305152536.21035-1-jolsa@kernel.org> <20190305152536.21035-6-jolsa@kernel.org> <20190305161319.GC17272@tassilo.jf.intel.com> <20190305162854.GB4533@krava> <20190305164017.GD17272@tassilo.jf.intel.com> <20190307153500.GC29474@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190307153500.GC29474@krava> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 07, 2019 at 04:35:00PM +0100, Jiri Olsa wrote: > On Tue, Mar 05, 2019 at 08:40:17AM -0800, Andi Kleen wrote: > > On Tue, Mar 05, 2019 at 05:28:54PM +0100, Jiri Olsa wrote: > > > On Tue, Mar 05, 2019 at 08:13:19AM -0800, Andi Kleen wrote: > > > > On Tue, Mar 05, 2019 at 04:25:33PM +0100, Jiri Olsa wrote: > > > > > Getting precise_ip field from the perf_pmu::max_precise > > > > > config read from sysfs. If it's not available falling > > > > > back to current detection function. > > > > > > > > max_precise depends on the event. This won't work for all > > > > events. For example only instructions and cycles support > > > > ppp > > > > > > I'm getting precise_ip=3 on mem-* events as well, that's why I > > > was fixing this.. now it's not working for any event > > > > I don't think it means anything for mem-* > > > > There's some support for it on Goldmont plus for other events, > > but it doesn't support mem-*. On big core it's only > > for instructions and cycles, all implemented with the same > > event. All other PEBS events only have two levels > > switching between the two IPs. > > ok, so how about this, it's the change I posted merged with the patch Still seems like a hack. Even though I don't know of a case that would break now. But it would be better to have the precise probing in the open retry loop, instead of trying to reinvent it here. -Andi