From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH] drm/i915/icl: Prevent incorrect DBuf enabling Date: Thu, 7 Mar 2019 09:59:39 -0800 Message-ID: <20190307175939.GG30283@intel.com> References: <20190307103235.23538-1-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 731216E200 for ; Thu, 7 Mar 2019 17:59:29 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190307103235.23538-1-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXIgMDcsIDIwMTkgYXQgMTI6MzI6MzVQTSArMDIwMCwgSW1yZSBEZWFrIHdyb3Rl Ogo+IFByZXRlbmQgdGhhdCB3ZSBoYXZlIG9ubHkgMSBEQnVmIHNsaWNlIGFuZCB0aGF0IDEgc2xp Y2UgaXMgYWx3YXlzCj4gZW5hYmxlZCwgdW50aWwgd2UgaGF2ZSBhIHByb3BlciB3YXkgZm9yIG9u LWRlbWFuZCB0b2dnbGluZyBvZiB0aGUgc2Vjb25kCj4gc2xpY2UuICBDdXJyZW50bHkgd2UnbGwg dHJ5IHRvIGluY29ycmVjdGx5IGVuYWJsZSBEQnVmIGV2ZW4gd2hlbiBhbGwKPiBwaXBlcyBhcmUg ZGlzYWJsZWQgYW5kIHdlIGFyZSBhbHJlYWR5IHJ1bnRpbWUgc3VzcGVuZGVkIChhcyB0aGUgY29t cHV0ZWQKPiBudW1iZXIgb2YgREJ1ZiBzbGljZXMgd2lsbCBiZSAxIGluIHRoYXQgY2FzZSkuCj4g Cj4gVGhpcyBhbHNvIG1lYW5zIHdlJ2xsIGxlYXZlIHRoZSBzZWNvbmQgc2xpY2UgZW5hYmxlZCBy ZWR1bmRhbnRseSAoZXhjZXB0Cj4gd2hlbiBzdXNwZW5kZWQpLCBidXQgdGhhdCdzIGFuIGFjY2Vw dGFibGUgdHJhZGVvZmYgdW50aWwgd2UgaGF2ZSBhCj4gcHJvcGVyIHNvbHV0aW9uLgoKcmVkdW5k YW50IGlzIHRoZSB3b3JkIG9mIHRoZSB3ZWVrIDopCgo+IAo+IEJ1Z3ppbGxhOiBodHRwczovL2J1 Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDg3NTYKPiBDYzogVmlsbGUgU3ly asOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBJ bXJlIERlYWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BtLmMgICAgICAgICB8ICA3ICsrKysrKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcnVudGltZV9wbS5jIHwgMTIgKysrKysrKysrKy0tCj4gIDIgZmlsZXMgY2hhbmdl ZCwgMTYgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3BtLmMKPiBpbmRleCA5Yzk3YTk1YzE4MTYuLmJlY2UxNmFlNmQxNSAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcG0uYwo+IEBAIC0zNjI0LDcgKzM2MjQsMTIgQEAgc3RhdGljIHU4IGludGVsX2Vu YWJsZWRfZGJ1Zl9zbGljZXNfbnVtKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK PiAgCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpIDwgMTEpCj4gIAkJcmV0dXJuIGVuYWJsZWRfc2xp Y2VzOwo+ICAKPiAtCWlmIChJOTE1X1JFQUQoREJVRl9DVExfUzIpICYgREJVRl9QT1dFUl9TVEFU RSkKPiArCS8qCj4gKwkgKiBGSVhNRTogZm9yIG5vdyB3ZSdsbCBvbmx5IGV2ZXIgdXNlIDEgc2xp Y2U7IHByZXRlbmQgdGhhdCB3ZSBoYXZlCj4gKwkgKiBvbmx5IHRoYXQgMSBzbGljZSBlbmFibGVk IHVudGlsIHdlIGhhdmUgYSBwcm9wZXIgd2F5IGZvciBvbi1kZW1hbmQKPiArCSAqIHRvZ2dsaW5n IG9mIHRoZSBzZWNvbmQgc2xpY2UuCj4gKwkgKi8KPiArCWlmICgwICYmIEk5MTVfUkVBRChEQlVG X0NUTF9TMikgJiBEQlVGX1BPV0VSX1NUQVRFKQoKd2hhdCBpZiBqdXN0IGFkZCBhIGNoZWNrIGZv ciBlbmFibGVkX3NsaWNlcyA+PSAyIGFuZCBhdm9pZCB0aGUgRklYTUUgaGVyZT8KCmJ1dCB1cCB0 byB5b3U6CgpSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29t PgoKPiAgCQllbmFibGVkX3NsaWNlcysrOwo+ICAKPiAgCXJldHVybiBlbmFibGVkX3NsaWNlczsK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jCj4gaW5kZXggYWE5NzRiMTE5 MjhhLi42NzZhODliYjgxOTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcnVudGltZV9wbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGlt ZV9wbS5jCj4gQEAgLTM1NzYsNyArMzU3NiwxMSBAQCBzdGF0aWMgdm9pZCBpY2xfZGJ1Zl9lbmFi bGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJICAgICEoSTkxNV9SRUFE KERCVUZfQ1RMX1MyKSAmIERCVUZfUE9XRVJfU1RBVEUpKQo+ICAJCURSTV9FUlJPUigiREJ1ZiBw b3dlciBlbmFibGUgdGltZW91dFxuIik7Cj4gIAllbHNlCj4gLQkJZGV2X3ByaXYtPndtLnNrbF9o dy5kZGIuZW5hYmxlZF9zbGljZXMgPSAyOwo+ICsJCS8qCj4gKwkJICogRklYTUU6IGZvciBub3cg cHJldGVuZCB0aGF0IHdlIG9ubHkgaGF2ZSAxIHNsaWNlLCBzZWUKPiArCQkgKiBpbnRlbF9lbmFi bGVkX2RidWZfc2xpY2VzX251bSgpLgo+ICsJCSAqLwo+ICsJCWRldl9wcml2LT53bS5za2xfaHcu ZGRiLmVuYWJsZWRfc2xpY2VzID0gMTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgaWNsX2RidWZf ZGlzYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gQEAgLTM1OTEsNyAr MzU5NSwxMSBAQCBzdGF0aWMgdm9pZCBpY2xfZGJ1Zl9kaXNhYmxlKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPiAgCSAgICAoSTkxNV9SRUFEKERCVUZfQ1RMX1MyKSAmIERCVUZf UE9XRVJfU1RBVEUpKQo+ICAJCURSTV9FUlJPUigiREJ1ZiBwb3dlciBkaXNhYmxlIHRpbWVvdXQh XG4iKTsKPiAgCWVsc2UKPiAtCQlkZXZfcHJpdi0+d20uc2tsX2h3LmRkYi5lbmFibGVkX3NsaWNl cyA9IDA7Cj4gKwkJLyoKPiArCQkgKiBGSVhNRTogZm9yIG5vdyBwcmV0ZW5kIHRoYXQgdGhlIGZp cnN0IHNsaWNlIGlzIGFsd2F5cwo+ICsJCSAqIGVuYWJsZWQsIHNlZSBpbnRlbF9lbmFibGVkX2Ri dWZfc2xpY2VzX251bSgpLgo+ICsJCSAqLwo+ICsJCWRldl9wcml2LT53bS5za2xfaHcuZGRiLmVu YWJsZWRfc2xpY2VzID0gMTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgaWNsX21idXNfaW5pdChz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gLS0gCj4gMi4xMy4yCj4gCj4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZngg bWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==