From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915/icl: Prevent incorrect DBuf enabling Date: Thu, 7 Mar 2019 21:45:29 +0200 Message-ID: <20190307194529.GA25702@ideak-desk.fi.intel.com> References: <20190307103235.23538-1-imre.deak@intel.com> <20190307175939.GG30283@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id D78B56E22A for ; Thu, 7 Mar 2019 19:45:56 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190307175939.GG30283@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBNYXIgMDcsIDIwMTkgYXQgMDk6NTk6MzlBTSAtMDgwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFRodSwgTWFyIDA3LCAyMDE5IGF0IDEyOjMyOjM1UE0gKzAyMDAsIEltcmUgRGVh ayB3cm90ZToKPiA+IFByZXRlbmQgdGhhdCB3ZSBoYXZlIG9ubHkgMSBEQnVmIHNsaWNlIGFuZCB0 aGF0IDEgc2xpY2UgaXMgYWx3YXlzCj4gPiBlbmFibGVkLCB1bnRpbCB3ZSBoYXZlIGEgcHJvcGVy IHdheSBmb3Igb24tZGVtYW5kIHRvZ2dsaW5nIG9mIHRoZSBzZWNvbmQKPiA+IHNsaWNlLiAgQ3Vy cmVudGx5IHdlJ2xsIHRyeSB0byBpbmNvcnJlY3RseSBlbmFibGUgREJ1ZiBldmVuIHdoZW4gYWxs Cj4gPiBwaXBlcyBhcmUgZGlzYWJsZWQgYW5kIHdlIGFyZSBhbHJlYWR5IHJ1bnRpbWUgc3VzcGVu ZGVkIChhcyB0aGUgY29tcHV0ZWQKPiA+IG51bWJlciBvZiBEQnVmIHNsaWNlcyB3aWxsIGJlIDEg aW4gdGhhdCBjYXNlKS4KPiA+IAo+ID4gVGhpcyBhbHNvIG1lYW5zIHdlJ2xsIGxlYXZlIHRoZSBz ZWNvbmQgc2xpY2UgZW5hYmxlZCByZWR1bmRhbnRseSAoZXhjZXB0Cj4gPiB3aGVuIHN1c3BlbmRl ZCksIGJ1dCB0aGF0J3MgYW4gYWNjZXB0YWJsZSB0cmFkZW9mZiB1bnRpbCB3ZSBoYXZlIGEKPiA+ IHByb3BlciBzb2x1dGlvbi4KPiAKPiByZWR1bmRhbnQgaXMgdGhlIHdvcmQgb2YgdGhlIHdlZWsg OikKPiAKPiA+IAo+ID4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hv d19idWcuY2dpP2lkPTEwODc1Ngo+ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBJbXJlIERlYWsgPGltcmUuZGVh a0BpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5j ICAgICAgICAgfCAgNyArKysrKystCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVu dGltZV9wbS5jIHwgMTIgKysrKysrKysrKy0tCj4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNl cnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMK PiA+IGluZGV4IDljOTdhOTVjMTgxNi4uYmVjZTE2YWU2ZDE1IDEwMDY0NAo+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcG0uYwo+ID4gQEAgLTM2MjQsNyArMzYyNCwxMiBAQCBzdGF0aWMgdTggaW50ZWxf ZW5hYmxlZF9kYnVmX3NsaWNlc19udW0oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ID4gIAlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8IDExKQo+ID4gIAkJcmV0dXJuIGVuYWJs ZWRfc2xpY2VzOwo+ID4gIAo+ID4gLQlpZiAoSTkxNV9SRUFEKERCVUZfQ1RMX1MyKSAmIERCVUZf UE9XRVJfU1RBVEUpCj4gPiArCS8qCj4gPiArCSAqIEZJWE1FOiBmb3Igbm93IHdlJ2xsIG9ubHkg ZXZlciB1c2UgMSBzbGljZTsgcHJldGVuZCB0aGF0IHdlIGhhdmUKPiA+ICsJICogb25seSB0aGF0 IDEgc2xpY2UgZW5hYmxlZCB1bnRpbCB3ZSBoYXZlIGEgcHJvcGVyIHdheSBmb3Igb24tZGVtYW5k Cj4gPiArCSAqIHRvZ2dsaW5nIG9mIHRoZSBzZWNvbmQgc2xpY2UuCj4gPiArCSAqLwo+ID4gKwlp ZiAoMCAmJiBJOTE1X1JFQUQoREJVRl9DVExfUzIpICYgREJVRl9QT1dFUl9TVEFURSkKPiAKPiB3 aGF0IGlmIGp1c3QgYWRkIGEgY2hlY2sgZm9yIGVuYWJsZWRfc2xpY2VzID49IDIgYW5kIGF2b2lk IHRoZSBGSVhNRSBoZXJlPwoKWW91IG1lYW4gPj0gMSBkdXJpbmcgc3RhdGUgdmVyaWZpY2F0aW9u PyBUaGF0IHdvdWxkIGFsc28gbmVlZCBpdHMgb3duCkZJWE1FOikgQW5kIHRoaXMgb25lIGhlcmUg bWF0Y2hlcyBiZXR0ZXIgd2hhdCB3ZSBkbyBlbHNld2hlcmUgdG8ga2VlcAp0aGluZ3Mgd29ya2lu Zy4KCj4gCj4gYnV0IHVwIHRvIHlvdToKPiAKPiBSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxy b2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+IAo+ID4gIAkJZW5hYmxlZF9zbGljZXMrKzsKPiA+ICAK PiA+ICAJcmV0dXJuIGVuYWJsZWRfc2xpY2VzOwo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3J1bnRpbWVfcG0uYwo+ID4gaW5kZXggYWE5NzRiMTE5MjhhLi42NzZhODliYjgxOTQgMTAwNjQ0 Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiA+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYwo+ID4gQEAgLTM1NzYs NyArMzU3NiwxMSBAQCBzdGF0aWMgdm9pZCBpY2xfZGJ1Zl9lbmFibGUoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIAkgICAgIShJOTE1X1JFQUQoREJVRl9DVExfUzIpICYg REJVRl9QT1dFUl9TVEFURSkpCj4gPiAgCQlEUk1fRVJST1IoIkRCdWYgcG93ZXIgZW5hYmxlIHRp bWVvdXRcbiIpOwo+ID4gIAllbHNlCj4gPiAtCQlkZXZfcHJpdi0+d20uc2tsX2h3LmRkYi5lbmFi bGVkX3NsaWNlcyA9IDI7Cj4gPiArCQkvKgo+ID4gKwkJICogRklYTUU6IGZvciBub3cgcHJldGVu ZCB0aGF0IHdlIG9ubHkgaGF2ZSAxIHNsaWNlLCBzZWUKPiA+ICsJCSAqIGludGVsX2VuYWJsZWRf ZGJ1Zl9zbGljZXNfbnVtKCkuCj4gPiArCQkgKi8KPiA+ICsJCWRldl9wcml2LT53bS5za2xfaHcu ZGRiLmVuYWJsZWRfc2xpY2VzID0gMTsKPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIHZvaWQgaWNs X2RidWZfZGlzYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiBAQCAt MzU5MSw3ICszNTk1LDExIEBAIHN0YXRpYyB2b2lkIGljbF9kYnVmX2Rpc2FibGUoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIAkgICAgKEk5MTVfUkVBRChEQlVGX0NUTF9T MikgJiBEQlVGX1BPV0VSX1NUQVRFKSkKPiA+ICAJCURSTV9FUlJPUigiREJ1ZiBwb3dlciBkaXNh YmxlIHRpbWVvdXQhXG4iKTsKPiA+ICAJZWxzZQo+ID4gLQkJZGV2X3ByaXYtPndtLnNrbF9ody5k ZGIuZW5hYmxlZF9zbGljZXMgPSAwOwo+ID4gKwkJLyoKPiA+ICsJCSAqIEZJWE1FOiBmb3Igbm93 IHByZXRlbmQgdGhhdCB0aGUgZmlyc3Qgc2xpY2UgaXMgYWx3YXlzCj4gPiArCQkgKiBlbmFibGVk LCBzZWUgaW50ZWxfZW5hYmxlZF9kYnVmX3NsaWNlc19udW0oKS4KPiA+ICsJCSAqLwo+ID4gKwkJ ZGV2X3ByaXYtPndtLnNrbF9ody5kZGIuZW5hYmxlZF9zbGljZXMgPSAxOwo+ID4gIH0KPiA+ICAK PiA+ICBzdGF0aWMgdm9pZCBpY2xfbWJ1c19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdikKPiA+IC0tIAo+ID4gMi4xMy4yCj4gPiAKPiA+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4g PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=