From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B71B4C43381 for ; Sat, 9 Mar 2019 07:21:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8304D20868 for ; Sat, 9 Mar 2019 07:21:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726758AbfCIHVB (ORCPT ); Sat, 9 Mar 2019 02:21:01 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:44184 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725787AbfCIHVB (ORCPT ); Sat, 9 Mar 2019 02:21:01 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9090F14BED540; Fri, 8 Mar 2019 23:20:58 -0800 (PST) Date: Fri, 08 Mar 2019 23:20:57 -0800 (PST) Message-Id: <20190308.232057.1297154950610356905.davem@davemloft.net> To: natechancellor@gmail.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, ndesaulniers@google.com Subject: Re: [PATCH] net: stmmac: Avoid one more sometimes uninitialized Clang warning From: David Miller In-Reply-To: <20190308040239.9400-1-natechancellor@gmail.com> References: <20190307162101.29204-1-natechancellor@gmail.com> <20190308040239.9400-1-natechancellor@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 08 Mar 2019 23:20:59 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nathan Chancellor Date: Thu, 7 Mar 2019 21:02:39 -0700 > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c:111:2: error: variable > 'ns' is used uninitialized whenever 'if' condition is false > [-Werror,-Wsometimes-uninitialized] > drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c:111:2: error: variable > 'ns' is used uninitialized whenever '&&' condition is false > [-Werror,-Wsometimes-uninitialized] > > Clang is concerned with the use of stmmac_do_void_callback (which > stmmac_get_systime wraps), as it may fail to initialize these values if > the if condition was ever false (meaning the callback doesn't exist). > It's not wrong because the callback is what initializes ns. While it's > unlikely that the callback is going to disappear at some point and make > that condition false, we can easily avoid this warning by zero > initializing the variable. > > Link: https://github.com/ClangBuiltLinux/linux/issues/384 > Fixes: df103170854e ("net: stmmac: Avoid sometimes uninitialized Clang warnings") > Suggested-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor Applied, thanks Nathan. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3BF4C43381 for ; Sat, 9 Mar 2019 07:21:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 733872081B for ; Sat, 9 Mar 2019 07:21:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LD/YNIgg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 733872081B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: From:Subject:To:Message-Id:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QQvTGx7VLigLEya6BL4MluULXwFmPHPl5SZRFluyUsI=; b=LD/YNIgg/Gwzf0 vbF9unmuVcaedRoaDfVqxceH1VuV9MaOEZvOeCRRZF8vn6VA+PwXut6Qj30pSeRDsRYnMsYNV1qkk GI08tsRSCPrq0VI7/txlAVICkPYy7uiXxomz337iS9U+vWFejq2xGS+hu7Z4R//JrInAOvavKkG+1 AZ8sRUHMfL8mB6ODFcU24cY1PSwmEmdDH8/mZGY05Lfe041pDyfmuo9D1g049sqq93rnn93608TUo 1cI91VH8FMQ53h5PEhf8T+9VqjdMNbeCVFQHdnhBMUj3T9w81vB6aUlYoKGEkmU1DxUA/DkH6+j0N IO3f4Ep5Y1owk8leXZrQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h2WI7-0007lv-Tq; Sat, 09 Mar 2019 07:21:07 +0000 Received: from shards.monkeyblade.net ([2620:137:e000::1:9]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h2WI4-0007lI-5X for linux-arm-kernel@lists.infradead.org; Sat, 09 Mar 2019 07:21:05 +0000 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9090F14BED540; Fri, 8 Mar 2019 23:20:58 -0800 (PST) Date: Fri, 08 Mar 2019 23:20:57 -0800 (PST) Message-Id: <20190308.232057.1297154950610356905.davem@davemloft.net> To: natechancellor@gmail.com Subject: Re: [PATCH] net: stmmac: Avoid one more sometimes uninitialized Clang warning From: David Miller In-Reply-To: <20190308040239.9400-1-natechancellor@gmail.com> References: <20190307162101.29204-1-natechancellor@gmail.com> <20190308040239.9400-1-natechancellor@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 08 Mar 2019 23:20:59 -0800 (PST) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190308_232104_211382_4DF619C4 X-CRM114-Status: UNSURE ( 8.45 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.torgue@st.com, netdev@vger.kernel.org, ndesaulniers@google.com, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, peppe.cavallaro@st.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Nathan Chancellor Date: Thu, 7 Mar 2019 21:02:39 -0700 > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c:111:2: error: variable > 'ns' is used uninitialized whenever 'if' condition is false > [-Werror,-Wsometimes-uninitialized] > drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c:111:2: error: variable > 'ns' is used uninitialized whenever '&&' condition is false > [-Werror,-Wsometimes-uninitialized] > > Clang is concerned with the use of stmmac_do_void_callback (which > stmmac_get_systime wraps), as it may fail to initialize these values if > the if condition was ever false (meaning the callback doesn't exist). > It's not wrong because the callback is what initializes ns. While it's > unlikely that the callback is going to disappear at some point and make > that condition false, we can easily avoid this warning by zero > initializing the variable. > > Link: https://github.com/ClangBuiltLinux/linux/issues/384 > Fixes: df103170854e ("net: stmmac: Avoid sometimes uninitialized Clang warnings") > Suggested-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor Applied, thanks Nathan. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel