All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Gary Guo <gary@garyguo.net>
Cc: "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH] riscv: move flush_icache_{all, mm} code to proper location
Date: Fri, 8 Mar 2019 06:24:22 -0800	[thread overview]
Message-ID: <20190308142421.GA32707@infradead.org> (raw)
In-Reply-To: <LO2P265MB0847855A503C55BB11A59A89D6730@LO2P265MB0847.GBRP265.PROD.OUTLOOK.COM>

On Wed, Mar 06, 2019 at 05:00:21PM +0000, Gary Guo wrote:
> Currently, flush_icache_all is macro-expanded into a SBI call, yet no
> asm/sbi.h is included in asm/cacheflush.h. This could be moved to
> mm/cacheflush.c instead (SBI call will dominate performance-wise and there
> is no worry to not have it inlined.
> 
> Currently, flush_icache_mm stays in kernel/smp.c, which looks like a hack
> to prevent it from being compiled when CONFIG_SMP=n. It should also be in
> mm/cacheflush.c.

The non-SMP version of flush_icache_mm should also move to cacheflush.c.

Please make this flush_icache_mm one patch, and the a second one on top
of that that just removes flush_icache_all and open codes the two
users.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2019-03-08 14:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-06 17:00 [PATCH] riscv: move flush_icache_{all,mm} code to proper location Gary Guo
2019-03-08 14:24 ` Christoph Hellwig [this message]
2019-03-08 15:23   ` [PATCH] riscv: move flush_icache_{all, mm} " Gary Guo
2019-03-08 16:28     ` Christoph Hellwig
2019-05-21 10:38 ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190308142421.GA32707@infradead.org \
    --to=hch@infradead.org \
    --cc=gary@garyguo.net \
    --cc=linux-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.