From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v5 6/9] btrfs: start transaction in btrfs_set_acl
Date: Fri, 8 Mar 2019 15:52:25 +0100 [thread overview]
Message-ID: <20190308145225.GR31119@twin.jikos.cz> (raw)
In-Reply-To: <1551414895-22925-7-git-send-email-anand.jain@oracle.com>
On Fri, Mar 01, 2019 at 12:34:52PM +0800, Anand Jain wrote:
> The main motivation is to avoid NULL for the trans argument reaching
> btrfs_set_xattr(). This patch does the following in btrfs_set_acl().
> Create transaction and handle the inode changes update, (copies code
> from btrfs_setxattr() as in the original, which needs a fix).
> Rename __btrfs_set_acl to do_set_acl as this is a helper function.
> Fix a c-code style, expand function declaration to max length 80 char.
You don't need to mention fixing the coding style unless it's the sole
purpose of the patch.
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> ---
> v5: change log update. Use BUG_ON instead of ASSERT.
> v4: born
> fs/btrfs/acl.c | 36 ++++++++++++++++++++++++++----------
> 1 file changed, 26 insertions(+), 10 deletions(-)
>
> -int btrfs_init_acl(struct btrfs_trans_handle *trans,
> - struct inode *inode, struct inode *dir)
> +int btrfs_init_acl(struct btrfs_trans_handle *trans, struct inode *inode,
> + struct inode *dir)
Please don't do such drive-by changes, there's no difference but one has
still make sure there is none and that it's not an accidental edit.
It's ok if you rename or move a function to fix the indentation but
otherwise I have to review it and then undo it.
next prev parent reply other threads:[~2019-03-08 14:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 4:34 [PATCH v5 0/9] Misc props.c cleanups Anand Jain
2019-03-01 4:34 ` [PATCH v5 1/9] btrfs: kill __btrfs_set_prop() Anand Jain
2019-03-01 4:34 ` [PATCH v5 2/9] btrfs: drop redundant forward declaration in props.c Anand Jain
2019-03-01 4:34 ` [PATCH v5 3/9] btrfs: rename fs_info argument to fs_private Anand Jain
2019-03-01 4:34 ` [PATCH v5 4/9] btrfs: refactor btrfs_set_prop add btrfs_set_prop_trans Anand Jain
2019-03-08 14:49 ` David Sterba
2019-03-01 4:34 ` [PATCH v5 5/9] btrfs: start transaction in btrfs_set_prop_trans Anand Jain
2019-03-01 4:34 ` [PATCH v5 6/9] btrfs: start transaction in btrfs_set_acl Anand Jain
2019-03-08 14:52 ` David Sterba [this message]
2019-03-01 4:34 ` [PATCH v5 7/9] btrfs: start transaction in btrfs_xattr_handler_set Anand Jain
2019-03-01 4:34 ` [PATCH v5 8/9] btrfs: btrfs_setxattr argument trans is never NULL Anand Jain
2019-03-01 4:34 ` [PATCH v5 9/9] btrfs: kill btrfs_setxattr Anand Jain
2019-03-08 14:56 ` David Sterba
2019-03-09 1:18 ` Anand Jain
2019-03-08 15:01 ` [PATCH v5 0/9] Misc props.c cleanups David Sterba
2019-03-09 0:04 ` Anand Jain
2019-03-11 14:41 ` David Sterba
2019-03-12 11:12 ` Anand Jain
2019-03-12 17:22 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308145225.GR31119@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.