From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8EFAC43381 for ; Fri, 8 Mar 2019 15:04:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB24D2133F for ; Fri, 8 Mar 2019 15:04:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="YI5aPZfH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726898AbfCHPEd (ORCPT ); Fri, 8 Mar 2019 10:04:33 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:34027 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbfCHPEd (ORCPT ); Fri, 8 Mar 2019 10:04:33 -0500 Received: by mail-wr1-f66.google.com with SMTP id f14so21712384wrg.1 for ; Fri, 08 Mar 2019 07:04:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DKryimbxkbY5m6C1wgCpXF/fHfWeW0zZQl3VSWaqzFE=; b=YI5aPZfHySDfKK4I+53+G9hJn8GjgoH18w1upftlj8K4iwoBT3ZwuAYRyCliVWvF1w CPlfLlBue4SWBG4VRk2ZU+5FiGEF4sJKCSbe6YnmdnPf2TFEgSTSAC2AMg20yMn9gOfd nUEiuu9oc0Zwy2QNDR7jxq7A84pgIE+jgkaPCipDrBiA0Dv+2px7t2HBvF2Yq7doSIdJ 2OFHlk9xn1FlM5qpMi5ZwJ0Nr0/bB6ym1L2+eeInixDKvd2+uRAnEHbe8UOfHB+uKiCT IbfsmuYd/Z3qiGNm/SNcXf+1tAMrDozW7p9eF0imwU1aFSZYk5wyqFrYVbGomUf/gqYg 9Ifg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DKryimbxkbY5m6C1wgCpXF/fHfWeW0zZQl3VSWaqzFE=; b=PB+8eXFB+W9kQfVj4PXWc54UDa5YcvT9wl+yhW6QC+4TW6NlSsnQWR3xN1MCqgBfEB qC1TEoxRsVK/t62cen2nxnkeICkvDnsj7soRzsjZjh3qBWbe7Y0fv1WPmGcdu7X6dySJ Wj3PWU23HenfEae6xb0PwzMuwWCSpSs4mV0tPI4bueNUdnIOzve1aVRoTUvGZeOc/ixg uIx9U3eQ6xPi4JlkNw4muAdlz5ViglivMDwySpPvYs0Df0A5/PVXPKvawn3E+LbBFHYk nPodmnAV87Jses3qZeyO4W/rWH63+cFHRrjeIEPCoaBl6Nykpi1xXx5CBFNuvsKqa3DF 3pbA== X-Gm-Message-State: APjAAAVVB4NkugW2W0jwBIf0ZLQhldeeyl/p7AeoJb+tj/3rcXCZgvFU u3js6NVmlgZUOvolBG6UHoZpdQ== X-Google-Smtp-Source: APXvYqxOyZRTeKaVbRcmF4Gxr6BeSqY8yIK4ck0G5CvIinnNWYq+0c20AqE8w1cHa3vHj80drw2lRw== X-Received: by 2002:adf:f410:: with SMTP id g16mr11851032wro.246.1552057471277; Fri, 08 Mar 2019 07:04:31 -0800 (PST) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id k203sm10713252wmf.44.2019.03.08.07.04.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Mar 2019 07:04:30 -0800 (PST) Date: Fri, 8 Mar 2019 15:54:21 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Message-ID: <20190308145421.GA2888@nanopsycho.orion> References: <20190302094116.GQ2314@nanopsycho> <20190302114847.733759a1@cakuba.netronome.com> <20190304075609.GV2314@nanopsycho> <20190304163302.7e40219e@cakuba.netronome.com> <20190305110601.GC2314@nanopsycho> <20190305091534.36200de6@cakuba.hsd1.ca.comcast.net> <20190306122037.GB2819@nanopsycho> <20190306095638.7c028bdd@cakuba.hsd1.ca.comcast.net> <20190307094816.GA2190@nanopsycho> <20190307185202.2db37490@cakuba.hsd1.ca.comcast.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190307185202.2db37490@cakuba.hsd1.ca.comcast.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Mar 08, 2019 at 03:52:02AM CET, jakub.kicinski@netronome.com wrote: >On Thu, 7 Mar 2019 10:48:16 +0100, Jiri Pirko wrote: >> Wed, Mar 06, 2019 at 06:56:38PM CET, jakub.kicinski@netronome.com wrote: >> >On Wed, 6 Mar 2019 13:20:37 +0100, Jiri Pirko wrote: >> >For creating subdevices, I don't think the handle should ever be port. >> >We create new ports on a devlink instance, and configure its forwarding >> >> Okay I agree. Something like: >> $ devlink port add pci/0000:00:10.0 ..... >> >> It's a bit confusing because "set" accepts port handle (like >> pci/0000:00:10.0/1). Probably better would be: >> $ devlink dev port add pci/0000:00:10.0 ..... >> >> >with offloads of well established Linux SW constructs. New devices are >> >not logically associated with other ports (see how in my patches there >> >are 2 "subports" but no main port on that PF - a split not a hierarchy). >> >> Right, basically you have 2 equal objects. Makes sense. >> >> >How we want to model forwarding inside a VM (who configures the >> >underlying switching) remains unclear. >> >> I don't understand. Could you elaborate a bit? > >If VF in a VM gets a partitioning request does the new port pop up on >the hypervisor? With a port netdev? Switchport in hypervizor with correct switchid attribute, hostport in vm. Makes sense? > >Does the VF also create a port object as well as host port object? > >That question is probably independent of host port discussion.