Re: [PATCH 1/2] staging: wilc1000: remove unnecessary variable ret

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Mar 09, 2019 at 04:37:42PM +0530, Himadri Pandya wrote:
> Remove unnecessary local variable "ret" and its assignments from
> function wilc_set_tx_power. Suggested by Coccinelle.
> 
> Signed-off-by: Himadri Pandya <himadri18.07@gmail.com>
> ---
>  drivers/staging/wilc1000/host_interface.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index fa0e1bd9f836..4a5f83ae06d2 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -2119,7 +2119,6 @@ int wilc_setup_multicast_filter(struct wilc_vif *vif, u32 enabled, u32 count,
>  
>  int wilc_set_tx_power(struct wilc_vif *vif, u8 tx_power)
>  {
> -	int ret;
>  	struct wid wid;
>  
>  	wid.id = WID_TX_POWER;
> @@ -2127,10 +2126,9 @@ int wilc_set_tx_power(struct wilc_vif *vif, u8 tx_power)
>  	wid.val = &tx_power;
>  	wid.size = sizeof(char);
>  
> -	ret = wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1,
> +	return wilc_send_config_pkt(vif, WILC_SET_CFG, &wid, 1,
>  				   wilc_get_vif_idx(vif));
>  
> -	return ret;
>  }
>  
>  int wilc_get_tx_power(struct wilc_vif *vif, u8 *tx_power)
> -- 
> 2.17.1
>


Your two patches do the same thing, but your wording is just a _little_
different.  Why not make this just one patch that does that one thing,
for two different functions?

thanks,

greg k-h