From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5BD4C43381 for ; Mon, 11 Mar 2019 14:16:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7EC172075C for ; Mon, 11 Mar 2019 14:16:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727459AbfCKOQO (ORCPT ); Mon, 11 Mar 2019 10:16:14 -0400 Received: from verein.lst.de ([213.95.11.211]:41681 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727219AbfCKOQO (ORCPT ); Mon, 11 Mar 2019 10:16:14 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 154C368C7B; Mon, 11 Mar 2019 15:16:09 +0100 (CET) Date: Mon, 11 Mar 2019 15:16:08 +0100 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, ris Ostrovsky , Juergen Gross , xen-devel@lists.xenproject.org, Omar Sandoval , Christoph Hellwig Subject: Re: [PATCH 1/6] block: pass page to xen_biovec_phys_mergeable Message-ID: <20190311141608.GA7850@lst.de> References: <20190309013737.27741-1-ming.lei@redhat.com> <20190309013737.27741-2-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190309013737.27741-2-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sat, Mar 09, 2019 at 09:37:32AM +0800, Ming Lei wrote: > xen_biovec_phys_mergeable() only needs .bv_page of the 2nd bio bvec > for checking if the two bvecs can be merged, so pass page to > xen_biovec_phys_mergeable() directly. Looks fine: Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/6] block: pass page to xen_biovec_phys_mergeable Date: Mon, 11 Mar 2019 15:16:08 +0100 Message-ID: <20190311141608.GA7850@lst.de> References: <20190309013737.27741-1-ming.lei@redhat.com> <20190309013737.27741-2-ming.lei@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1h3Lj1-00042m-P1 for xen-devel@lists.xenproject.org; Mon, 11 Mar 2019 14:16:19 +0000 Content-Disposition: inline In-Reply-To: <20190309013737.27741-2-ming.lei@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Ming Lei Cc: Jens Axboe , Juergen Gross , Christoph Hellwig , linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, ris Ostrovsky , Omar Sandoval List-Id: xen-devel@lists.xenproject.org T24gU2F0LCBNYXIgMDksIDIwMTkgYXQgMDk6Mzc6MzJBTSArMDgwMCwgTWluZyBMZWkgd3JvdGU6 Cj4geGVuX2Jpb3ZlY19waHlzX21lcmdlYWJsZSgpIG9ubHkgbmVlZHMgLmJ2X3BhZ2Ugb2YgdGhl IDJuZCBiaW8gYnZlYwo+IGZvciBjaGVja2luZyBpZiB0aGUgdHdvIGJ2ZWNzIGNhbiBiZSBtZXJn ZWQsIHNvIHBhc3MgcGFnZSB0bwo+IHhlbl9iaW92ZWNfcGh5c19tZXJnZWFibGUoKSBkaXJlY3Rs eS4KCkxvb2tzIGZpbmU6CgpSZXZpZXdlZC1ieTogQ2hyaXN0b3BoIEhlbGx3aWcgPGhjaEBsc3Qu ZGU+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4t ZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczov L2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs