From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6915C43381 for ; Mon, 11 Mar 2019 17:57:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B66D820828 for ; Mon, 11 Mar 2019 17:57:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728178AbfCKR47 (ORCPT ); Mon, 11 Mar 2019 13:56:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48550 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726675AbfCKR47 (ORCPT ); Mon, 11 Mar 2019 13:56:59 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8D4BD309EA7A; Mon, 11 Mar 2019 17:56:58 +0000 (UTC) Received: from krava (ovpn-204-107.brq.redhat.com [10.40.204.107]) by smtp.corp.redhat.com (Postfix) with SMTP id D84801001DDD; Mon, 11 Mar 2019 17:56:55 +0000 (UTC) Date: Mon, 11 Mar 2019 18:56:54 +0100 From: Jiri Olsa To: Song Liu Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, kernel-team@fb.com, peterz@infradead.org, acme@redhat.com, jolsa@kernel.org, namhyung@kernel.org Subject: Re: [PATCH v7 perf,bpf 07/15] perf, bpf: save bpf_prog_info information as headers to perf.data Message-ID: <20190311175654.GC19721@krava> References: <20190307175810.249857-1-songliubraving@fb.com> <20190307175810.249857-8-songliubraving@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190307175810.249857-8-songliubraving@fb.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Mon, 11 Mar 2019 17:56:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 07, 2019 at 09:58:02AM -0800, Song Liu wrote: > This patch enables perf-record to save bpf_prog_info information as > headers to perf.data. A new header type HEADER_BPF_PROG_INFO is > introduced for this data. > > Signed-off-by: Song Liu > --- > tools/perf/util/header.c | 145 ++++++++++++++++++++++++++++++++++++++- > tools/perf/util/header.h | 1 + > 2 files changed, 145 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c > index 4b88de5e9192..f0708188211e 100644 > --- a/tools/perf/util/header.c > +++ b/tools/perf/util/header.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > > #include "evlist.h" > #include "evsel.h" > @@ -39,6 +40,7 @@ > #include "tool.h" > #include "time-utils.h" > #include "units.h" > +#include "bpf-event.h" > > #include "sane_ctype.h" > > @@ -1074,6 +1076,54 @@ static int write_clockid(struct feat_fd *ff, > sizeof(ff->ph->env.clockid_res_ns)); > } > > +static int write_bpf_prog_info(struct feat_fd *ff, > + struct perf_evlist *evlist __maybe_unused) > +{ > + struct perf_env *env = &ff->ph->env; > + struct rb_root *root; > + struct rb_node *next; > + u32 count = 0; > + int ret; > + > + down_read(&env->bpf_progs.lock); > + > + root = &env->bpf_progs.infos; > + next = rb_first(root); > + while (next) { > + ++count; > + next = rb_next(next); > + } sry I did not se this before, but why you don't keep program count in perf_env::bpf_progs::infos_cnt ? jirka