From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Mon, 11 Mar 2019 21:42:04 +0000 Subject: Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems Message-Id: <20190311214204.GA24416@ravnborg.org> List-Id: References: <20190309214852.12233-1-dante.paz@gmail.com> <20190311162527.GA20652@ravnborg.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: DANTE JAVIER PAZ Cc: devel@driverdev.osuosl.org, leobras.c@gmail.com, linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com, gregkh@linuxfoundation.org, Dante Paz , dri-devel@lists.freedesktop.org, renatoys08@gmail.com Hi Dante. > Hello Sam, thank you very much for your comments, > As I told Dan (my email did not reach the mailing list) this is my > first attempt to contribute, > So I'm learning a lot from your advice and corrections. > > I will look for TODO lists to see if there are more useful > contributions to make, all suggestions are also welcome. Keep the good spirit, and find some other driver to look into. You must realise than experienced developers sometimes goes through several version before a patch is ready. So expect it to be a bumpy ride the first few times. Good luck! Sam From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems Date: Mon, 11 Mar 2019 22:42:04 +0100 Message-ID: <20190311214204.GA24416@ravnborg.org> References: <20190309214852.12233-1-dante.paz@gmail.com> <20190311162527.GA20652@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2342E89BFF for ; Mon, 11 Mar 2019 21:42:08 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: DANTE JAVIER PAZ Cc: devel@driverdev.osuosl.org, leobras.c@gmail.com, linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com, gregkh@linuxfoundation.org, Dante Paz , dri-devel@lists.freedesktop.org, renatoys08@gmail.com List-Id: dri-devel@lists.freedesktop.org SGkgRGFudGUuCgo+IEhlbGxvIFNhbSwgdGhhbmsgeW91IHZlcnkgbXVjaCBmb3IgeW91ciBjb21t ZW50cywKPiBBcyBJIHRvbGQgRGFuIChteSBlbWFpbCBkaWQgbm90IHJlYWNoIHRoZSBtYWlsaW5n IGxpc3QpIHRoaXMgaXMgbXkKPiBmaXJzdCBhdHRlbXB0IHRvIGNvbnRyaWJ1dGUsCj4gU28gSSdt IGxlYXJuaW5nIGEgbG90IGZyb20geW91ciBhZHZpY2UgYW5kIGNvcnJlY3Rpb25zLgo+IAo+IEkg d2lsbCBsb29rIGZvciBUT0RPIGxpc3RzIHRvIHNlZSBpZiB0aGVyZSBhcmUgbW9yZSB1c2VmdWwK PiBjb250cmlidXRpb25zIHRvIG1ha2UsIGFsbCBzdWdnZXN0aW9ucyBhcmUgYWxzbyB3ZWxjb21l LgoKS2VlcCB0aGUgZ29vZCBzcGlyaXQsIGFuZCBmaW5kIHNvbWUgb3RoZXIgZHJpdmVyIHRvIGxv b2sgaW50by4KCllvdSBtdXN0IHJlYWxpc2UgdGhhbiBleHBlcmllbmNlZCBkZXZlbG9wZXJzIHNv bWV0aW1lcyBnb2VzCnRocm91Z2ggc2V2ZXJhbCB2ZXJzaW9uIGJlZm9yZSBhIHBhdGNoIGlzIHJl YWR5LgpTbyBleHBlY3QgaXQgdG8gYmUgYSBidW1weSByaWRlIHRoZSBmaXJzdCBmZXcgdGltZXMu CgpHb29kIGx1Y2shCglTYW0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVs