From: Greg KH <gregkh@linuxfoundation.org>
To: Jules Octave <jbi.octave@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v1 1/3] staging: rtl8192e: add SPDX GPL-2.0+ license identifier
Date: Mon, 11 Mar 2019 15:40:52 -0700 [thread overview]
Message-ID: <20190311224052.GA31563@kroah.com> (raw)
In-Reply-To: <CAOuULM61DXcVaTHhXvwnmS0FdREQjsFLnKxC4abGG2OcD092wQ@mail.gmail.com>
On Mon, Mar 11, 2019 at 10:15:03PM +0000, Jules Octave wrote:
> >Why did you pick this specific license? It does not seem to match the
> >license text in this file at all.
>
> >Be _VERY_ careful when doing stuff like this. If you get the license
> >wrong, lawyers can get mad at you :(
>
> >Also, the file name "dot11d.c" should be in the subject line, as you are
> >not adding the identifer to the whole driver, only one file.
>
> >Please fix this up and resend the whole series.
>
> >thanks,
>
> I read online that the default license is GPL-2.0+ as it is not indicated
> in the file. I think I was wrong. I would have asked the maintainer first.
Where did you read that? The default license for the Linux kernel is
"GPL-2.0" no "+" at all.
> Okay, I will just reset it and try to think how to deal with it . I have in
> mind a GPL 1.0+ as it covers from 1 and above, I don t know if it can be
> fine. I have to ask the maintainer. I am sorry.
As the wording of the text says to refer to the LICENSE file, and that
is GPLv2, that should be the license for this file as well.
But if you do not understand license issues, I would stay away from this
and work on other tasks. It's tricky and people get upset if you get it
wrong :)
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-11 22:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 0:06 [PATCH v1 0/3] SPDX cleanups and line over 80 characters fix Jules Irenge
2019-03-11 0:07 ` [PATCH v1 1/3] staging: rtl8192e: add SPDX GPL-2.0+ license identifier Jules Irenge
2019-03-11 3:04 ` Greg KH
2019-03-11 22:15 ` Jules Octave
2019-03-11 22:40 ` Greg KH [this message]
2019-03-11 22:55 ` Jules Octave
2019-03-11 0:07 ` [PATCH v1 2/3] staging: rtl8192e: remove license boilerplate text Jules Irenge
2019-03-11 0:07 ` [PATCH v1 3/3] staging: rtl8192e: fix line over 80 characters warning Jules Irenge
2019-03-11 3:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311224052.GA31563@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jbi.octave@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.