[PATCH] Fix for a small typo

[PATCH] Fix for a small typo

[Milan P. Gandhi]

Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
---
 drivers/scsi/qla2xxx/qla_bsg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
index 17d42658ad9a..f2b95f11a71c 100644
--- a/drivers/scsi/qla2xxx/qla_bsg.c
+++ b/drivers/scsi/qla2xxx/qla_bsg.c
@@ -1354,7 +1354,7 @@ qla24xx_iidma(struct bsg_job *bsg_job)
 
 	if (rval) {
 		ql_log(ql_log_warn, vha, 0x704c,
-		    "iIDMA cmd failed for %8phN -- "
+		    "iiDMA cmd failed for %8phN -- "
 		    "%04x %x %04x %04x.\n", fcport->port_name,
 		    rval, fcport->fp_speed, mb[0], mb[1]);
 		rval = (DID_ERROR << 16);

Re: [PATCH] Fix for a small typo

[Julia Lawall]

On Tue, 12 Mar 2019, Milan P. Gandhi wrote:

The patch should have a log message.  For example, you could point out
where the type is so the reader doesn't have to search for it.

The subject line should also give a hint about what file is affected, so
that the right person will pay attention to it. You can see what subject
lines others have used on this file by:

git log --oneline drivers/scsi/qla2xxx/qla_bsg.c

julia


> Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
> ---
>  drivers/scsi/qla2xxx/qla_bsg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
> index 17d42658ad9a..f2b95f11a71c 100644
> --- a/drivers/scsi/qla2xxx/qla_bsg.c
> +++ b/drivers/scsi/qla2xxx/qla_bsg.c
> @@ -1354,7 +1354,7 @@ qla24xx_iidma(struct bsg_job *bsg_job)
>
>  	if (rval) {
>  		ql_log(ql_log_warn, vha, 0x704c,
> -		    "iIDMA cmd failed for %8phN -- "
> +		    "iiDMA cmd failed for %8phN -- "
>  		    "%04x %x %04x %04x.\n", fcport->port_name,
>  		    rval, fcport->fp_speed, mb[0], mb[1]);
>  		rval = (DID_ERROR << 16);
>

Re: [PATCH] Fix for a small typo

[Dan Carpenter]

1) Subject
2) No patch description.  (What type did you fix?)
3) CC list.

regards,
dan carpenter

Re: [PATCH] Fix for a small typo

[Milan P. Gandhi]

On 3/12/19 4:46 PM, Dan Carpenter wrote:
> 1) Subject
> 2) No patch description.  (What type did you fix?)
> 3) CC list.
> 

Hi Dan, Julia,

Thanks for pointing it out.
Let me fix it quickly.

regards,
Milan.

Re: [PATCH] Fix for a small typo

[Dan Carpenter]

On Tue, Mar 12, 2019 at 04:50:07PM +0530, Milan P. Gandhi wrote:
> On 3/12/19 4:46 PM, Dan Carpenter wrote:
> > 1) Subject
> > 2) No patch description.  (What type did you fix?)
> > 3) CC list.
> > 
> 
> Hi Dan, Julia,
> 
> Thanks for pointing it out.
> Let me fix it quickly.

There is absolutely no need to rush.  Please go slowly.

regards,
dan carpenter