From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37315C43381 for ; Tue, 12 Mar 2019 17:44:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A4152087C for ; Tue, 12 Mar 2019 17:44:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552412662; bh=ijOs+cHaXoxmxtie+LkYkYW2a66VDlZhxH4T/PddzOA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ZZt6XrGwY8gFAJzZwF2DJGjkMc5KLy52n2dB/FCXrAw2fDC5B+cjiv5zpS4UPIBJP LVQ3rmtMd9ZM/LHK4is8+L3lu0LZ+UjJeiahSB8rwLlKreGYjyyXUliYx92BltcVvK +rElkVe7Bi3DI+Gtp74g8BTsayyCkXBXM3Mnxpqo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728854AbfCLRoU (ORCPT ); Tue, 12 Mar 2019 13:44:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:56606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728834AbfCLRPk (ORCPT ); Tue, 12 Mar 2019 13:15:40 -0400 Received: from localhost (unknown [104.133.8.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 48B6E2171F; Tue, 12 Mar 2019 17:15:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552410940; bh=ijOs+cHaXoxmxtie+LkYkYW2a66VDlZhxH4T/PddzOA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JrQUv1wZ2DRARSpb2NkT3DyaBUOo/CsIY/zbxfPf1MooUVuTQAaAOWkpOH0Q9IPDn AL1kvNYFg/+Lei+EnD11/aq80pJxV9a9gv/UIlMV+tQetg9uN9cHTgujcE2Ho3eapW +12+AE7hLEvt06/wKCL00cSf94TtERh/AheuJBxs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chris Healy , Andrew Lunn , "David S. Miller" Subject: [PATCH 4.14 017/135] net: dsa: mv88e6xxx: Fix u64 statistics Date: Tue, 12 Mar 2019 10:07:44 -0700 Message-Id: <20190312170342.695671882@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190312170341.127810985@linuxfoundation.org> References: <20190312170341.127810985@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrew Lunn [ Upstream commit 6e46e2d821bb22b285ae8187959096b65d063b0d ] The switch maintains u64 counters for the number of octets sent and received. These are kept as two u32's which need to be combined. Fix the combing, which wrongly worked on u16's. Fixes: 80c4627b2719 ("dsa: mv88x6xxx: Refactor getting a single statistic") Reported-by: Chris Healy Signed-off-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -639,7 +639,7 @@ static uint64_t _mv88e6xxx_get_ethtool_s default: return UINT64_MAX; } - value = (((u64)high) << 16) | low; + value = (((u64)high) << 32) | low; return value; }