From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14556C43381 for ; Tue, 12 Mar 2019 17:41:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2C28206DF for ; Tue, 12 Mar 2019 17:41:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552412499; bh=yFqUeBKk7uxIbvvuwkhJg4YfewCg7+vTo8if1fKA6Fs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vK/a9fCWqogVZ1XxlcbIYrqc2CtgO0GG/ksSkLyAF17Tvd270ZuGlLK8yk1uT68Hw NVqOZ1XPzS3n9c3Nu+r9nUlKLhCWp/FAMemB/lmkyNEG/VuqTDIslW+eb0DmeCjauE YRGk2EWL9XrAlv1RqjcsVf+dBZ4+k8d8aLti4MRE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729085AbfCLRli (ORCPT ); Tue, 12 Mar 2019 13:41:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:57638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728983AbfCLRQF (ORCPT ); Tue, 12 Mar 2019 13:16:05 -0400 Received: from localhost (unknown [104.133.8.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A98C82183F; Tue, 12 Mar 2019 17:16:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552410964; bh=yFqUeBKk7uxIbvvuwkhJg4YfewCg7+vTo8if1fKA6Fs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gdlqag32PbV8Sd3EuUzo4ccfbzyXG23oUUodKb4BnDUKGex8/CVvZXoA4+DtSEcBq C+gJlIZl2jBIOJt/C0u+8tEukaTkpV4ARcc0PHuNSv1IkySkqwU6Bk4FOhN3FdY36f mb0SEVJxFbksJFuRSPZ/GfIObrd7hrCzYcT8Dvpc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liu Xiang , Paul Burton , linux-mips@vger.kernel.org Subject: [PATCH 4.14 037/135] MIPS: irq: Allocate accurate order pages for irq stack Date: Tue, 12 Mar 2019 10:08:04 -0700 Message-Id: <20190312170344.506796683@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190312170341.127810985@linuxfoundation.org> References: <20190312170341.127810985@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Liu Xiang commit 72faa7a773ca59336f3c889e878de81445c5a85c upstream. The irq_pages is the number of pages for irq stack, but not the order which is needed by __get_free_pages(). We can use get_order() to calculate the accurate order. Signed-off-by: Liu Xiang Signed-off-by: Paul Burton Fixes: fe8bd18ffea5 ("MIPS: Introduce irq_stack") Cc: linux-mips@vger.kernel.org Cc: stable@vger.kernel.org # v4.11+ Signed-off-by: Greg Kroah-Hartman --- arch/mips/kernel/irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/arch/mips/kernel/irq.c +++ b/arch/mips/kernel/irq.c @@ -52,6 +52,7 @@ asmlinkage void spurious_interrupt(void) void __init init_IRQ(void) { int i; + unsigned int order = get_order(IRQ_STACK_SIZE); for (i = 0; i < NR_IRQS; i++) irq_set_noprobe(i); @@ -62,8 +63,7 @@ void __init init_IRQ(void) arch_init_irq(); for_each_possible_cpu(i) { - int irq_pages = IRQ_STACK_SIZE / PAGE_SIZE; - void *s = (void *)__get_free_pages(GFP_KERNEL, irq_pages); + void *s = (void *)__get_free_pages(GFP_KERNEL, order); irq_stack[i] = s; pr_debug("CPU%d IRQ stack at 0x%p - 0x%p\n", i,