From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBE16C43381 for ; Tue, 12 Mar 2019 17:33:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ABE962087C for ; Tue, 12 Mar 2019 17:33:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552412029; bh=6h4IXXwaMnfcZ4ZkcyWMcKCQdVka+CNOlzFNygyDESQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YAn0de/0SS5oxnTrcBtILCyA5dsxVMPINSj6iBvzLha2ssb2USpwcsKoHf6efGMPD hdvP6/RI+ySWiv4sYeZ2cACQxTlL4mEAzHNOwbUvmnKr/XBpcxj0ThwlZAlIHeAKdU K6pXZgVt2AfWoZAd8PHLDsbwKhNifP7Yn8blPuvs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729686AbfCLRds (ORCPT ); Tue, 12 Mar 2019 13:33:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:59970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729378AbfCLRQ6 (ORCPT ); Tue, 12 Mar 2019 13:16:58 -0400 Received: from localhost (unknown [104.133.8.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B32A5217D4; Tue, 12 Mar 2019 17:16:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552411017; bh=6h4IXXwaMnfcZ4ZkcyWMcKCQdVka+CNOlzFNygyDESQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AG4PSL8Oo78P1YoucaiOZjYuMaRc0VcsUZwNfxuKjMAbTRcjdhtKZx09hCEUDtlJV xkl7KZ6iQ0CBdJARlpobpScW5KCGMm6Ut104hyVkX4CUGzHQjg0RyCbGxtiSEXSWDb 0+lkkMYwmtowxS+sbnAKcx2Ha2xfQAz5jSQYNkvE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jan Kiszka , Ulf Hansson , Wei Xu Subject: [PATCH 4.14 124/135] arm64: dts: hikey: Give wifi some time after power-on Date: Tue, 12 Mar 2019 10:09:31 -0700 Message-Id: <20190312170352.573286911@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190312170341.127810985@linuxfoundation.org> References: <20190312170341.127810985@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jan Kiszka commit 83b944174ad79825ae84a47af1a0354485b24602 upstream. Somewhere along recent changes to power control of the wl1835, power-on became very unreliable on the hikey, failing like this: wl1271_sdio: probe of mmc2:0001:1 failed with error -16 wl1271_sdio: probe of mmc2:0001:2 failed with error -16 After playing with some dt parameters and comparing to other users of this chip, it turned out we need some power-on delay to make things stable again. In contrast to those other users which define 200 ms, the hikey would already be happy with 1 ms. Still, we use the safer 10 ms, like on the Ultra96. Fixes: ea452678734e ("arm64: dts: hikey: Fix WiFi support") Cc: #4.12+ Signed-off-by: Jan Kiszka Acked-by: Ulf Hansson Signed-off-by: Wei Xu Signed-off-by: Greg Kroah-Hartman --- arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + 1 file changed, 1 insertion(+) --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts @@ -118,6 +118,7 @@ reset-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>; clocks = <&pmic>; clock-names = "ext_clock"; + post-power-on-delay-ms = <10>; power-off-delay-us = <10>; };