From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5CCEC43381 for ; Wed, 13 Mar 2019 17:52:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81F5F20854 for ; Wed, 13 Mar 2019 17:52:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726442AbfCMRwL (ORCPT ); Wed, 13 Mar 2019 13:52:11 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:36068 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbfCMRwL (ORCPT ); Wed, 13 Mar 2019 13:52:11 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EC76E14D09E12; Wed, 13 Mar 2019 10:52:09 -0700 (PDT) Date: Wed, 13 Mar 2019 10:52:07 -0700 (PDT) Message-Id: <20190313.105207.1428262813866246164.davem@davemloft.net> To: saeedb@amazon.com Cc: netdev@vger.kernel.org, dwmw@amazon.co.uk, zorik@amazon.com, matua@amazon.com, msw@amazon.com, aliguori@amazon.com, nafea@amazon.com, gtzalik@amazon.com, netanel@amazon.com, alisaidi@amazon.com, akiyano@amazon.com Subject: Re: [PATCH V1 net 0/2] net: ena: race condition bug fix and version update From: David Miller In-Reply-To: <1552481974151.81058@amazon.com> References: <1549905464-13758-1-git-send-email-akiyano@amazon.com> <20190212.110632.499796234007955726.davem@davemloft.net> <1552481974151.81058@amazon.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 13 Mar 2019 10:52:10 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Bshara, Saeed" Date: Wed, 13 Mar 2019 12:59:34 +0000 > sorry for the late response. I agree that with stable versions the > driver version is not good indication for which exact code is > running. however, we have many users that port the latest ena > driver as-is from kernel sources into their older kernels, mainly to > pull new ENA features (e.g. low latency queues). for those cases, > the driver version helps us to identify the driver's code, so in > practice this just works fine. I will try one more time. If I push fix X for the ENA driver to -stable and that bumps the version number, all of the features associated with that version number are not present in the -stable backport. It does NOT work.