From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bhagyashri Dighole <digholebhagyashri@gmail.com>
Cc: Outreachy <outreachy-kernel@googlegroups.com>
Subject: Re: [PATCH] staging: speakup: Remove unused variable.
Date: Wed, 13 Mar 2019 12:31:57 -0700 [thread overview]
Message-ID: <20190313193157.GA28479@kroah.com> (raw)
In-Reply-To: <1552501395-12308-1-git-send-email-digholebhagyashri@gmail.com>
On Wed, Mar 13, 2019 at 11:53:15PM +0530, Bhagyashri Dighole wrote:
> Remove unused variable which is used to store return value,
> Detected by Coccinelle semantic patch ret.cocci.
>
> Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
> ---
> drivers/staging/speakup/i18n.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index ee240d3..a748eb8 100644
> --- a/drivers/staging/speakup/i18n.c
> +++ b/drivers/staging/speakup/i18n.c
> @@ -470,8 +470,7 @@ static char *find_specifier_end(char *input)
> input++; /* Advance over %. */
> input = skip_flags(input);
> input = skip_width(input);
> - input = skip_conversion(input);
> - return input;
> + return skip_conversion(input);
This same patch just got rejected a few days ago :(
Please see the mailing list for the details.
greg k-h
next prev parent reply other threads:[~2019-03-13 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 18:23 [PATCH] staging: speakup: Remove unused variable Bhagyashri Dighole
2019-03-13 19:31 ` Greg Kroah-Hartman [this message]
2019-03-14 5:33 ` Bhagyashri Dighole
2019-03-13 19:32 ` [Outreachy kernel] " Julia Lawall
2019-03-14 5:37 ` Bhagyashri Dighole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313193157.GA28479@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=digholebhagyashri@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.