From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [PATCH v2 03/16] KVM: PPC: Book3S HV: XIVE: introduce a new capability KVM_CAP_PPC_IRQ_XIVE Date: Thu, 14 Mar 2019 13:29:21 +1100 Message-ID: <20190314022921.GK8211@umbus.fritz.box> References: <20190222112840.25000-1-clg@kaod.org> <20190222112840.25000-4-clg@kaod.org> <20190225043551.GA20501@blackberry> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="45wMVEkw4XUbiYON" Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org To: =?iso-8859-1?Q?C=E9dric?= Le Goater Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org --45wMVEkw4XUbiYON Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 13, 2019 at 09:34:53AM +0100, C=E9dric Le Goater wrote: > On 2/25/19 5:35 AM, Paul Mackerras wrote: > > On Fri, Feb 22, 2019 at 12:28:27PM +0100, C=E9dric Le Goater wrote: > >> The user interface exposes a new capability to let QEMU connect the > >> vCPU to the XIVE KVM device if required. The capability is only > >> advertised on a PowerNV Hypervisor as support for nested guests > >> (pseries KVM Hypervisor) is not yet available. > >=20 > > If a bisection happened to land on this commit, we would have KVM > > saying it had the ability to support guests using XIVE natively, but > > it wouldn't actually work since we don't have all the code that is in > > the following patches. >=20 > OK. I didn't think migration was a must-have for bisection. I will move > the enablement at end. Any temporary feature regression potentially breaks bisection, because you don't know what we'll want to bisect for. Obviously we're never going to get that perfectly right, but that doesn't mean we shouldn't try when we do see the problem in advance. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --45wMVEkw4XUbiYON Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAlyJvIEACgkQbDjKyiDZ s5K/fA/9HVXwiMV7ZGg/YTkKCWDnhXC9X7k/RXhZS01U8jk0iSYIGRfExw6cGcwU ZxZt2ENgHXl8dtUCcBf6WGBtX+jsBLCmG3Bb8wBr69UotKNdyqI4ob1AKfxw+/uk cU2fuLl74Jch163M/82O2+jcQJu+HW8ou7med38L34fBi1Z9ezkVFlWkvGHWS0MN Ly/DqRf2TZjJhLDXqsQEf+Zl2CV4450ALa4+2TV2Qi/QuOkODSC3wnU525Ujao50 Xglc7fAQJ/wCgc6cGQCC0A8EVkfTqBovPLuBbvw2ZGSDLuVFZez6lYV1e1Q+h/q+ keWw/dN+f5ZJBstWWUewL/ZSXYrd+XKwBI8Qz/oXZ3eU3mTPh9bcKre1cjSTzp8r bXkpKo4pBxy446wuFekqnYXm4suBlGamdcPgKxtzLH9wlDbWBPiFL2aFCf6/Br9e 30FNjpOirmID8sCIQcaV+EkA5LlVZjMHYU9Ijv3DISVsGyUFZ7wxc3ruQNj4agFH 2bYnWsM1LXByuh7m6uu6/yOPLIRZapMBecAES2tBZ9a/mjVDOFbcT2cN/B5iTAJj +Nn+6WhbuWI3th0OQffL81LwSMawPp9EyG+aC60swlCdXzr8PuIXnrp29zVRJDs1 Dohadfa3i0lC7bn/PHoXsjsedJ7cp/UvB5ecYijsX5HX6DJyOyY= =pWKO -----END PGP SIGNATURE----- --45wMVEkw4XUbiYON-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Date: Thu, 14 Mar 2019 02:29:21 +0000 Subject: Re: [PATCH v2 03/16] KVM: PPC: Book3S HV: XIVE: introduce a new capability KVM_CAP_PPC_IRQ_XIVE Message-Id: <20190314022921.GK8211@umbus.fritz.box> MIME-Version: 1 Content-Type: multipart/mixed; boundary="45wMVEkw4XUbiYON" List-Id: References: <20190222112840.25000-1-clg@kaod.org> <20190222112840.25000-4-clg@kaod.org> <20190225043551.GA20501@blackberry> In-Reply-To: To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org --45wMVEkw4XUbiYON Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 13, 2019 at 09:34:53AM +0100, C=E9dric Le Goater wrote: > On 2/25/19 5:35 AM, Paul Mackerras wrote: > > On Fri, Feb 22, 2019 at 12:28:27PM +0100, C=E9dric Le Goater wrote: > >> The user interface exposes a new capability to let QEMU connect the > >> vCPU to the XIVE KVM device if required. The capability is only > >> advertised on a PowerNV Hypervisor as support for nested guests > >> (pseries KVM Hypervisor) is not yet available. > >=20 > > If a bisection happened to land on this commit, we would have KVM > > saying it had the ability to support guests using XIVE natively, but > > it wouldn't actually work since we don't have all the code that is in > > the following patches. >=20 > OK. I didn't think migration was a must-have for bisection. I will move > the enablement at end. Any temporary feature regression potentially breaks bisection, because you don't know what we'll want to bisect for. Obviously we're never going to get that perfectly right, but that doesn't mean we shouldn't try when we do see the problem in advance. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --45wMVEkw4XUbiYON Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAlyJvIEACgkQbDjKyiDZ s5K/fA/9HVXwiMV7ZGg/YTkKCWDnhXC9X7k/RXhZS01U8jk0iSYIGRfExw6cGcwU ZxZt2ENgHXl8dtUCcBf6WGBtX+jsBLCmG3Bb8wBr69UotKNdyqI4ob1AKfxw+/uk cU2fuLl74Jch163M/82O2+jcQJu+HW8ou7med38L34fBi1Z9ezkVFlWkvGHWS0MN Ly/DqRf2TZjJhLDXqsQEf+Zl2CV4450ALa4+2TV2Qi/QuOkODSC3wnU525Ujao50 Xglc7fAQJ/wCgc6cGQCC0A8EVkfTqBovPLuBbvw2ZGSDLuVFZez6lYV1e1Q+h/q+ keWw/dN+f5ZJBstWWUewL/ZSXYrd+XKwBI8Qz/oXZ3eU3mTPh9bcKre1cjSTzp8r bXkpKo4pBxy446wuFekqnYXm4suBlGamdcPgKxtzLH9wlDbWBPiFL2aFCf6/Br9e 30FNjpOirmID8sCIQcaV+EkA5LlVZjMHYU9Ijv3DISVsGyUFZ7wxc3ruQNj4agFH 2bYnWsM1LXByuh7m6uu6/yOPLIRZapMBecAES2tBZ9a/mjVDOFbcT2cN/B5iTAJj +Nn+6WhbuWI3th0OQffL81LwSMawPp9EyG+aC60swlCdXzr8PuIXnrp29zVRJDs1 Dohadfa3i0lC7bn/PHoXsjsedJ7cp/UvB5ecYijsX5HX6DJyOyY= =pWKO -----END PGP SIGNATURE----- --45wMVEkw4XUbiYON--