[PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402

[PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402

[Bruno Wolff III]

It looks like net/netfilter/nf_nat_core.h isn't needed any more and things
seemed to work without it.
---
 src/compat/compat.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/compat/compat.h b/src/compat/compat.h
index 7a61e4c1a5cd..2dcdbaeb0ad6 100644
--- a/src/compat/compat.h
+++ b/src/compat/compat.h
@@ -792,7 +792,9 @@ struct __kernel_timespec {
 #include <net/ipv6.h>
 #include <net/icmp.h>
 #include <net/netfilter/nf_conntrack.h>
+#if LINUX_VERSION_CODE < KERNEL_VERSION(5, 1, 0)
 #include <net/netfilter/nf_nat_core.h>
+#endif
 static inline void new_icmp_send(struct sk_buff *skb_in, int type, int code, __be32 info)
 {
 	enum ip_conntrack_info ctinfo;
-- 
2.21.0

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: [PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402

[Bruno Wolff III]

Sorry about the duplicates. I git confused trying to use git email-send.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: [PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402

[Aleksa Sarai]

[-- Attachment #1.1: Type: text/plain, Size: 1144 bytes --]

On 2019-03-14, Bruno Wolff III <bruno@wolff.to> wrote:
> Sorry about the duplicates. I git confused trying to use git email-send.

For future reference, you want to send a patch series. The way I do it
is I first generate all of the patches:

  % git format-patch <base-commit>

Which will then generate NNNN-patch_description.patch files. Modify
these to your heart's content (you can also generate a cover page with
--cover-letter to git format-patch, or a version number with -v).

Then, you can send them all *as one series* by doing:

  % git send-email --no-chain-reply-to --no-format-patch \
                   --to=<to-list> --cc=<cc-list> \
                   *.patch

(This makes them all one thread so it's far more obvious which patches
go together -- since it looks like you were sending multiple patches
separately, which causes confusion for folks reading them.)

You're also missing a Signed-off-by:, but I'm not sure if WireGuard
contributions require those (you can add them with `git commit -s`).

-- 
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 148 bytes --]

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: [PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402

[Bruno Wolff III]

On Thu, Mar 14, 2019 at 18:10:24 +1100,
  Aleksa Sarai <cyphar@cyphar.com> wrote:
>
>For future reference, you want to send a patch series. The way I do it
>is I first generate all of the patches:

Thanks. That isn't what I was trying to do here, but something I might 
do in the future. Here the two patches were separate, nit part of the 
series. I got confused in that I thought the mail wasn't getting set 
and tried a few different varients of the --smtp-server= option, most 
of which actually worked.

>You're also missing a Signed-off-by:, but I'm not sure if WireGuard
>contributions require those (you can add them with `git commit -s`).

Can you set up your config to do that automatically or are you supposed 
to do that manually for each commit to make sure you really mean it?

In this case, one patch is trivial and the other needs to be reworked, 
so I doubt it matters.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: [PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402

[Luis Ressel]

On Thu, Mar 14, 2019 at 07:41:34AM -0500, Bruno Wolff III wrote:
> On Thu, Mar 14, 2019 at 18:10:24 +1100,
>  Aleksa Sarai <cyphar@cyphar.com> wrote:
> 
> > You're also missing a Signed-off-by:, but I'm not sure if WireGuard
> > contributions require those (you can add them with `git commit -s`).

Yes, it is indeed neccessary to sign off all contributions to wireguard.

> Can you set up your config to do that automatically or are you supposed to
> do that manually for each commit to make sure you really mean it?

Yes and no. There's no way to make git append the s-o-b line to all
commit messages, but if you enable the format.signOff config option,
it will at least add the line when you invoke git format-patch or git
send-email.

Cheers,
Luis
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: [PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402

[Jason A. Donenfeld]

On Thu, Mar 14, 2019 at 12:26 PM Bruno Wolff III <bruno@wolff.to> wrote:
>
> It looks like net/netfilter/nf_nat_core.h isn't needed any more and things
> seemed to work without it.
>
> Signed-off-by: Bruno Wolff III <bruno@wolff.to>

Thanks. Merged here with a slightly different message:
https://git.zx2c4.com/WireGuard/commit/?id=df681f4afe2e8a50cc2c1ee3af27b1f42c070472
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

[PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402

[Bruno Wolff III]

It looks like net/netfilter/nf_nat_core.h isn't needed any more and things
seemed to work without it.

Signed-off-by: Bruno Wolff III <bruno@wolff.to>
---
 src/compat/compat.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/compat/compat.h b/src/compat/compat.h
index 7a61e4c1a5cd..2dcdbaeb0ad6 100644
--- a/src/compat/compat.h
+++ b/src/compat/compat.h
@@ -792,7 +792,9 @@ struct __kernel_timespec {
 #include <net/ipv6.h>
 #include <net/icmp.h>
 #include <net/netfilter/nf_conntrack.h>
+#if LINUX_VERSION_CODE < KERNEL_VERSION(5, 1, 0)
 #include <net/netfilter/nf_nat_core.h>
+#endif
 static inline void new_icmp_send(struct sk_buff *skb_in, int type, int code, __be32 info)
 {
 	enum ip_conntrack_info ctinfo;
-- 
2.21.0

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: [PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402

[Bruno Wolff III]

On Thu, Mar 14, 2019 at 00:14:52 -0500,
  Bruno Wolff III <bruno@wolff.to> wrote:
>It looks like net/netfilter/nf_nat_core.h isn't needed any more and things
>seemed to work without it.

I'll redo this one with a signed off by. Probably late tonight.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

[PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402

[Bruno Wolff III]

It looks like net/netfilter/nf_nat_core.h isn't needed any more and things
seemed to work without it.
---
 src/compat/compat.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/compat/compat.h b/src/compat/compat.h
index 7a61e4c1a5cd..2dcdbaeb0ad6 100644
--- a/src/compat/compat.h
+++ b/src/compat/compat.h
@@ -792,7 +792,9 @@ struct __kernel_timespec {
 #include <net/ipv6.h>
 #include <net/icmp.h>
 #include <net/netfilter/nf_conntrack.h>
+#if LINUX_VERSION_CODE < KERNEL_VERSION(5, 1, 0)
 #include <net/netfilter/nf_nat_core.h>
+#endif
 static inline void new_icmp_send(struct sk_buff *skb_in, int type, int code, __be32 info)
 {
 	enum ip_conntrack_info ctinfo;
-- 
2.21.0

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

[PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402

[Bruno Wolff III]

It looks like net/netfilter/nf_nat_core.h isn't needed any more and things
seemed to work without it.
---
 src/compat/compat.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/compat/compat.h b/src/compat/compat.h
index 7a61e4c1a5cd..2dcdbaeb0ad6 100644
--- a/src/compat/compat.h
+++ b/src/compat/compat.h
@@ -792,7 +792,9 @@ struct __kernel_timespec {
 #include <net/ipv6.h>
 #include <net/icmp.h>
 #include <net/netfilter/nf_conntrack.h>
+#if LINUX_VERSION_CODE < KERNEL_VERSION(5, 1, 0)
 #include <net/netfilter/nf_nat_core.h>
+#endif
 static inline void new_icmp_send(struct sk_buff *skb_in, int type, int code, __be32 info)
 {
 	enum ip_conntrack_info ctinfo;
-- 
2.21.0

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

[PATCH] net/netfilter/nf_nat_core.h was removed by d2c5c103b1337f590b7edf1509a6e294bdf22402

[Bruno Wolff III]

It looks like net/netfilter/nf_nat_core.h isn't needed any more and things
seemed to work without it.
---
 src/compat/compat.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/compat/compat.h b/src/compat/compat.h
index 7a61e4c1a5cd..2dcdbaeb0ad6 100644
--- a/src/compat/compat.h
+++ b/src/compat/compat.h
@@ -792,7 +792,9 @@ struct __kernel_timespec {
 #include <net/ipv6.h>
 #include <net/icmp.h>
 #include <net/netfilter/nf_conntrack.h>
+#if LINUX_VERSION_CODE < KERNEL_VERSION(5, 1, 0)
 #include <net/netfilter/nf_nat_core.h>
+#endif
 static inline void new_icmp_send(struct sk_buff *skb_in, int type, int code, __be32 info)
 {
 	enum ip_conntrack_info ctinfo;
-- 
2.21.0

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard