* [PATCH] power: charger-manager: fix a potential NULL pointer dereference
@ 2019-03-14 6:02 Kangjie Lu
2019-04-05 14:00 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Kangjie Lu @ 2019-03-14 6:02 UTC (permalink / raw)
To: kjlu; +Cc: pakki001, Sebastian Reichel, linux-pm, linux-kernel
In case create_freezable_workqueue fails, the fix return -ENOMEM
to avoid a potential NULL pointer dereference.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
drivers/power/supply/charger-manager.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c
index 38be91f21cc4..d29c4f338157 100644
--- a/drivers/power/supply/charger-manager.c
+++ b/drivers/power/supply/charger-manager.c
@@ -1987,6 +1987,9 @@ static struct platform_driver charger_manager_driver = {
static int __init charger_manager_init(void)
{
cm_wq = create_freezable_workqueue("charger_manager");
+ if (unlikely(!cm_wq))
+ return -ENOMEM;
+
INIT_DELAYED_WORK(&cm_monitor_work, cm_monitor_poller);
return platform_driver_register(&charger_manager_driver);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: charger-manager: fix a potential NULL pointer dereference
2019-03-14 6:02 [PATCH] power: charger-manager: fix a potential NULL pointer dereference Kangjie Lu
@ 2019-04-05 14:00 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2019-04-05 14:00 UTC (permalink / raw)
To: Kangjie Lu; +Cc: pakki001, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]
Hi,
On Thu, Mar 14, 2019 at 01:02:47AM -0500, Kangjie Lu wrote:
> In case create_freezable_workqueue fails, the fix return -ENOMEM
> to avoid a potential NULL pointer dereference.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/charger-manager.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c
> index 38be91f21cc4..d29c4f338157 100644
> --- a/drivers/power/supply/charger-manager.c
> +++ b/drivers/power/supply/charger-manager.c
> @@ -1987,6 +1987,9 @@ static struct platform_driver charger_manager_driver = {
> static int __init charger_manager_init(void)
> {
> cm_wq = create_freezable_workqueue("charger_manager");
> + if (unlikely(!cm_wq))
> + return -ENOMEM;
> +
> INIT_DELAYED_WORK(&cm_monitor_work, cm_monitor_poller);
>
> return platform_driver_register(&charger_manager_driver);
> --
> 2.17.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-05 14:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-14 6:02 [PATCH] power: charger-manager: fix a potential NULL pointer dereference Kangjie Lu
2019-04-05 14:00 ` Sebastian Reichel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.