From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 14 Mar 2019 12:53:47 +0200 From: Heikki Krogerus Subject: Re: [PATCH v2 2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property Message-ID: <20190314105347.GC7752@kuha.fi.intel.com> References: <1552552775-51667-1-git-send-email-biju.das@bp.renesas.com> <1552552775-51667-3-git-send-email-biju.das@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Biju Das Cc: Yoshihiro Shimoda , Rob Herring , Mark Rutland , Greg Kroah-Hartman , Felipe Balbi , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , Simon Horman , Geert Uytterhoeven , Chris Paterson , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" List-ID: On Thu, Mar 14, 2019 at 10:14:12AM +0000, Biju Das wrote: > Hi Shimoda-San, > > Thanks for the feedback. > > > Subject: RE: [PATCH v2 2/7] dt-bindings: usb: renesas_usb3: add usb-role- > > switch property > > > > Hi Biju-san, > > > > > From: Biju Das, Sent: Thursday, March 14, 2019 5:40 PM > > > > > > Add support for renesas_usb3 to support dual role switch using usb > > > role switch class framework. > > > > > > Signed-off-by: Biju Das > > > --- > > > V1-->V2 > > > * Added usb-role-switch-property > > > * Updated the example with usb-role-switch property. > > > --- > > > .../devicetree/bindings/usb/renesas_usb3.txt | 22 > > ++++++++++++++++++++++ > > > 1 file changed, 22 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > index 35039e7..eecaf4c 100644 > > > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > @@ -22,6 +22,7 @@ Required properties: > > > Optional properties: > > > - phys: phandle + phy specifier pair > > > - phy-names: must be "usb" > > > + - usb-role-switch: use USB role switch to support dual-role switch > > > > I don't think we can add such a property. At least, we have to add "renesas," > > prefix. > > usb_role_switch_get api uses "usb-role-switch" property to get role switch linked with the device. > > HD3SS3220 port controller driver gets role switch handle linked with the device using usb_role_switch_get api. > That is the reason, I have added " usb-role-switch" property here. > > Do you have any other suggestion to get usb role switch handle? We can still change the API. Can we use the compatible for this? thanks, -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A4BAC43381 for ; Thu, 14 Mar 2019 10:58:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D08F21019 for ; Thu, 14 Mar 2019 10:58:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727430AbfCNK6z (ORCPT ); Thu, 14 Mar 2019 06:58:55 -0400 Received: from mga02.intel.com ([134.134.136.20]:37771 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726629AbfCNK6z (ORCPT ); Thu, 14 Mar 2019 06:58:55 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2019 03:53:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,478,1544515200"; d="scan'208";a="154950383" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 14 Mar 2019 03:53:47 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Thu, 14 Mar 2019 12:53:47 +0200 Date: Thu, 14 Mar 2019 12:53:47 +0200 From: Heikki Krogerus To: Biju Das Cc: Yoshihiro Shimoda , Rob Herring , Mark Rutland , Greg Kroah-Hartman , Felipe Balbi , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , Simon Horman , Geert Uytterhoeven , Chris Paterson , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" Subject: Re: [PATCH v2 2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property Message-ID: <20190314105347.GC7752@kuha.fi.intel.com> References: <1552552775-51667-1-git-send-email-biju.das@bp.renesas.com> <1552552775-51667-3-git-send-email-biju.das@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Thu, Mar 14, 2019 at 10:14:12AM +0000, Biju Das wrote: > Hi Shimoda-San, > > Thanks for the feedback. > > > Subject: RE: [PATCH v2 2/7] dt-bindings: usb: renesas_usb3: add usb-role- > > switch property > > > > Hi Biju-san, > > > > > From: Biju Das, Sent: Thursday, March 14, 2019 5:40 PM > > > > > > Add support for renesas_usb3 to support dual role switch using usb > > > role switch class framework. > > > > > > Signed-off-by: Biju Das > > > --- > > > V1-->V2 > > > * Added usb-role-switch-property > > > * Updated the example with usb-role-switch property. > > > --- > > > .../devicetree/bindings/usb/renesas_usb3.txt | 22 > > ++++++++++++++++++++++ > > > 1 file changed, 22 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > index 35039e7..eecaf4c 100644 > > > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > @@ -22,6 +22,7 @@ Required properties: > > > Optional properties: > > > - phys: phandle + phy specifier pair > > > - phy-names: must be "usb" > > > + - usb-role-switch: use USB role switch to support dual-role switch > > > > I don't think we can add such a property. At least, we have to add "renesas," > > prefix. > > usb_role_switch_get api uses "usb-role-switch" property to get role switch linked with the device. > > HD3SS3220 port controller driver gets role switch handle linked with the device using usb_role_switch_get api. > That is the reason, I have added " usb-role-switch" property here. > > Do you have any other suggestion to get usb role switch handle? We can still change the API. Can we use the compatible for this? thanks, -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property From: Heikki Krogerus Message-Id: <20190314105347.GC7752@kuha.fi.intel.com> Date: Thu, 14 Mar 2019 12:53:47 +0200 To: Biju Das Cc: Yoshihiro Shimoda , Rob Herring , Mark Rutland , Greg Kroah-Hartman , Felipe Balbi , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , Simon Horman , Geert Uytterhoeven , Chris Paterson , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" List-ID: T24gVGh1LCBNYXIgMTQsIDIwMTkgYXQgMTA6MTQ6MTJBTSArMDAwMCwgQmlqdSBEYXMgd3JvdGU6 Cj4gSGkgU2hpbW9kYS1TYW4sCj4gCj4gVGhhbmtzIGZvciB0aGUgZmVlZGJhY2suCj4gCj4gPiBT dWJqZWN0OiBSRTogW1BBVENIIHYyIDIvN10gZHQtYmluZGluZ3M6IHVzYjogcmVuZXNhc191c2Iz OiBhZGQgdXNiLXJvbGUtCj4gPiBzd2l0Y2ggcHJvcGVydHkKPiA+IAo+ID4gSGkgQmlqdS1zYW4s Cj4gPiAKPiA+ID4gRnJvbTogQmlqdSBEYXMsIFNlbnQ6IFRodXJzZGF5LCBNYXJjaCAxNCwgMjAx OSA1OjQwIFBNCj4gPiA+Cj4gPiA+IEFkZCBzdXBwb3J0IGZvciByZW5lc2FzX3VzYjMgdG8gc3Vw cG9ydCBkdWFsIHJvbGUgc3dpdGNoIHVzaW5nIHVzYgo+ID4gPiByb2xlIHN3aXRjaCBjbGFzcyBm cmFtZXdvcmsuCj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IEJpanUgRGFzIDxiaWp1LmRhc0Bi cC5yZW5lc2FzLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBWMS0tPlYyCj4gPiA+ICAgKiBBZGRlZCB1 c2Itcm9sZS1zd2l0Y2gtcHJvcGVydHkKPiA+ID4gICAqIFVwZGF0ZWQgdGhlIGV4YW1wbGUgd2l0 aCB1c2Itcm9sZS1zd2l0Y2ggcHJvcGVydHkuCj4gPiA+IC0tLQo+ID4gPiAgLi4uL2RldmljZXRy ZWUvYmluZGluZ3MvdXNiL3JlbmVzYXNfdXNiMy50eHQgICAgICAgfCAyMgo+ID4gKysrKysrKysr KysrKysrKysrKysrKwo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKykKPiA+ ID4KPiA+ID4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91 c2IvcmVuZXNhc191c2IzLnR4dAo+ID4gPiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy91c2IvcmVuZXNhc191c2IzLnR4dAo+ID4gPiBpbmRleCAzNTAzOWU3Li5lZWNhZjRjIDEw MDY0NAo+ID4gPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL3Jl bmVzYXNfdXNiMy50eHQKPiA+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL3VzYi9yZW5lc2FzX3VzYjMudHh0Cj4gPiA+IEBAIC0yMiw2ICsyMiw3IEBAIFJlcXVpcmVk IHByb3BlcnRpZXM6Cj4gPiA+ICBPcHRpb25hbCBwcm9wZXJ0aWVzOgo+ID4gPiAgICAtIHBoeXM6 IHBoYW5kbGUgKyBwaHkgc3BlY2lmaWVyIHBhaXIKPiA+ID4gICAgLSBwaHktbmFtZXM6IG11c3Qg YmUgInVzYiIKPiA+ID4gKyAgLSB1c2Itcm9sZS1zd2l0Y2g6IHVzZSBVU0Igcm9sZSBzd2l0Y2gg dG8gc3VwcG9ydCBkdWFsLXJvbGUgc3dpdGNoCj4gPiAKPiA+IEkgZG9uJ3QgdGhpbmsgd2UgY2Fu IGFkZCBzdWNoIGEgcHJvcGVydHkuIEF0IGxlYXN0LCB3ZSBoYXZlIHRvIGFkZCAicmVuZXNhcywi Cj4gPiBwcmVmaXguCj4gCj4gdXNiX3JvbGVfc3dpdGNoX2dldCAgIGFwaSB1c2VzICAidXNiLXJv bGUtc3dpdGNoIiAgcHJvcGVydHkgdG8gZ2V0IHJvbGUgc3dpdGNoIGxpbmtlZCB3aXRoIHRoZSBk ZXZpY2UuCj4gCj4gSEQzU1MzMjIwIHBvcnQgY29udHJvbGxlciBkcml2ZXIgZ2V0cyByb2xlIHN3 aXRjaCBoYW5kbGUgbGlua2VkIHdpdGggdGhlIGRldmljZSB1c2luZyB1c2Jfcm9sZV9zd2l0Y2hf Z2V0ICBhcGkuICAKPiBUaGF0IGlzIHRoZSByZWFzb24sIEkgaGF2ZSBhZGRlZCAiIHVzYi1yb2xl LXN3aXRjaCIgcHJvcGVydHkgaGVyZS4KPiAKPiBEbyB5b3UgaGF2ZSBhbnkgb3RoZXIgc3VnZ2Vz dGlvbiB0byBnZXQgdXNiIHJvbGUgc3dpdGNoIGhhbmRsZT8KCldlIGNhbiBzdGlsbCBjaGFuZ2Ug dGhlIEFQSS4gQ2FuIHdlIHVzZSB0aGUgY29tcGF0aWJsZSBmb3IgdGhpcz8KCgp0aGFua3MsCg==