From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 14 Mar 2019 11:35:34 -0400 Subject: [U-Boot] [PATCH] Revert "fs: fat: support write with non-zero offset" In-Reply-To: <20190314092039.4183-1-faiz_abbas@ti.com> References: <20190314092039.4183-1-faiz_abbas@ti.com> Message-ID: <20190314153534.GP8732@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, Mar 14, 2019 at 02:50:39PM +0530, Faiz Abbas wrote: > This reverts commit cb8af8af5ba03ae8e0a7315b66bfcc46d5c55627. > > fatwrites after this patch corrupt images. A fatwrite followed by a > fatload and compare yields different data. > > Reproduce it with: > =>fatwrite mmc 0 0x82000000 test_32M 0x2000000; > =>fatload mmc 0 0x84000000 test_32M; > =>cmp.b 82000000 84000000 0x2000000 > > Result: > byte at 0x821260b2 (0xbf) != byte at 0x841260b2 (0xbd) > Total of 1204402 byte(s) were the same > > Updating images in the SD card with fatwrite corrupts the images in the > board and it no longer boots. Revert this commit until a more stable > solution is found. > > Signed-off-by: Faiz Abbas This removes offset writing support, so you need to revert the tests too. You can see this with 'make tests' and make sure that all of test/py/tests/test_fs/test_ext.py (yes, ugh, needs a better name) runs and succeeds. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: