Re: [Outreachy kernel] [PATCH] Staging: rtl872bs: Remove local variables in functions

[Madhumthia Prabakaran <madhumithabiw@gmail.com>]

On Thu, Mar 14, 2019 at 07:15:45AM +0100, Julia Lawall wrote:
> > The change need to be made in two files -  drivers/staging/rtl8723bs/core/rtw_cmd.c
> > 1) drivers/staging/rtl8723bs/core/rtw_cmd.c
> > 2) drivers/staging/rtl8723bs/include/cmd_osdep.h (to remove extern from function prototypes)
> 
> If you change the .c file in the first patch and the .h file in the second
> patch, then the first patch will break the build.  On the other hand, if
> you change the .h file in the first patch that will not change anything,
> because no one cares about the declaration.
> 
> Still I think it would make sense to do the whole thing at once, in a
> single patch.  A function definition and its prototype go together, so if
> you change both it would make the most sense to do the whole thing at once.

Will fix as a patch. 
> 
> > So that's reason why I asked whether it has to be send as patch series or I can submit it as individual patches.
> 
> Not individual patches.  Either a series with the .h file first and then the
> change in the .c file, or a single patch.
> 
> 
> > In rtw_cmd.c, along with the change already made, I will change the
> > return expression. i.e.
> 
> Your message got broken off here, But you don't want the change already
> made.  There is no point to have a function that has the only statement to
> call another function.The two functions that you changed should just be
> dropped completely.

I will drop the patch. But the function is calling same function with
different return type. I never encountered this type of function in C. 
This is function overloading in C++. Based on Brian and Dennis, only
change I can make on that function I can edit the return type with 
return (u32) _rtw_init_cmd_priv(pcmdpriv).
Am I thinking straight for fixing it? Need for suggestions?

> 
> Again, please put your replies inline after the text that you are
> replying to and not at the very end of the message, after the list
> management information.
> 
> julia
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1903140708190.2814%40hadrien.
> For more options, visit https://groups.google.com/d/optout.