From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D0C3C43381 for ; Thu, 14 Mar 2019 23:39:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BEE7F2085A for ; Thu, 14 Mar 2019 23:39:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="WAF7XpDD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727248AbfCNXjW (ORCPT ); Thu, 14 Mar 2019 19:39:22 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:39136 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726616AbfCNXjW (ORCPT ); Thu, 14 Mar 2019 19:39:22 -0400 Received: by mail-qt1-f193.google.com with SMTP id t28so8203237qte.6 for ; Thu, 14 Mar 2019 16:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=b3605XtICGb1Ij+TXmnlqb8HxckWmEEbYvPay/Dh1Os=; b=WAF7XpDDQhssVO7g3V2ZzXK5ldpC+mwJmMcbr6aZtNC79/HCHDhppsbIviRk89m6Tw Ek6seuGbs88HPGkdhJPvlHm/Z5EhZZi7IZZBI87Fr7haz7KDOPR02vJRggqjDC62f7H9 5u6VzHGwvwH9MKn1DtHnHtAhABepiPp7JO0q+okGcItAkBXs1dMlebMjUfTbCN6VddU7 FZXegUiwqWN8r1geAr0BGbXrImEnfoC4ioixsnMfnHEH+NSlvghEVjULfLG7FwjHxAzo LVlBMVuO9u6/Bs7vWSCkCvwiL7syD8CLyx4/LQkFzgwWziz2a0u9ZfO9W8fy4kVELFgm c8JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=b3605XtICGb1Ij+TXmnlqb8HxckWmEEbYvPay/Dh1Os=; b=cruqEeVV1X2kutStxohOlzEPwomfeIJAQCRk/7NuyKPydlTtn+eooPo/HogE4SAiGV LES82ZDXorInB2MSxVn44DDLKwDHlKO/ksKMlvgKINYRvXWuLQy7t7FROnMNJLeKzOcr XqSuWx+taAqIIhEBJfZEoBwtVl3+lPIOAxZwKUhs54hECFRdgRmISbBx5ueazL7/GiFy 7qQOTFvIcBjIsOO61XXSk8WV5KlP6YWOserjSRH7lAL4qNV/V2wepZ4vK2kPoNFVP8P+ 4u2R//aMQFeOCL7okMK8hDD2ZW1YsGSD8aGUdirMPzfNyweCSfTAeSm8BdsSt8J9T14h O8fw== X-Gm-Message-State: APjAAAUtvRSCf7C4sFNKLel0PbLROHaBuFEjZj2PfcEhPxO+NNqj7pDT e0Zn4BgFf4fwsQx+Olw0af9cCMHYhlk= X-Google-Smtp-Source: APXvYqwRXZWTvBowR5xfqZ7dmronOGbN4ybH5sVNYXaCW3j2lvthc7VKnpwFNu+vrxyTotom2qelcQ== X-Received: by 2002:a0c:be91:: with SMTP id n17mr415608qvi.32.1552606760948; Thu, 14 Mar 2019 16:39:20 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id l28sm250137qtl.53.2019.03.14.16.39.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Mar 2019 16:39:20 -0700 (PDT) Date: Thu, 14 Mar 2019 16:39:15 -0700 From: Jakub Kicinski To: Parav Pandit Cc: Jiri Pirko , "davem@davemloft.net" , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Message-ID: <20190314163915.24fd2481@cakuba.netronome.com> In-Reply-To: References: <20190308145421.GA2888@nanopsycho.orion> <20190308110943.2ee42bc0@cakuba.hsd1.ca.comcast.net> <20190311085204.GA2194@nanopsycho> <20190311191054.36b801d6@cakuba.hsd1.ca.comcast.net> <20190312140239.GA2455@nanopsycho> <20190312135628.5250135b@cakuba.hsd1.ca.comcast.net> <20190313060701.GB2384@nanopsycho.orion> <20190313091731.76129ece@cakuba.attlocal.net> <20190313162243.GB2270@nanopsycho> <20190313095555.0f4f92ca@cakuba.attlocal.net> <20190314073840.GA3034@nanopsycho> <20190314150945.031d1b08@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 14 Mar 2019 22:35:36 +0000, Parav Pandit wrote: > > > Then instances of flavour pci_vf are going to appear in the same > > > devlink instance. Those are the switch ports: > > > pci/0000:05:00.0/10002: type eth netdev enp5s0npf0pf0s0 > > > flavour pci_vf pf 0 vf 0 > > > switch_id 00154d130d2f peer pci/0000:05:10.1/0 > > > pci/0000:05:00.0/10003: type eth netdev enp5s0npf0pf0s0 > > > flavour pci_vf pf 0 vf 0 subport 1 > > > switch_id 00154d130d2f peer pci/0000:05:10.1/1 > > > > > > With that, peers are going to appear too, and those are the actual > > > VF/VF > > > subport: > > > pci/0000:05:10.1/0: type eth netdev ??? flavour pci_vf_host > > > peer pci/0000:05:00.0/10002 > > > pci/0000:05:10.1/1: type eth netdev ??? flavour pci_vf_host > > > peer pci/0000:05:00.0/10003 > > > > > > Later you can push this VF along with all subports to VM. So in VM, > > > you are going to see the VF like this: > > > $ devlink dev > > > pci/0000:00:08.0 > > > $ devlink port > > > pci/0000:00:08.0/0: type eth netdev ??? flavour pci_vf_host > > > pci/0000:00:08.0/1: type eth netdev ??? flavour pci_vf_host > > > > > > And back to your question of how are they connected in eswitch. > > > That is totally up to the original user John who did the creation. > > > He is in charge of the eswitch on baremetal, he would configure the > > > forwarding however he likes. > > > > Ack, so I think you're saying VM has to communicate to the cloud > > environment to have this provisioned using some service API, not a kernel > > API. That's what I wanted to confirm. > > > > I don't see any benefit to having the "host ports" under devlink, as such I > > think it's a matter of preference. > > We need 'host ports' to configure parameters of this > host port which is not exposed by the rep-netdev. > Such as mac address. Please look at the quote of what Jiri wrote above - the host port gets passed to the VM, you can't use it as a handle to set the MAC. The way to set the MAC remains: # devlink port set pci/0000:05:00.0/10002 peer mac_addr 00:11:22:33:44:55 (using the port ids from above)