From: kbuild test robot <lkp@intel.com>
To: Leandro Dorileo <leandro.maciel.dorileo@intel.com>
Cc: kbuild-all@01.org, netdev@vger.kernel.org,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S . Miller" <davem@davemloft.net>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>
Subject: Re: [PATCH net 2/2] net/sched: cbs: fix port_rate miscalculation
Date: Fri, 15 Mar 2019 00:12:56 +0800 [thread overview]
Message-ID: <201903150014.UPpTiEQc%lkp@intel.com> (raw)
In-Reply-To: <20190313224312.6735-3-leandro.maciel.dorileo@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2634 bytes --]
Hi Leandro,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net/master]
url: https://github.com/0day-ci/linux/commits/Leandro-Dorileo/net-sched-taprio-fix-picos_per_byte-miscalculation/20190314-231519
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=alpha
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:7:0,
from include/linux/kernel.h:14,
from include/linux/list.h:9,
from include/linux/module.h:9,
from net/sched/sch_cbs.c:58:
net/sched/sch_cbs.c: In function 'cbs_set_port_rate':
include/linux/kern_levels.h:5:18: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 3 has type 'long int' [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
#define KERN_INFO KERN_SOH "6" /* informational */
^~~~~~~~
include/linux/printk.h:310:9: note: in expansion of macro 'KERN_INFO'
printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~
>> net/sched/sch_cbs.c:318:2: note: in expansion of macro 'pr_info'
pr_info("cbs: set %s's port_rate to: %llu, linkspeed: %d\n",
^~~~~~~
net/sched/sch_cbs.c:318:42: note: format string is defined here
pr_info("cbs: set %s's port_rate to: %llu, linkspeed: %d\n",
~~~^
%lu
vim +/pr_info +318 net/sched/sch_cbs.c
307
308 static void cbs_set_port_rate(struct net_device *dev, struct cbs_sched_data *q)
309 {
310 struct ethtool_link_ksettings ecmd;
311 int port_rate = -1;
312
313 if (!__ethtool_get_link_ksettings(dev, &ecmd) &&
314 ecmd.base.speed != SPEED_UNKNOWN)
315 port_rate = ecmd.base.speed * 1000 * BYTES_PER_KBIT;
316
317 atomic64_set(&q->port_rate, port_rate);
> 318 pr_info("cbs: set %s's port_rate to: %llu, linkspeed: %d\n",
319 dev->name, atomic64_read(&q->port_rate), ecmd.base.speed);
320 }
321
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 55551 bytes --]
prev parent reply other threads:[~2019-03-14 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 22:43 [PATCH net 0/2] net/sched: taprio: cbs: Fix using invalid link speed Leandro Dorileo
2019-03-13 22:43 ` [PATCH net 1/2] net/sched: taprio: fix picos_per_byte miscalculation Leandro Dorileo
2019-03-14 16:08 ` kbuild test robot
2019-03-14 16:21 ` kbuild test robot
2019-03-13 22:43 ` [PATCH net 2/2] net/sched: cbs: fix port_rate miscalculation Leandro Dorileo
2019-03-14 16:12 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201903150014.UPpTiEQc%lkp@intel.com \
--to=lkp@intel.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kbuild-all@01.org \
--cc=leandro.maciel.dorileo@intel.com \
--cc=netdev@vger.kernel.org \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.