From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36ED2C43381 for ; Fri, 15 Mar 2019 09:26:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C8262184C for ; Fri, 15 Mar 2019 09:26:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728734AbfCOJ0w (ORCPT ); Fri, 15 Mar 2019 05:26:52 -0400 Received: from mga18.intel.com ([134.134.136.126]:38685 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728695AbfCOJ0v (ORCPT ); Fri, 15 Mar 2019 05:26:51 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2019 02:26:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,481,1544515200"; d="scan'208";a="155290664" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 15 Mar 2019 02:26:45 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 15 Mar 2019 11:26:45 +0200 Date: Fri, 15 Mar 2019 11:26:44 +0200 From: Heikki Krogerus To: Chunfeng Yun Cc: Andy Shevchenko , Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 4/6] usb: roles: add API to get usb_role_switch by node Message-ID: <20190315092644.GG7752@kuha.fi.intel.com> References: <1552635513-2378-1-git-send-email-chunfeng.yun@mediatek.com> <1552635513-2378-5-git-send-email-chunfeng.yun@mediatek.com> <20190315081835.GD7752@kuha.fi.intel.com> <1552641204.10179.133.camel@mhfsdcap03> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1552641204.10179.133.camel@mhfsdcap03> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chunfeng, On Fri, Mar 15, 2019 at 05:13:24PM +0800, Chunfeng Yun wrote: > I encounter a build error when CONFIG_USB_ROLE_SWITCH is not enabled, > > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_role_sw_register': > ./drivers/usb/mtu3/mtu3_dr.c:460: undefined reference to > `usb_role_switch_register' > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_otg_switch_exit': > ./drivers/usb/mtu3/mtu3_dr.c:491: undefined reference to > `usb_role_switch_unregister' So you need to add dependency on USB_ROLE_SWITCH, right? --- a/drivers/usb/mtu3/Kconfig +++ b/drivers/usb/mtu3/Kconfig @@ -43,6 +43,7 @@ config USB_MTU3_DUAL_ROLE bool "Dual Role mode" depends on ((USB=y || USB=USB_MTU3) && (USB_GADGET=y || USB_GADGET=USB_MTU3)) depends on (EXTCON=y || EXTCON=USB_MTU3) + depends on USB_ROLE_SWITCH help This is the default mode of working of MTU3 controller where both host and gadget features are enabled. > the following patch has fixed the issue, but seems not get into kernel, > [v3,08/12] usb: roles: Add usb role switch notifier. > https://patchwork.kernel.org/patch/10836525/ I don't understand how that fixes the problem? That patch will in any case be targeting v5.2. We are in the middle of merge window, so nothing is happening until v5.1-rc1 is tagged. thanks, -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,4/6] usb: roles: add API to get usb_role_switch by node From: Heikki Krogerus Message-Id: <20190315092644.GG7752@kuha.fi.intel.com> Date: Fri, 15 Mar 2019 11:26:44 +0200 To: Chunfeng Yun Cc: Andy Shevchenko , Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Hans de Goede , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-ID: SGkgQ2h1bmZlbmcsCgpPbiBGcmksIE1hciAxNSwgMjAxOSBhdCAwNToxMzoyNFBNICswODAwLCBD aHVuZmVuZyBZdW4gd3JvdGU6Cj4gSSBlbmNvdW50ZXIgYSBidWlsZCBlcnJvciB3aGVuIENPTkZJ R19VU0JfUk9MRV9TV0lUQ0ggaXMgbm90IGVuYWJsZWQsCj4gCj4gZHJpdmVycy91c2IvbXR1My9t dHUzX2RyLm86IEluIGZ1bmN0aW9uIGBzc3VzYl9yb2xlX3N3X3JlZ2lzdGVyJzoKPiAuL2RyaXZl cnMvdXNiL210dTMvbXR1M19kci5jOjQ2MDogdW5kZWZpbmVkIHJlZmVyZW5jZSB0bwo+IGB1c2Jf cm9sZV9zd2l0Y2hfcmVnaXN0ZXInCj4gZHJpdmVycy91c2IvbXR1My9tdHUzX2RyLm86IEluIGZ1 bmN0aW9uIGBzc3VzYl9vdGdfc3dpdGNoX2V4aXQnOgo+IC4vZHJpdmVycy91c2IvbXR1My9tdHUz X2RyLmM6NDkxOiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvCj4gYHVzYl9yb2xlX3N3aXRjaF91bnJl Z2lzdGVyJwoKU28geW91IG5lZWQgdG8gYWRkIGRlcGVuZGVuY3kgb24gVVNCX1JPTEVfU1dJVENI LCByaWdodD8KCgo+IHRoZSBmb2xsb3dpbmcgcGF0Y2ggaGFzIGZpeGVkIHRoZSBpc3N1ZSwgYnV0 IHNlZW1zIG5vdCBnZXQgaW50byBrZXJuZWwsCj4gW3YzLDA4LzEyXSB1c2I6IHJvbGVzOiBBZGQg dXNiIHJvbGUgc3dpdGNoIG5vdGlmaWVyLgo+IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcv cGF0Y2gvMTA4MzY1MjUvCgpJIGRvbid0IHVuZGVyc3RhbmQgaG93IHRoYXQgZml4ZXMgdGhlIHBy b2JsZW0/IFRoYXQgcGF0Y2ggd2lsbCBpbiBhbnkKY2FzZSBiZSB0YXJnZXRpbmcgdjUuMi4gV2Ug YXJlIGluIHRoZSBtaWRkbGUgb2YgbWVyZ2Ugd2luZG93LCBzbwpub3RoaW5nIGlzIGhhcHBlbmlu ZyB1bnRpbCB2NS4xLXJjMSBpcyB0YWdnZWQuCgoKdGhhbmtzLAoKLS0tIGEvZHJpdmVycy91c2Iv bXR1My9LY29uZmlnCisrKyBiL2RyaXZlcnMvdXNiL210dTMvS2NvbmZpZwpAQCAtNDMsNiArNDMs NyBAQCBjb25maWcgVVNCX01UVTNfRFVBTF9ST0xFCiAgICAgICAgYm9vbCAiRHVhbCBSb2xlIG1v ZGUiCiAgICAgICAgZGVwZW5kcyBvbiAoKFVTQj15IHx8IFVTQj1VU0JfTVRVMykgJiYgKFVTQl9H QURHRVQ9eSB8fCBVU0JfR0FER0VUPVVTQl9NVFUzKSkKICAgICAgICBkZXBlbmRzIG9uIChFWFRD T049eSB8fCBFWFRDT049VVNCX01UVTMpCisgICAgICAgZGVwZW5kcyBvbiBVU0JfUk9MRV9TV0lU Q0gKICAgICAgICBoZWxwCiAgICAgICAgICBUaGlzIGlzIHRoZSBkZWZhdWx0IG1vZGUgb2Ygd29y a2luZyBvZiBNVFUzIGNvbnRyb2xsZXIgd2hlcmUKICAgICAgICAgIGJvdGggaG9zdCBhbmQgZ2Fk Z2V0IGZlYXR1cmVzIGFyZSBlbmFibGVkLgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46D1BC43381 for ; Fri, 15 Mar 2019 09:27:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 165672184C for ; Fri, 15 Mar 2019 09:27:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UlpumwgR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 165672184C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zpKYTYvCKLqsAVa99W89XzT2iVBJvuAmNLbNAtWl2k0=; b=UlpumwgRgqKn08 FKINfFAlp9asbYE9ARokVBnQWLh09OfPHAaQ/kQWvfqlGWtASUXMgracwzaKghjZ5mav1Vn/r84zI Y6bnmw15V3Q02KVfgVK6KnN2dLL/6bKqZoVZQHd979uM5vEjjJYST52Wu+sweYwylSBJzBmNDyzyn OpmBtvju3thJWGYOR0D5f2ydACerCUzQx7OB1qEF2aq9zdv5JVaRnseMTYmSh7sUQNfVezuNrjnuC 8Njz7AzBLHuCZcEIf8nwj8HwIajnvCIP0PGhRfxwU77wk8oJ+HAt9jXJr6tTG18rYbqgHkeDwSJhH UpLvSSStSRmLdXgvz6vw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4j7A-0003PG-UJ; Fri, 15 Mar 2019 09:26:56 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4j76-0003OL-EI; Fri, 15 Mar 2019 09:26:54 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2019 02:26:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,481,1544515200"; d="scan'208";a="155290664" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 15 Mar 2019 02:26:45 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 15 Mar 2019 11:26:45 +0200 Date: Fri, 15 Mar 2019 11:26:44 +0200 From: Heikki Krogerus To: Chunfeng Yun Subject: Re: [PATCH v2 4/6] usb: roles: add API to get usb_role_switch by node Message-ID: <20190315092644.GG7752@kuha.fi.intel.com> References: <1552635513-2378-1-git-send-email-chunfeng.yun@mediatek.com> <1552635513-2378-5-git-send-email-chunfeng.yun@mediatek.com> <20190315081835.GD7752@kuha.fi.intel.com> <1552641204.10179.133.camel@mhfsdcap03> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1552641204.10179.133.camel@mhfsdcap03> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190315_022652_489436_9750C192 X-CRM114-Status: GOOD ( 12.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Hans de Goede , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , Rob Herring , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Chunfeng, On Fri, Mar 15, 2019 at 05:13:24PM +0800, Chunfeng Yun wrote: > I encounter a build error when CONFIG_USB_ROLE_SWITCH is not enabled, > > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_role_sw_register': > ./drivers/usb/mtu3/mtu3_dr.c:460: undefined reference to > `usb_role_switch_register' > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_otg_switch_exit': > ./drivers/usb/mtu3/mtu3_dr.c:491: undefined reference to > `usb_role_switch_unregister' So you need to add dependency on USB_ROLE_SWITCH, right? --- a/drivers/usb/mtu3/Kconfig +++ b/drivers/usb/mtu3/Kconfig @@ -43,6 +43,7 @@ config USB_MTU3_DUAL_ROLE bool "Dual Role mode" depends on ((USB=y || USB=USB_MTU3) && (USB_GADGET=y || USB_GADGET=USB_MTU3)) depends on (EXTCON=y || EXTCON=USB_MTU3) + depends on USB_ROLE_SWITCH help This is the default mode of working of MTU3 controller where both host and gadget features are enabled. > the following patch has fixed the issue, but seems not get into kernel, > [v3,08/12] usb: roles: Add usb role switch notifier. > https://patchwork.kernel.org/patch/10836525/ I don't understand how that fixes the problem? That patch will in any case be targeting v5.2. We are in the middle of merge window, so nothing is happening until v5.1-rc1 is tagged. thanks, -- heikki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel