All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Cc: <davem@davemloft.net>, <petrm@mellanox.com>,
	<idosch@mellanox.com>, <sd@queasysnail.net>,
	<mousuanming@huawei.com>, <netdev@vger.kernel.org>,
	Mingfangsen <mingfangsen@huawei.com>,
	"Zhoukang (A)" <zhoukang7@huawei.com>,
	"wangxiaogang (F)" <wangxiaogang3@huawei.com>
Subject: Re: [PATCH] vxlan: remove the redundant gro_cells_destroy() calling.
Date: Fri, 15 Mar 2019 12:54:34 +0100	[thread overview]
Message-ID: <20190315125434.093afbd1@elisabeth> (raw)
In-Reply-To: <2276c137-d5c0-bdbe-f5c7-5985ffc497ce@huawei.com>

On Fri, 15 Mar 2019 18:06:45 +0800
Zhiqiang Liu <liuzhiqiang26@huawei.com> wrote:

> From: "Suanming.Mou" <mousuanming@huawei.com>
> 
> With ad6c9986bcb6, GRO cells will be destroyed in vxlan_uninit.

Thanks for cleaning this up.

I think it would be nice if you could actually explain in the commit
message why this makes the call in vxlan_destroy_tunnels() redundant.

> Fixes: ad6c9986bcb6 ("vxlan: Fix GRO cells race condition between receive and link delete")

I'm not sure a Fixes: tag is appropriate here (and also if this
shouldn't be targeted for net-next) -- in the end, gro_cells_destroy()
there would just return:

        if (!gcells->cells)
                return;

> Signed-off-by: Suanming.Mou <mousuanming@huawei.com>

Either way,

Reviewed-by: Stefano Brivio <sbrivio@redhat.com>

-- 
Stefano

  reply	other threads:[~2019-03-15 11:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15 10:06 [PATCH] vxlan: remove the redundant gro_cells_destroy() calling Zhiqiang Liu
2019-03-15 11:54 ` Stefano Brivio [this message]
2019-03-15 14:55   ` Zhiqiang Liu
2019-03-15 15:25     ` Stefano Brivio
2019-03-15 14:58 ` Eric Dumazet
2019-03-15 15:18 ` [PATCH v2] " Zhiqiang Liu
2019-03-15 15:28   ` Stefano Brivio
2019-03-15 16:06     ` Eric Dumazet
2019-03-15 18:02       ` David Miller
2019-03-15 18:56         ` Eric Dumazet
2019-03-15 21:08           ` Stefano Brivio
2019-03-15 21:26             ` Eric Dumazet
2019-03-15 22:04               ` Stefano Brivio
2019-03-16  5:24                 ` Zhiqiang Liu
2019-03-16  5:45                   ` Stefano Brivio
2019-03-16  6:27                     ` Zhiqiang Liu
2019-03-16  2:33           ` Zhiqiang Liu
2019-03-16  9:02             ` [PATCH net v3] vxlan: Don't call gro_cells_destroy() before device is unregistered Zhiqiang Liu
2019-03-19  0:08               ` David Miller
2019-03-15 18:02     ` [PATCH v2] vxlan: remove the redundant gro_cells_destroy() calling David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190315125434.093afbd1@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=davem@davemloft.net \
    --cc=idosch@mellanox.com \
    --cc=liuzhiqiang26@huawei.com \
    --cc=mingfangsen@huawei.com \
    --cc=mousuanming@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=petrm@mellanox.com \
    --cc=sd@queasysnail.net \
    --cc=wangxiaogang3@huawei.com \
    --cc=zhoukang7@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.