From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=QDcT=RS=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 96A58C43381
	for <netdev@archiver.kernel.org>; Fri, 15 Mar 2019 15:28:52 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 701E9218C3
	for <netdev@archiver.kernel.org>; Fri, 15 Mar 2019 15:28:52 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729353AbfCOP2v (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 15 Mar 2019 11:28:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8640 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726842AbfCOP2u (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 15 Mar 2019 11:28:50 -0400
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
        (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
        (No client certificate requested)
        by mx1.redhat.com (Postfix) with ESMTPS id BADC6313C244;
        Fri, 15 Mar 2019 15:28:50 +0000 (UTC)
Received: from elisabeth (ovpn-200-27.brq.redhat.com [10.40.200.27])
        by smtp.corp.redhat.com (Postfix) with ESMTPS id B00FE1001DC7;
        Fri, 15 Mar 2019 15:28:37 +0000 (UTC)
Date:   Fri, 15 Mar 2019 16:28:24 +0100
From:   Stefano Brivio <sbrivio@redhat.com>
To:     Zhiqiang Liu <liuzhiqiang26@huawei.com>
Cc:     <davem@davemloft.net>, <petrm@mellanox.com>, <idosch@mellanox.com>,
        <sd@queasysnail.net>, <mousuanming@huawei.com>,
        <netdev@vger.kernel.org>, Mingfangsen <mingfangsen@huawei.com>,
        "Zhoukang (A)" <zhoukang7@huawei.com>,
        "wangxiaogang (F)" <wangxiaogang3@huawei.com>,
        Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH v2] vxlan: remove the redundant gro_cells_destroy()
 calling.
Message-ID: <20190315162824.732b18ac@elisabeth>
In-Reply-To: <e733fd70-df29-5007-d514-fc487741725b@huawei.com>
References: <2276c137-d5c0-bdbe-f5c7-5985ffc497ce@huawei.com>
        <e733fd70-df29-5007-d514-fc487741725b@huawei.com>
Organization: Red Hat
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 15 Mar 2019 15:28:50 +0000 (UTC)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Fri, 15 Mar 2019 23:18:52 +0800
Zhiqiang Liu <liuzhiqiang26@huawei.com> wrote:

> In vxlan_destroy_tunnels func, unregister_netdevice_queue is called after
> gro_cells_destroy func. However, in unregister_netdevice_queue func, the
> gro_cells_destroy func will also call the gro_cells_destroy func as the
> following routine:
> unregister_netdevice_many() -> rollback_registered_many()
> -> ndo_uninit() -> gro_cells_destroy()  
> 
> Signed-off-by: Suanming.Mou <mousuanming@huawei.com>
> Reviewed-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>

NACK, please read my and Eric's comments to v1 -- giving me more than 23
minutes to answer would have been a nice touch as well :)

-- 
Stefano