From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C8E0C43381 for ; Fri, 15 Mar 2019 16:58:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6384F218A1 for ; Fri, 15 Mar 2019 16:58:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729672AbfCOQ6I (ORCPT ); Fri, 15 Mar 2019 12:58:08 -0400 Received: from mga17.intel.com ([192.55.52.151]:39353 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728458AbfCOQ6H (ORCPT ); Fri, 15 Mar 2019 12:58:07 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2019 09:58:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,482,1544515200"; d="scan'208";a="155397166" Received: from black.fi.intel.com (HELO black.fi.intel.com.) ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 15 Mar 2019 09:58:03 -0700 From: Heikki Krogerus To: Hans de Goede Cc: Andy Shevchenko , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH 01/12] software node: Prevent potential NULL Pointer Dereference Date: Fri, 15 Mar 2019 19:57:49 +0300 Message-Id: <20190315165800.5058-2-heikki.krogerus@linux.intel.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190315165800.5058-1-heikki.krogerus@linux.intel.com> References: <20190315165800.5058-1-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Software nodes are not forced to have device properties. Adding check to property_entries_dup() to make it possible to create software nodes that don't have any properties. Signed-off-by: Heikki Krogerus --- drivers/base/swnode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c index 1fad9291f6aa..3a50a8edd3d3 100644 --- a/drivers/base/swnode.c +++ b/drivers/base/swnode.c @@ -383,6 +383,9 @@ property_entries_dup(const struct property_entry *properties) int i, n = 0; int ret; + if (!properties) + return NULL; + while (properties[n].name) n++; -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [01/12] software node: Prevent potential NULL Pointer Dereference From: Heikki Krogerus Message-Id: <20190315165800.5058-2-heikki.krogerus@linux.intel.com> Date: Fri, 15 Mar 2019 19:57:49 +0300 To: Hans de Goede Cc: Andy Shevchenko , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, platform-driver-x86@vger.kernel.org List-ID: U29mdHdhcmUgbm9kZXMgYXJlIG5vdCBmb3JjZWQgdG8gaGF2ZSBkZXZpY2UgcHJvcGVydGllcy4K QWRkaW5nIGNoZWNrIHRvIHByb3BlcnR5X2VudHJpZXNfZHVwKCkgdG8gbWFrZSBpdCBwb3NzaWJs ZQp0byBjcmVhdGUgc29mdHdhcmUgbm9kZXMgdGhhdCBkb24ndCBoYXZlIGFueSBwcm9wZXJ0aWVz LgoKU2lnbmVkLW9mZi1ieTogSGVpa2tpIEtyb2dlcnVzIDxoZWlra2kua3JvZ2VydXNAbGludXgu aW50ZWwuY29tPgotLS0KIGRyaXZlcnMvYmFzZS9zd25vZGUuYyB8IDMgKysrCiAxIGZpbGUgY2hh bmdlZCwgMyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9iYXNlL3N3bm9kZS5j IGIvZHJpdmVycy9iYXNlL3N3bm9kZS5jCmluZGV4IDFmYWQ5MjkxZjZhYS4uM2E1MGE4ZWRkM2Qz IDEwMDY0NAotLS0gYS9kcml2ZXJzL2Jhc2Uvc3dub2RlLmMKKysrIGIvZHJpdmVycy9iYXNlL3N3 bm9kZS5jCkBAIC0zODMsNiArMzgzLDkgQEAgcHJvcGVydHlfZW50cmllc19kdXAoY29uc3Qgc3Ry dWN0IHByb3BlcnR5X2VudHJ5ICpwcm9wZXJ0aWVzKQogCWludCBpLCBuID0gMDsKIAlpbnQgcmV0 OwogCisJaWYgKCFwcm9wZXJ0aWVzKQorCQlyZXR1cm4gTlVMTDsKKwogCXdoaWxlIChwcm9wZXJ0 aWVzW25dLm5hbWUpCiAJCW4rKzsKIAo=