From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A83E5C43381 for ; Fri, 15 Mar 2019 18:11:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73C5C2186A for ; Fri, 15 Mar 2019 18:11:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727075AbfCOSLJ (ORCPT ); Fri, 15 Mar 2019 14:11:09 -0400 Received: from mga14.intel.com ([192.55.52.115]:59343 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726487AbfCOSLJ (ORCPT ); Fri, 15 Mar 2019 14:11:09 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2019 11:11:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,483,1544515200"; d="scan'208";a="141115628" Received: from agluck-desk.sc.intel.com (HELO agluck-desk) ([10.3.52.160]) by FMSMGA003.fm.intel.com with ESMTP; 15 Mar 2019 11:11:08 -0700 Date: Fri, 15 Mar 2019 11:11:08 -0700 From: "Luck, Tony" To: Borislav Petkov Cc: Arnd Bergmann , Mauro Carvalho Chehab , James Morse , Qiuxu Zhuo , linux-edac@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] EDAC, {skx|i10nm}_edac: Fix randconfig build error Message-ID: <20190315181108.GA21111@agluck-desk> References: <20190313230137.GA12529@agluck-desk> <20190314110413.GA32277@zn.tnic> <20190314215952.GA303@agluck-desk> <20190315094341.GA12523@zn.tnic> <20190315155718.GA17775@agluck-desk> <20190315173720.GC12523@zn.tnic> <20190315174956.GA20831@agluck-desk> <20190315180206.GD12523@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190315180206.GD12523@zn.tnic> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 15, 2019 at 07:02:06PM +0100, Borislav Petkov wrote: > On Fri, Mar 15, 2019 at 10:49:56AM -0700, Luck, Tony wrote: > > Yes - Qiuxu did that already ... patch reposted below. > > ... to which Arnd said that it were fragile because it might break if it > includes a THIS_MODULE reference. So I'd say we won't do that then. And > keep it strictly a library. > > Right? What is your definition of "library"? fsl_ddr_edac.c seems to have the same potential for breakage if someone makes a change to that, then it will hit the same problem. -Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: EDAC, {skx|i10nm}_edac: Fix randconfig build error From: "Luck, Tony" Message-Id: <20190315181108.GA21111@agluck-desk> Date: Fri, 15 Mar 2019 11:11:08 -0700 To: Borislav Petkov Cc: Arnd Bergmann , Mauro Carvalho Chehab , James Morse , Qiuxu Zhuo , linux-edac@vger.kernel.org, Linux Kernel Mailing List List-ID: T24gRnJpLCBNYXIgMTUsIDIwMTkgYXQgMDc6MDI6MDZQTSArMDEwMCwgQm9yaXNsYXYgUGV0a292 IHdyb3RlOgo+IE9uIEZyaSwgTWFyIDE1LCAyMDE5IGF0IDEwOjQ5OjU2QU0gLTA3MDAsIEx1Y2ss IFRvbnkgd3JvdGU6Cj4gPiBZZXMgLSBRaXV4dSBkaWQgdGhhdCBhbHJlYWR5IC4uLiBwYXRjaCBy ZXBvc3RlZCBiZWxvdy4KPiAKPiAuLi4gdG8gd2hpY2ggQXJuZCBzYWlkIHRoYXQgaXQgd2VyZSBm cmFnaWxlIGJlY2F1c2UgaXQgbWlnaHQgYnJlYWsgaWYgaXQKPiBpbmNsdWRlcyBhIFRISVNfTU9E VUxFIHJlZmVyZW5jZS4gU28gSSdkIHNheSB3ZSB3b24ndCBkbyB0aGF0IHRoZW4uIEFuZAo+IGtl ZXAgaXQgc3RyaWN0bHkgYSBsaWJyYXJ5Lgo+IAo+IFJpZ2h0PwoKV2hhdCBpcyB5b3VyIGRlZmlu aXRpb24gb2YgImxpYnJhcnkiPwoKZnNsX2Rkcl9lZGFjLmMgc2VlbXMgdG8gaGF2ZSB0aGUgc2Ft ZSBwb3RlbnRpYWwgZm9yIGJyZWFrYWdlCmlmIHNvbWVvbmUgbWFrZXMgYSBjaGFuZ2UgdG8gdGhh dCwgdGhlbiBpdCB3aWxsIGhpdCB0aGUgc2FtZQpwcm9ibGVtLgoKLVRvbnkK