From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: Add bindings for TI ADS8344 A/DC chips Date: Sat, 16 Mar 2019 17:07:30 +0000 Message-ID: <20190316170730.2ed341cc@archlinux> References: <20190315151152.30467-1-gregory.clement@bootlin.com> <20190315151152.30467-2-gregory.clement@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190315151152.30467-2-gregory.clement@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Gregory CLEMENT Cc: devicetree@vger.kernel.org, Alexandre Belloni , Lars-Peter Clausen , Thomas Petazzoni , linux-iio@vger.kernel.org, Rob Herring , Peter Meerwald-Stadler , Hartmut Knaack , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Fri, 15 Mar 2019 16:11:50 +0100 Gregory CLEMENT wrote: > This adds device tree bindings for the TI ADS8344 A/DC chips. > > Signed-off-by: Gregory CLEMENT Looks good to me, though io-channel-cells only needs to be 1 if you have consumers... Otherwise, it shouldn't be there at all.. Jonathan > --- > .../bindings/iio/adc/ti-ads8344.txt | 21 +++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt > new file mode 100644 > index 000000000000..6576c4fed7b7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt > @@ -0,0 +1,21 @@ > +* Texas Instruments ADS8344 A/DC chip > + > +Required properties: > + - compatible: Must be "ti,ads8344" > + - #io-channel-cells: Must be 1 as per ../iio-bindings.txt > + - reg: SPI chip select number for the device > + - vref-supply: phandle to a regulator node that supplies the > + reference voltage > + > +Recommended properties: > + - spi-max-frequency: Definition as per > + Documentation/devicetree/bindings/spi/spi-bus.txt > + > +Example: > +adc@0 { > + compatible = "ti,ads8344"; > + reg = <0>; > + #io-channel-cells = <1>; > + vref-supply = <&refin_supply>; > + spi-max-frequency = <10000000>; > +}; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 009B1C43381 for ; Sat, 16 Mar 2019 17:07:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7A46218D4 for ; Sat, 16 Mar 2019 17:07:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552756057; bh=BfsTFg58GpNDl8SbtHPiuuRkF+zjR7vWDAovzf7COAM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=dqXW19oJXuZPuHLd8JqcHn09/P7Q534jlDBnzUp5CUj46kIuwOfYh6vtbH0tTx7wG GMPN2KszSH7i2fNy8bMGF0rQcdt1qT9PCj/p2FsqpkFa+bmvKmzQ45shxcICGiJhMk m/uZxCJIgWZmyqSwAzwxqQ0UdCATRazwMNnDD/no= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726982AbfCPRHh (ORCPT ); Sat, 16 Mar 2019 13:07:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:48780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726910AbfCPRHh (ORCPT ); Sat, 16 Mar 2019 13:07:37 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2FD4F2186A; Sat, 16 Mar 2019 17:07:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552756056; bh=BfsTFg58GpNDl8SbtHPiuuRkF+zjR7vWDAovzf7COAM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vxOxq32jXIkF2BpTE0QlGPeVMFcQYnqKI8reh7eF7q5ye5msB5XkSdsk4y6EjnZ8n LVvPYCQiyH5mI4saGSplO5c/ZnLzF83E9wY2PZD1kDGOXAE3k222+j+4iogjw8gEjE 77tR24Fdq4627OuNCA5x+Gzyelvzfxe4TfaKIR9E= Date: Sat, 16 Mar 2019 17:07:30 +0000 From: Jonathan Cameron To: Gregory CLEMENT Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Alexandre Belloni Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: Add bindings for TI ADS8344 A/DC chips Message-ID: <20190316170730.2ed341cc@archlinux> In-Reply-To: <20190315151152.30467-2-gregory.clement@bootlin.com> References: <20190315151152.30467-1-gregory.clement@bootlin.com> <20190315151152.30467-2-gregory.clement@bootlin.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 15 Mar 2019 16:11:50 +0100 Gregory CLEMENT wrote: > This adds device tree bindings for the TI ADS8344 A/DC chips. > > Signed-off-by: Gregory CLEMENT Looks good to me, though io-channel-cells only needs to be 1 if you have consumers... Otherwise, it shouldn't be there at all.. Jonathan > --- > .../bindings/iio/adc/ti-ads8344.txt | 21 +++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt > new file mode 100644 > index 000000000000..6576c4fed7b7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt > @@ -0,0 +1,21 @@ > +* Texas Instruments ADS8344 A/DC chip > + > +Required properties: > + - compatible: Must be "ti,ads8344" > + - #io-channel-cells: Must be 1 as per ../iio-bindings.txt > + - reg: SPI chip select number for the device > + - vref-supply: phandle to a regulator node that supplies the > + reference voltage > + > +Recommended properties: > + - spi-max-frequency: Definition as per > + Documentation/devicetree/bindings/spi/spi-bus.txt > + > +Example: > +adc@0 { > + compatible = "ti,ads8344"; > + reg = <0>; > + #io-channel-cells = <1>; > + vref-supply = <&refin_supply>; > + spi-max-frequency = <10000000>; > +}; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B34AC43381 for ; Sat, 16 Mar 2019 17:07:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 184D8218D4 for ; Sat, 16 Mar 2019 17:07:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JlXY1dDB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vxOxq32j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 184D8218D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qh4uKflQkC3OvLJpkmRajM/iVYTGZuQRfuyIGz/col4=; b=JlXY1dDBCMD3v0 WVdUoHFUwBeL2b33+gzdW5pQrZvNSTk1NP1KTrVMBZZKdb6NW1gXdwP9Gg8NaXHei1e57p8DEM2ma GtnK1PAqRuitviYUcqyKZf9pPGZcRdg0Qd/0GoUM25g5PmbHIqkgS6l60flgnAUOMckaPS4A1/fVh PKXu5pU/p/UPZL4+opXs71U0OsVxmBX05ofxMX1+5rDrefe7sjk/09i8rzwX6mrrwHGT+C3PBluk4 aq/MdYx2eun/RWrMPXvqD8SDRCio1XrGcwyFNzQ0lXLvdpBPiR+nI3Pxlka39VIQqoZCm8VBJ60Mk guUNSMLvm+saScaVk5Jg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5Cma-0006Yk-AL; Sat, 16 Mar 2019 17:07:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5CmW-0006YM-VJ for linux-arm-kernel@lists.infradead.org; Sat, 16 Mar 2019 17:07:38 +0000 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2FD4F2186A; Sat, 16 Mar 2019 17:07:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552756056; bh=BfsTFg58GpNDl8SbtHPiuuRkF+zjR7vWDAovzf7COAM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vxOxq32jXIkF2BpTE0QlGPeVMFcQYnqKI8reh7eF7q5ye5msB5XkSdsk4y6EjnZ8n LVvPYCQiyH5mI4saGSplO5c/ZnLzF83E9wY2PZD1kDGOXAE3k222+j+4iogjw8gEjE 77tR24Fdq4627OuNCA5x+Gzyelvzfxe4TfaKIR9E= Date: Sat, 16 Mar 2019 17:07:30 +0000 From: Jonathan Cameron To: Gregory CLEMENT Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: Add bindings for TI ADS8344 A/DC chips Message-ID: <20190316170730.2ed341cc@archlinux> In-Reply-To: <20190315151152.30467-2-gregory.clement@bootlin.com> References: <20190315151152.30467-1-gregory.clement@bootlin.com> <20190315151152.30467-2-gregory.clement@bootlin.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190316_100737_019232_34BDF3FA X-CRM114-Status: GOOD ( 14.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandre Belloni , Lars-Peter Clausen , Thomas Petazzoni , linux-iio@vger.kernel.org, Rob Herring , Peter Meerwald-Stadler , Hartmut Knaack , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 15 Mar 2019 16:11:50 +0100 Gregory CLEMENT wrote: > This adds device tree bindings for the TI ADS8344 A/DC chips. > > Signed-off-by: Gregory CLEMENT Looks good to me, though io-channel-cells only needs to be 1 if you have consumers... Otherwise, it shouldn't be there at all.. Jonathan > --- > .../bindings/iio/adc/ti-ads8344.txt | 21 +++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt > new file mode 100644 > index 000000000000..6576c4fed7b7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads8344.txt > @@ -0,0 +1,21 @@ > +* Texas Instruments ADS8344 A/DC chip > + > +Required properties: > + - compatible: Must be "ti,ads8344" > + - #io-channel-cells: Must be 1 as per ../iio-bindings.txt > + - reg: SPI chip select number for the device > + - vref-supply: phandle to a regulator node that supplies the > + reference voltage > + > +Recommended properties: > + - spi-max-frequency: Definition as per > + Documentation/devicetree/bindings/spi/spi-bus.txt > + > +Example: > +adc@0 { > + compatible = "ti,ads8344"; > + reg = <0>; > + #io-channel-cells = <1>; > + vref-supply = <&refin_supply>; > + spi-max-frequency = <10000000>; > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel