From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Subject: Re: [PATCH v3 15/17] KVM: PPC: Book3S HV: XIVE: activate XIVE exploitation mode Date: Mon, 18 Mar 2019 17:42:16 +1100 Message-ID: <20190318064215.GM6874@umbus.fritz.box> References: <20190315120609.25910-1-clg@kaod.org> <20190315120609.25910-16-clg@kaod.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HL3CiL6n73+IAdG4" Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org To: =?iso-8859-1?Q?C=E9dric?= Le Goater Return-path: Content-Disposition: inline In-Reply-To: <20190315120609.25910-16-clg@kaod.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org --HL3CiL6n73+IAdG4 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 15, 2019 at 01:06:07PM +0100, C=E9dric Le Goater wrote: > Full support for the XIVE native exploitation mode is now available, > advertise the capability KVM_CAP_PPC_IRQ_XIVE for guests running on > PowerNV KVM Hypervisors only. Support for nested guests (pseries KVM > Hypervisor) is not yet available. XIVE should also have been activated > which is default setting on POWER9 systems running a recent Linux > kernel. >=20 > Signed-off-by: C=E9dric Le Goater Reviewed-by: David Gibson > --- > arch/powerpc/kvm/powerpc.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c > index bb51faf29162..d70b19f8725b 100644 > --- a/arch/powerpc/kvm/powerpc.c > +++ b/arch/powerpc/kvm/powerpc.c > @@ -573,10 +573,11 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, l= ong ext) > #ifdef CONFIG_KVM_XIVE > case KVM_CAP_PPC_IRQ_XIVE: > /* > - * Return false until all the XIVE infrastructure is > - * in place including support for migration. > + * We need XIVE to be enabled on the platform (implies > + * a POWER9 processor) and the PowerNV platform, as > + * nested is not yet supported. > */ > - r =3D 0; > + r =3D xive_enabled() && !!cpu_has_feature(CPU_FTR_HVMODE); Nit: && is already a logical operation, so there should be no need for the '!!' here. > break; > #endif > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --HL3CiL6n73+IAdG4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAlyPPcUACgkQbDjKyiDZ s5JLWA/+LxwfSrc+t6qJWKYlK+kkfMfbLG6mmS+iEl5JnuaSnYgDMX2RSSKq1SMI T4SgbCtp96X4Y95ui10lFHa/discjkWkLuAUfypn/2cX+LGQDpYl1TQOuoKpLGTY fI8DXGn1khBxIo/I5IqI6zJY7k0ROH3m0RpVVq50X+oVtz/3LRRhT0b2i4naSPob o6F/K3obYJOX0ojnlBF6eWIMlGH/Ke+7IRZLRpXjvXz02TI0IphdFDL6lcY24KSH f4eMuLEyzxs/6da52allb0N79m/Kn1XrkCMaGXW/XIakJvcfIWWwFIAcbfR2UaYn ungItkGB92ZQ8HY0s86ygkk7tYiuXFo/ymbqo6NQYMv3gbDusO8B9lWr3izqKkFm kjY8/VBRJVE23MpXZlwatEIP/6E2BJ+g+WbQJ+72y5ZuLNuObPHkjfFbENBA4mNf 5RCN/i43/EyVcLHWmXQmG81N8imKWs/eLo2KR969IkygKaWJV1M/bwkvzQAwyC1E C6B0tU2af6gvxOy0j7BXdvtkzFsBBOqQdDBjKQnQOCymf0te3OR9FP5mbtQEbTn7 Ojygz2gyfnEYC52Aihe2XRjqr5LN2zc3wDcLvOKCLywB9Xm7griTjxL+wSIbsrbm fOcezy5NFn6ocvbuQmOI9ru6Ka2kak/lp5b++rhddE7BAOaJgU4= =peFu -----END PGP SIGNATURE----- --HL3CiL6n73+IAdG4-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson Date: Mon, 18 Mar 2019 06:42:16 +0000 Subject: Re: [PATCH v3 15/17] KVM: PPC: Book3S HV: XIVE: activate XIVE exploitation mode Message-Id: <20190318064215.GM6874@umbus.fritz.box> MIME-Version: 1 Content-Type: multipart/mixed; boundary="HL3CiL6n73+IAdG4" List-Id: References: <20190315120609.25910-1-clg@kaod.org> <20190315120609.25910-16-clg@kaod.org> In-Reply-To: <20190315120609.25910-16-clg@kaod.org> To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org --HL3CiL6n73+IAdG4 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 15, 2019 at 01:06:07PM +0100, C=E9dric Le Goater wrote: > Full support for the XIVE native exploitation mode is now available, > advertise the capability KVM_CAP_PPC_IRQ_XIVE for guests running on > PowerNV KVM Hypervisors only. Support for nested guests (pseries KVM > Hypervisor) is not yet available. XIVE should also have been activated > which is default setting on POWER9 systems running a recent Linux > kernel. >=20 > Signed-off-by: C=E9dric Le Goater Reviewed-by: David Gibson > --- > arch/powerpc/kvm/powerpc.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c > index bb51faf29162..d70b19f8725b 100644 > --- a/arch/powerpc/kvm/powerpc.c > +++ b/arch/powerpc/kvm/powerpc.c > @@ -573,10 +573,11 @@ int kvm_vm_ioctl_check_extension(struct kvm *kvm, l= ong ext) > #ifdef CONFIG_KVM_XIVE > case KVM_CAP_PPC_IRQ_XIVE: > /* > - * Return false until all the XIVE infrastructure is > - * in place including support for migration. > + * We need XIVE to be enabled on the platform (implies > + * a POWER9 processor) and the PowerNV platform, as > + * nested is not yet supported. > */ > - r =3D 0; > + r =3D xive_enabled() && !!cpu_has_feature(CPU_FTR_HVMODE); Nit: && is already a logical operation, so there should be no need for the '!!' here. > break; > #endif > =20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --HL3CiL6n73+IAdG4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAlyPPcUACgkQbDjKyiDZ s5JLWA/+LxwfSrc+t6qJWKYlK+kkfMfbLG6mmS+iEl5JnuaSnYgDMX2RSSKq1SMI T4SgbCtp96X4Y95ui10lFHa/discjkWkLuAUfypn/2cX+LGQDpYl1TQOuoKpLGTY fI8DXGn1khBxIo/I5IqI6zJY7k0ROH3m0RpVVq50X+oVtz/3LRRhT0b2i4naSPob o6F/K3obYJOX0ojnlBF6eWIMlGH/Ke+7IRZLRpXjvXz02TI0IphdFDL6lcY24KSH f4eMuLEyzxs/6da52allb0N79m/Kn1XrkCMaGXW/XIakJvcfIWWwFIAcbfR2UaYn ungItkGB92ZQ8HY0s86ygkk7tYiuXFo/ymbqo6NQYMv3gbDusO8B9lWr3izqKkFm kjY8/VBRJVE23MpXZlwatEIP/6E2BJ+g+WbQJ+72y5ZuLNuObPHkjfFbENBA4mNf 5RCN/i43/EyVcLHWmXQmG81N8imKWs/eLo2KR969IkygKaWJV1M/bwkvzQAwyC1E C6B0tU2af6gvxOy0j7BXdvtkzFsBBOqQdDBjKQnQOCymf0te3OR9FP5mbtQEbTn7 Ojygz2gyfnEYC52Aihe2XRjqr5LN2zc3wDcLvOKCLywB9Xm7griTjxL+wSIbsrbm fOcezy5NFn6ocvbuQmOI9ru6Ka2kak/lp5b++rhddE7BAOaJgU4= =peFu -----END PGP SIGNATURE----- --HL3CiL6n73+IAdG4--