From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0BAEC43381 for ; Mon, 18 Mar 2019 09:10:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB73020854 for ; Mon, 18 Mar 2019 09:10:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727188AbfCRJKR (ORCPT ); Mon, 18 Mar 2019 05:10:17 -0400 Received: from mga03.intel.com ([134.134.136.65]:3876 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726835AbfCRJKR (ORCPT ); Mon, 18 Mar 2019 05:10:17 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Mar 2019 02:10:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,493,1544515200"; d="scan'208";a="155953197" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 18 Mar 2019 02:10:11 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Mon, 18 Mar 2019 11:10:10 +0200 Date: Mon, 18 Mar 2019 11:10:10 +0200 From: Heikki Krogerus To: Andy Shevchenko Cc: Hans de Goede , Linux Kernel Mailing List , USB , Platform Driver Subject: Re: [PATCH 07/12] platform/x86: intel_cht_int33fe: Provide software node for all components Message-ID: <20190318091010.GN7752@kuha.fi.intel.com> References: <20190315165800.5058-1-heikki.krogerus@linux.intel.com> <20190315165800.5058-8-heikki.krogerus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 17, 2019 at 10:36:03PM +0200, Andy Shevchenko wrote: > On Fri, Mar 15, 2019 at 6:58 PM Heikki Krogerus > wrote: > > > > Software nodes provide two features that we will need later. > > 1) Software nodes can have references to other software nodes. > > 2) Software nodes can exist before a device entry is created. > > > > I don't see any problems with code (*), though I hope Hans will have > chance to test this. > One nit below. > > (*) Means all patches touching PDx86 in this series > > > Signed-off-by: Heikki Krogerus > > --- > > drivers/platform/x86/intel_cht_int33fe.c | 122 +++++++++++++++++------ > > 1 file changed, 92 insertions(+), 30 deletions(-) > > > > diff --git a/drivers/platform/x86/intel_cht_int33fe.c b/drivers/platform/x86/intel_cht_int33fe.c > > index 6fa3cced6f8e..26444d31945b 100644 > > --- a/drivers/platform/x86/intel_cht_int33fe.c > > +++ b/drivers/platform/x86/intel_cht_int33fe.c > > @@ -24,15 +24,25 @@ > > #include > > #include > > #include > > > +#include > > Preserve the ordering, please. OK. thanks, -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [07/12] platform/x86: intel_cht_int33fe: Provide software node for all components From: Heikki Krogerus Message-Id: <20190318091010.GN7752@kuha.fi.intel.com> Date: Mon, 18 Mar 2019 11:10:10 +0200 To: Andy Shevchenko Cc: Hans de Goede , Linux Kernel Mailing List , USB , Platform Driver List-ID: T24gU3VuLCBNYXIgMTcsIDIwMTkgYXQgMTA6MzY6MDNQTSArMDIwMCwgQW5keSBTaGV2Y2hlbmtv IHdyb3RlOgo+IE9uIEZyaSwgTWFyIDE1LCAyMDE5IGF0IDY6NTggUE0gSGVpa2tpIEtyb2dlcnVz Cj4gPGhlaWtraS5rcm9nZXJ1c0BsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4KPiA+IFNvZnR3 YXJlIG5vZGVzIHByb3ZpZGUgdHdvIGZlYXR1cmVzIHRoYXQgd2Ugd2lsbCBuZWVkIGxhdGVyLgo+ ID4gMSkgU29mdHdhcmUgbm9kZXMgY2FuIGhhdmUgcmVmZXJlbmNlcyB0byBvdGhlciBzb2Z0d2Fy ZSBub2Rlcy4KPiA+IDIpIFNvZnR3YXJlIG5vZGVzIGNhbiBleGlzdCBiZWZvcmUgYSBkZXZpY2Ug ZW50cnkgaXMgY3JlYXRlZC4KPiA+Cj4gCj4gSSBkb24ndCBzZWUgYW55IHByb2JsZW1zIHdpdGgg Y29kZSAoKiksIHRob3VnaCBJIGhvcGUgSGFucyB3aWxsIGhhdmUKPiBjaGFuY2UgdG8gdGVzdCB0 aGlzLgo+IE9uZSBuaXQgYmVsb3cuCj4gCj4gKCopIE1lYW5zIGFsbCBwYXRjaGVzIHRvdWNoaW5n IFBEeDg2IGluIHRoaXMgc2VyaWVzCj4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBIZWlra2kgS3JvZ2Vy dXMgPGhlaWtraS5rcm9nZXJ1c0BsaW51eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJz L3BsYXRmb3JtL3g4Ni9pbnRlbF9jaHRfaW50MzNmZS5jIHwgMTIyICsrKysrKysrKysrKysrKysr LS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDkyIGluc2VydGlvbnMoKyksIDMwIGRlbGV0aW9u cygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BsYXRmb3JtL3g4Ni9pbnRlbF9jaHRf aW50MzNmZS5jIGIvZHJpdmVycy9wbGF0Zm9ybS94ODYvaW50ZWxfY2h0X2ludDMzZmUuYwo+ID4g aW5kZXggNmZhM2NjZWQ2ZjhlLi4yNjQ0NGQzMTk0NWIgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJz L3BsYXRmb3JtL3g4Ni9pbnRlbF9jaHRfaW50MzNmZS5jCj4gPiArKysgYi9kcml2ZXJzL3BsYXRm b3JtL3g4Ni9pbnRlbF9jaHRfaW50MzNmZS5jCj4gPiBAQCAtMjQsMTUgKzI0LDI1IEBACj4gPiAg I2luY2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RldmljZS5oPgo+ID4gICNpbmNsdWRlIDxsaW51eC9y ZWd1bGF0b3IvY29uc3VtZXIuaD4KPiA+ICAjaW5jbHVkZSA8bGludXgvc2xhYi5oPgo+IAo+ID4g KyNpbmNsdWRlIDxsaW51eC9wY2kuaD4KPiAKPiBQcmVzZXJ2ZSB0aGUgb3JkZXJpbmcsIHBsZWFz ZS4KCk9LLgoKdGhhbmtzLAo=