From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ECF9C43381 for ; Mon, 18 Mar 2019 19:16:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5EA1C213F2 for ; Mon, 18 Mar 2019 19:16:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="Uh+PjEz/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727609AbfCRTQs (ORCPT ); Mon, 18 Mar 2019 15:16:48 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:33199 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726995AbfCRTQr (ORCPT ); Mon, 18 Mar 2019 15:16:47 -0400 Received: by mail-qk1-f196.google.com with SMTP id k189so5103693qkc.0 for ; Mon, 18 Mar 2019 12:16:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=zYvr/z85FGPR7BRmotAQ9kr2Nh6umMdMfpVEiJkKeOk=; b=Uh+PjEz/pUxzKHrHxM4AOP/PF+mwnUFVUnJ2owNbZ4L+qOlaCkgT5fzqPePU4OnZJB LG5n0Zrp1WwdDEtbJHB3lxwaaHmNitqQF9cpI610SVkyeGO9dbzsZSybuzihYO5GBzC8 T537dES9wJZ8UPF+HC0klOz3R+K6i/QY89b9cm6Yh2z2TGprUAJ3jEXBTyripqfQocVX ZZDL71+5tApyFnmGHAsyrI4XBedbzh6ir12JOOAvjikKg3r2MiSkF+WPZtYTY/w/yo/g 2AfzJI32NeTPmYoQTR5zCxxuVVcgTMmia85d8GI1c69kSnAXp5OGa58iLU8cKetKAn/i RCJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=zYvr/z85FGPR7BRmotAQ9kr2Nh6umMdMfpVEiJkKeOk=; b=TQIasZnVYzEJT197E2MbDMVuAMDzfhVl11TtTI8yepakJ3F0UWlJTwa6svhMER7k8V AG3sT+skFHDMoOqBU+8FnXldX5hRbZRc36vRG7rfVswXDBpxAmCxMj0eCwJ0/tDpjX08 58Y3kH4MDp+dNonAV4nUbamR6+DGExW9k0+XXn6YdF6IUbEil8Ftm74vpgsjCGjhLzVB 6mRMtzjjhHvsK3U31tXLbzjqvaN2iCt+1oofXEskrJ0MKKnbOH2t5w5cTzwbWhDxIoCB A78r3jyvNGDAJDNGnm0FN+CDHY37uLuWAEG30hz6Xn/S3wSA5WvjnNm2WiS8KEnNKPxp CZ3w== X-Gm-Message-State: APjAAAUc8kCqM7Dh2xVgExuV5dBcr0ottCWd7/eB1Ca4Wgfc8llz+ctm 2zribVP3lSfqfmtj7zFta8FISQ== X-Google-Smtp-Source: APXvYqzgqgWnld1X5ZJXIHdcEa8Moo1G2exUoy7JTVTLsogwSB0P7JCvsB7HpFjEjLq2k+Ey1eUQgQ== X-Received: by 2002:a37:83c6:: with SMTP id f189mr13846879qkd.196.1552936606827; Mon, 18 Mar 2019 12:16:46 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id d17sm3815171qtl.43.2019.03.18.12.16.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Mar 2019 12:16:46 -0700 (PDT) Date: Mon, 18 Mar 2019 12:16:42 -0700 From: Jakub Kicinski To: Jiri Pirko Cc: Parav Pandit , "Samudrala, Sridhar" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Message-ID: <20190318121642.74a56b7e@cakuba.netronome.com> In-Reply-To: <20190318121154.GG2270@nanopsycho> References: <20190314150945.031d1b08@cakuba.netronome.com> <20190314163915.24fd2481@cakuba.netronome.com> <4436da3d-4b99-f792-8e77-695d5958794d@intel.com> <20190315200814.GD2305@nanopsycho> <20190315134454.581f47ca@cakuba.netronome.com> <20190318121154.GG2270@nanopsycho> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 18 Mar 2019 13:11:54 +0100, Jiri Pirko wrote: > >> >2. flavour should not be vf/pf, flavour should be hostport, switchport. > >> >Because switch is flat and agnostic of pf/vf/mdev. > >> > >> Not sure. It's good to have this kind of visibility. > > > >Yes, this subthread honestly makes me go from 60% sure to 95% sure we > >shouldn't do the dual object thing :( Seems like Parav is already > >confused by it and suggests host port can exist without switch port :( > > Although I understand your hesitation, the host ports are also > associated with the asic and should be under the devlink instance. > It is just a matter of proper documentation and clear code to avoid > confusions. They are certainly a part and belong to the ASIC, the question in my mind is more along the lines of do we want "one pipe/one port" or is it okay to have multiple software objects of the same kind for those objects. To put it differently - do want a port object for each port of the ASIC or do we want a port object for each netdev..